diff mbox series

[5/5] ARM: dts: imx6ull: add TQ-Systems MBa6ULLxL device trees

Message ID 20220208134223.908757-6-alexander.stein@ew.tq-group.com (mailing list archive)
State New, archived
Headers show
Series Support for TQMa6ULx & TQMa6ULxL modules | expand

Commit Message

Alexander Stein Feb. 8, 2022, 1:42 p.m. UTC 
Add device trees for the MBa6ULx mainboard with TQMa6ULLxL SoMs.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm/boot/dts/Makefile                    |  1 +
 .../boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts   | 15 ++++
 arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi     | 76 +++++++++++++++++++
 3 files changed, 92 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts
 create mode 100644 arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi

Comments

Krzysztof Kozlowski Feb. 8, 2022, 4:09 p.m. UTC | #1 
On 08/02/2022 14:42, Alexander Stein wrote:
> Add device trees for the MBa6ULx mainboard with TQMa6ULLxL SoMs.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm/boot/dts/Makefile                    |  1 +
>  .../boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts   | 15 ++++
>  arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi     | 76 +++++++++++++++++++
>  3 files changed, 92 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts
>  create mode 100644 arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 3a6eccb6371a..9bf89273ae71 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -710,6 +710,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
>  	imx6ull-phytec-segin-ff-rdk-emmc.dtb \
>  	imx6ull-phytec-segin-lc-rdk-nand.dtb \
>  	imx6ull-tqma6ull2-mba6ulx.dtb \
> +	imx6ull-tqma6ull2l-mba6ulx.dtb \
>  	imx6ulz-14x14-evk.dtb \
>  	imx6ulz-bsh-smm-m2.dtb
>  dtb-$(CONFIG_SOC_IMX7D) += \
> diff --git a/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts b/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts
> new file mode 100644
> index 000000000000..33437aae9822
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
> +/*
> + * Copyright 2018-2022 TQ-Systems GmbH
> + * Author: Markus Niebel <Markus.Niebel@tq-group.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "imx6ull-tqma6ull2l.dtsi"
> +#include "mba6ulx.dtsi"
> +
> +/ {
> +	model = "TQ Systems TQMa6ULL2L SoM on MBa6ULx board";
> +	compatible = "tq,imx6ull-tqma6ull2l-mba6ulx", "tq,imx6ull-tqma6ull2l", "fsl,imx6ull";
> +};
> diff --git a/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi b/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi
> new file mode 100644
> index 000000000000..8e4d5cd18614
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi
> @@ -0,0 +1,76 @@
> +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
> +/*
> + * Copyright 2018-2022 TQ-Systems GmbH
> + * Author: Markus Niebel <Markus.Niebel@tq-group.com>
> + */
> +
> +#include "imx6ull.dtsi"
> +#include "imx6ul-tqma6ul-common.dtsi"
> +#include "imx6ul-tqma6ulxl-common.dtsi"
> +
> +/ {
> +	model = "TQ Systems TQMa6ULL2L SoM";
> +	compatible = "tq,imx6ull-tqma6ull2l", "fsl,imx6ull";
> +};
> +

This entire file is exactly the same as tqma6ull2l.dtsi. What's the
point of creating additional flavor which is exactly the same? The
models look compatible, don't they?


Best regards,
Krzysztof
Alexander Stein Feb. 10, 2022, 12:10 p.m. UTC | #2 
Hi Krzysztof,

Am Dienstag, 8. Februar 2022, 17:09:33 CET schrieb Krzysztof Kozlowski:
> On 08/02/2022 14:42, Alexander Stein wrote:
> > Add device trees for the MBa6ULx mainboard with TQMa6ULLxL SoMs.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > 
> >  arch/arm/boot/dts/Makefile                    |  1 +
> >  .../boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts   | 15 ++++
> >  arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi     | 76 +++++++++++++++++++
> >  3 files changed, 92 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts
> >  create mode 100644 arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi
> > 
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 3a6eccb6371a..9bf89273ae71 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -710,6 +710,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
> > 
> >  	imx6ull-phytec-segin-ff-rdk-emmc.dtb \
> >  	imx6ull-phytec-segin-lc-rdk-nand.dtb \
> >  	imx6ull-tqma6ull2-mba6ulx.dtb \
> > 
> > +	imx6ull-tqma6ull2l-mba6ulx.dtb \
> > 
> >  	imx6ulz-14x14-evk.dtb \
> >  	imx6ulz-bsh-smm-m2.dtb
> >  
> >  dtb-$(CONFIG_SOC_IMX7D) += \
> > 
> > diff --git a/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts
> > b/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts new file mode 100644
> > index 000000000000..33437aae9822
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts
> > @@ -0,0 +1,15 @@
> > +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
> > +/*
> > + * Copyright 2018-2022 TQ-Systems GmbH
> > + * Author: Markus Niebel <Markus.Niebel@tq-group.com>
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "imx6ull-tqma6ull2l.dtsi"
> > +#include "mba6ulx.dtsi"
> > +
> > +/ {
> > +	model = "TQ Systems TQMa6ULL2L SoM on MBa6ULx board";
> > +	compatible = "tq,imx6ull-tqma6ull2l-mba6ulx", "tq,imx6ull-
tqma6ull2l",
> > "fsl,imx6ull"; +};
> > diff --git a/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi
> > b/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi new file mode 100644
> > index 000000000000..8e4d5cd18614
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi
> > @@ -0,0 +1,76 @@
> > +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
> > +/*
> > + * Copyright 2018-2022 TQ-Systems GmbH
> > + * Author: Markus Niebel <Markus.Niebel@tq-group.com>
> > + */
> > +
> > +#include "imx6ull.dtsi"
> > +#include "imx6ul-tqma6ul-common.dtsi"
> > +#include "imx6ul-tqma6ulxl-common.dtsi"
> > +
> > +/ {
> > +	model = "TQ Systems TQMa6ULL2L SoM";
> > +	compatible = "tq,imx6ull-tqma6ull2l", "fsl,imx6ull";
> > +};
> > +
> 
> This entire file is exactly the same as tqma6ull2l.dtsi. What's the
> point of creating additional flavor which is exactly the same? The
> models look compatible, don't they?

Thanks for your fast feedback. You mean imx6ull-tqma6ull2.dtsi (wthout 
trailing 'l')? In this case it's not exactly the same, because the LGA version 
includes 'imx6ul-tqma6ulxl-common.dtsi' while the non-LGA one includes 
'imx6ul-tqma6ulx-common.dtsi'.

I this make things a bit more clear.
Regards,
Alexander
Krzysztof Kozlowski Feb. 10, 2022, 12:20 p.m. UTC | #3 
On 10/02/2022 13:10, Alexander Stein wrote:
> Hi Krzysztof,
> 
> Am Dienstag, 8. Februar 2022, 17:09:33 CET schrieb Krzysztof Kozlowski:
>> On 08/02/2022 14:42, Alexander Stein wrote:
>>> Add device trees for the MBa6ULx mainboard with TQMa6ULLxL SoMs.
>>>
>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>> ---
>>>
>>>  arch/arm/boot/dts/Makefile                    |  1 +
>>>  .../boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts   | 15 ++++
>>>  arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi     | 76 +++++++++++++++++++
>>>  3 files changed, 92 insertions(+)
>>>  create mode 100644 arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts
>>>  create mode 100644 arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi
>>>
>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>> index 3a6eccb6371a..9bf89273ae71 100644
>>> --- a/arch/arm/boot/dts/Makefile
>>> +++ b/arch/arm/boot/dts/Makefile
>>> @@ -710,6 +710,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
>>>
>>>  	imx6ull-phytec-segin-ff-rdk-emmc.dtb \
>>>  	imx6ull-phytec-segin-lc-rdk-nand.dtb \
>>>  	imx6ull-tqma6ull2-mba6ulx.dtb \
>>>
>>> +	imx6ull-tqma6ull2l-mba6ulx.dtb \
>>>
>>>  	imx6ulz-14x14-evk.dtb \
>>>  	imx6ulz-bsh-smm-m2.dtb
>>>  
>>>  dtb-$(CONFIG_SOC_IMX7D) += \
>>>
>>> diff --git a/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts
>>> b/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts new file mode 100644
>>> index 000000000000..33437aae9822
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts
>>> @@ -0,0 +1,15 @@
>>> +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
>>> +/*
>>> + * Copyright 2018-2022 TQ-Systems GmbH
>>> + * Author: Markus Niebel <Markus.Niebel@tq-group.com>
>>> + */
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include "imx6ull-tqma6ull2l.dtsi"
>>> +#include "mba6ulx.dtsi"
>>> +
>>> +/ {
>>> +	model = "TQ Systems TQMa6ULL2L SoM on MBa6ULx board";
>>> +	compatible = "tq,imx6ull-tqma6ull2l-mba6ulx", "tq,imx6ull-
> tqma6ull2l",
>>> "fsl,imx6ull"; +};
>>> diff --git a/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi
>>> b/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi new file mode 100644
>>> index 000000000000..8e4d5cd18614
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi
>>> @@ -0,0 +1,76 @@
>>> +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
>>> +/*
>>> + * Copyright 2018-2022 TQ-Systems GmbH
>>> + * Author: Markus Niebel <Markus.Niebel@tq-group.com>
>>> + */
>>> +
>>> +#include "imx6ull.dtsi"
>>> +#include "imx6ul-tqma6ul-common.dtsi"
>>> +#include "imx6ul-tqma6ulxl-common.dtsi"
>>> +
>>> +/ {
>>> +	model = "TQ Systems TQMa6ULL2L SoM";
>>> +	compatible = "tq,imx6ull-tqma6ull2l", "fsl,imx6ull";
>>> +};
>>> +
>>
>> This entire file is exactly the same as tqma6ull2l.dtsi. What's the
>> point of creating additional flavor which is exactly the same? The
>> models look compatible, don't they?
> 
> Thanks for your fast feedback. You mean imx6ull-tqma6ull2.dtsi (wthout 
> trailing 'l')? In this case it's not exactly the same, because the LGA version 
> includes 'imx6ul-tqma6ulxl-common.dtsi' while the non-LGA one includes 
> 'imx6ul-tqma6ulx-common.dtsi'.
> 

Yes, you're right. I missed that include part. Thanks!


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 3a6eccb6371a..9bf89273ae71 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -710,6 +710,7 @@  dtb-$(CONFIG_SOC_IMX6UL) += \
 	imx6ull-phytec-segin-ff-rdk-emmc.dtb \
 	imx6ull-phytec-segin-lc-rdk-nand.dtb \
 	imx6ull-tqma6ull2-mba6ulx.dtb \
+	imx6ull-tqma6ull2l-mba6ulx.dtb \
 	imx6ulz-14x14-evk.dtb \
 	imx6ulz-bsh-smm-m2.dtb
 dtb-$(CONFIG_SOC_IMX7D) += \
diff --git a/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts b/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts
new file mode 100644
index 000000000000..33437aae9822
--- /dev/null
+++ b/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts
@@ -0,0 +1,15 @@ 
+// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
+/*
+ * Copyright 2018-2022 TQ-Systems GmbH
+ * Author: Markus Niebel <Markus.Niebel@tq-group.com>
+ */
+
+/dts-v1/;
+
+#include "imx6ull-tqma6ull2l.dtsi"
+#include "mba6ulx.dtsi"
+
+/ {
+	model = "TQ Systems TQMa6ULL2L SoM on MBa6ULx board";
+	compatible = "tq,imx6ull-tqma6ull2l-mba6ulx", "tq,imx6ull-tqma6ull2l", "fsl,imx6ull";
+};
diff --git a/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi b/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi
new file mode 100644
index 000000000000..8e4d5cd18614
--- /dev/null
+++ b/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi
@@ -0,0 +1,76 @@ 
+// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
+/*
+ * Copyright 2018-2022 TQ-Systems GmbH
+ * Author: Markus Niebel <Markus.Niebel@tq-group.com>
+ */
+
+#include "imx6ull.dtsi"
+#include "imx6ul-tqma6ul-common.dtsi"
+#include "imx6ul-tqma6ulxl-common.dtsi"
+
+/ {
+	model = "TQ Systems TQMa6ULL2L SoM";
+	compatible = "tq,imx6ull-tqma6ull2l", "fsl,imx6ull";
+};
+
+&usdhc2 {
+	fsl,tuning-step= <6>;
+	/* Errata ERR010450 Workaround */
+	max-frequency = <99000000>;
+	assigned-clocks = <&clks IMX6UL_CLK_USDHC2_SEL>, <&clks IMX6UL_CLK_USDHC2>;
+	assigned-clock-parents = <&clks IMX6UL_CLK_PLL2_PFD2>;
+	assigned-clock-rates = <0>, <198000000>;
+};
+
+&iomuxc {
+	pinctrl_usdhc2: usdhc2grp {
+		fsl,pins = <
+			MX6UL_PAD_NAND_RE_B__USDHC2_CLK		0x00017031
+			MX6UL_PAD_NAND_WE_B__USDHC2_CMD		0x00017039
+			MX6UL_PAD_NAND_DATA00__USDHC2_DATA0	0x00017039
+			MX6UL_PAD_NAND_DATA01__USDHC2_DATA1	0x00017039
+			MX6UL_PAD_NAND_DATA02__USDHC2_DATA2	0x00017039
+			MX6UL_PAD_NAND_DATA03__USDHC2_DATA3	0x00017039
+			MX6UL_PAD_NAND_DATA04__USDHC2_DATA4	0x00017039
+			MX6UL_PAD_NAND_DATA05__USDHC2_DATA5	0x00017039
+			MX6UL_PAD_NAND_DATA06__USDHC2_DATA6	0x00017039
+			MX6UL_PAD_NAND_DATA07__USDHC2_DATA7	0x00017039
+			/* rst */
+			MX6UL_PAD_NAND_ALE__GPIO4_IO10		0x0001b051
+		>;
+	};
+
+	pinctrl_usdhc2_100mhz: usdhc2-100mhzgrp {
+		fsl,pins = <
+			MX6UL_PAD_NAND_RE_B__USDHC2_CLK		0x000170f1
+			MX6UL_PAD_NAND_WE_B__USDHC2_CMD		0x000170f1
+			MX6UL_PAD_NAND_DATA00__USDHC2_DATA0	0x000170f1
+			MX6UL_PAD_NAND_DATA01__USDHC2_DATA1	0x000170f1
+			MX6UL_PAD_NAND_DATA02__USDHC2_DATA2	0x000170f1
+			MX6UL_PAD_NAND_DATA03__USDHC2_DATA3	0x000170f1
+			MX6UL_PAD_NAND_DATA04__USDHC2_DATA4	0x000170f1
+			MX6UL_PAD_NAND_DATA05__USDHC2_DATA5	0x000170f1
+			MX6UL_PAD_NAND_DATA06__USDHC2_DATA6	0x000170f1
+			MX6UL_PAD_NAND_DATA07__USDHC2_DATA7	0x000170f1
+			/* rst */
+			MX6UL_PAD_NAND_ALE__GPIO4_IO10		0x0001b051
+		>;
+	};
+
+	pinctrl_usdhc2_200mhz: usdhc2-200mhzgrp {
+		fsl,pins = <
+			MX6UL_PAD_NAND_RE_B__USDHC2_CLK		0x000170f1
+			MX6UL_PAD_NAND_WE_B__USDHC2_CMD		0x000170f1
+			MX6UL_PAD_NAND_DATA00__USDHC2_DATA0	0x000170f1
+			MX6UL_PAD_NAND_DATA01__USDHC2_DATA1	0x000170f1
+			MX6UL_PAD_NAND_DATA02__USDHC2_DATA2	0x000170f1
+			MX6UL_PAD_NAND_DATA03__USDHC2_DATA3	0x000170f1
+			MX6UL_PAD_NAND_DATA04__USDHC2_DATA4	0x000170f1
+			MX6UL_PAD_NAND_DATA05__USDHC2_DATA5	0x000170f1
+			MX6UL_PAD_NAND_DATA06__USDHC2_DATA6	0x000170f1
+			MX6UL_PAD_NAND_DATA07__USDHC2_DATA7	0x000170f1
+			/* rst */
+			MX6UL_PAD_NAND_ALE__GPIO4_IO10		0x0001b051
+		>;
+	};
+};