| Message ID | 20220213225646.67761-4-pbrobinson@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Raspberry PI 4 V3D enablement | expand |
Hi, Am 13.02.22 um 23:56 schrieb Peter Robinson: > From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > > Add a new compatible string for BCM2711 and the option to provide a > third reg property for the board's new RPiVid ASB. > > In BCM2711 the new RPiVid ASB took over V3D, which is our only consumer > of this driver so far. The old ASB is still be present with ISP and H264 > bits but no V3D. > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > --- > Changes since v2: > - Correct names s/argon/rpivid/ > > .../devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml > index 837963e9f219..0dd264f80fb3 100644 > --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml > +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml > @@ -19,19 +19,22 @@ allOf: > properties: > compatible: > items: > - - const: brcm,bcm2835-pm > + - enum: > + - brcm,bcm2835-pm > + - brcm,bcm2711-pm > - const: brcm,bcm2835-pm-wdt > > reg: > minItems: 1 > - maxItems: 2 > + maxItems: 3 > > reg-names: > minItems: 1 > - maxItems: 2 > + maxItems: 3 > items: > - const: pm > - const: asb > + - const: rpivid_asb > > "#power-domain-cells": > const: 1 > @@ -74,7 +77,7 @@ examples: > #reset-cells = <1>; > reg = <0x7e100000 0x114>, > <0x7e00a000 0x24>; > - reg-names = "pm", "asb"; > + reg-names = "pm", "asb", "rpivid_asb"; since the example is about the bcm2835, there is no rpivid_asb on this SoC. So this change should be dropped. Best regards > clocks = <&clocks BCM2835_CLOCK_V3D>, > <&clocks BCM2835_CLOCK_PERI_IMAGE>, > <&clocks BCM2835_CLOCK_H264>,
diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml index 837963e9f219..0dd264f80fb3 100644 --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml @@ -19,19 +19,22 @@ allOf: properties: compatible: items: - - const: brcm,bcm2835-pm + - enum: + - brcm,bcm2835-pm + - brcm,bcm2711-pm - const: brcm,bcm2835-pm-wdt reg: minItems: 1 - maxItems: 2 + maxItems: 3 reg-names: minItems: 1 - maxItems: 2 + maxItems: 3 items: - const: pm - const: asb + - const: rpivid_asb "#power-domain-cells": const: 1 @@ -74,7 +77,7 @@ examples: #reset-cells = <1>; reg = <0x7e100000 0x114>, <0x7e00a000 0x24>; - reg-names = "pm", "asb"; + reg-names = "pm", "asb", "rpivid_asb"; clocks = <&clocks BCM2835_CLOCK_V3D>, <&clocks BCM2835_CLOCK_PERI_IMAGE>, <&clocks BCM2835_CLOCK_H264>,