From patchwork Thu Feb 24 09:42:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 12758240 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 048E6C433EF for ; Thu, 24 Feb 2022 09:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=uglApPVq2ZfxP/kbo95wc6zwIiq3YBBNQ6MwFS6v6hs=; b=zAcCdmRy/pIk7b 0tYcXZG//dRDk+9jxw9tOxCyJ2BUhyT7/LtSzanh2soZj1nDAjWWuFpg+Wqh+lgBhxwD+O4NX5tqA nO96qFfWsiyclu4ViZ3Jk67yZxrtYrr7/9hCYcKkY48LZkDGluA2KTPlUe/b5I85rzzqOvSni7ArZ +xDpiXy8sogXS1mO0dUCS5ckhPb4HiyB3xVQOD2NK7Beu7JZySqPpsu96cvSgKG4epJuK+pb1HSIB S9N/6vBxLU1ry0FDKCCBaz9QX+XCQ9H00cIIrdkCOIAQt/TWL8ABJ2AFNfSumPNRrhXd6pA/XNArr 2hSHnSIzco56L0P+3qmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNAeN-000A1e-Jt; Thu, 24 Feb 2022 09:43:04 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNAeI-0009zI-JF for linux-arm-kernel@lists.infradead.org; Thu, 24 Feb 2022 09:43:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1645695778; x=1677231778; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=KXxfnsxQFIgyXErpGtiY7KH71rfyFFJ7BOtUpwzHCJc=; b=ENZB/LDmS3LsaWEMYCAYSJyKMzyQ1KhP9hMo3hXgtt2pGWP/PqoSPOvs ll1CfPrxbWqDsQicfhhV4L1l023Yagp2EmB+mKQnDR7TlMxoxhj84bDDf mWB6afgaqfys573b7QEK4jM5P9HwuPWWGuBVg7q4hoMk469lBYUgGBsEw OIOWB3A0cT5/crcAnNDknXJ83A+I0s0DCeagPNn7s8LboV2Qi2AVc4+8E jzxPGX3BCiM3CUBVlXiFCMfdOtGdW6hR7JfnNlOUNTB54xqNrjKOFksuz e5CqZZKSVkMQ+Gs7PRxsr98e0htlD3ykeSQZF/D4ghC8lPD1MJLcPmfqT A==; X-IronPort-AV: E=Sophos;i="5.88,393,1635199200"; d="scan'208";a="22288062" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 24 Feb 2022 10:42:52 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Thu, 24 Feb 2022 10:42:52 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Thu, 24 Feb 2022 10:42:52 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1645695772; x=1677231772; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=KXxfnsxQFIgyXErpGtiY7KH71rfyFFJ7BOtUpwzHCJc=; b=Xz9yzHbuKaMF5QbnyAYf+XSIARRKXgrkeIKcnm6YxEn7M4A5yXm65kkP SrBXVr2z6ui5i8gOgdo4sZF2QEDkfYfR8mGJ3Q8mWGirA7+WWWhpWwiDA szJ+S/BC6maIY/lGXnttsKGcG3SThlTd1KVFymWiUaUv5aL3xNnrOZdzB E/dKIVPKa+NxnfTmkydL3tO6XA0uSgmfuWZl9WvwCtnjhqoh9GEZKNkIc 2ghBuvumAJsy0gv58Y1utVceedRYjFsRAq/UIo/R8ddJVfvnz2H1bEDNs 7Ccsogimikb0sIxXMMcUGmfv6RIKwLiny21i3n6KIAuak0JjGPxFJ4d2/ A==; X-IronPort-AV: E=Sophos;i="5.88,393,1635199200"; d="scan'208";a="22288061" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 24 Feb 2022 10:42:52 +0100 Received: from steina-w.tq-net.de (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 893E3280074; Thu, 24 Feb 2022 10:42:51 +0100 (CET) From: Alexander Stein To: Dong Aisheng , Fabio Estevam , Shawn Guo , Stefan Agner , Pengutronix Kernel Team , Linus Walleij , Sascha Hauer , NXP Linux Team Cc: Alexander Stein , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 1/1] pinctrl: imx: Reduce printk message level for empty nodes Date: Thu, 24 Feb 2022 10:42:43 +0100 Message-Id: <20220224094243.1376965-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220224_014259_037969_7285DA48 X-CRM114-Status: GOOD ( 15.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org iomuxc_snvs from imx6ull supports 2 boot mode and 10 tamper pins. Probably most users won't use them, causing this error message during boot: no groups defined in /soc/bus@2200000/iomuxc-snvs@2290000 This is actually not an error in this case, so reduce the level accordingly. Signed-off-by: Alexander Stein --- This issue was raised during release test: Why is there an error if nothing is wrong? Memory only devices are enabled by default, which I agree, but this causes the mentioned error message unconditionally, unless some muxing is configured. I would argue that even a warning is not correct either, nothing is wrong here. drivers/pinctrl/freescale/pinctrl-imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c index fa3cc0b80ede..3a7d2de10b13 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx.c +++ b/drivers/pinctrl/freescale/pinctrl-imx.c @@ -661,7 +661,7 @@ static int imx_pinctrl_parse_functions(struct device_node *np, func->name = np->name; func->num_group_names = of_get_child_count(np); if (func->num_group_names == 0) { - dev_err(ipctl->dev, "no groups defined in %pOF\n", np); + dev_info(ipctl->dev, "no groups defined in %pOF\n", np); return -EINVAL; }