From patchwork Mon Mar 7 11:51:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12771620 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A258C433EF for ; Mon, 7 Mar 2022 11:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=FzF4TxdiXkIbdhx0VtwPhYyd3KuGrsVMGN6/NM4KpFw=; b=UDbAopXtvI17SQ RuvlbSEtctBetr5QKe4kRz8vHFqawC0Q+IyFl898BZnrOj7vxNNWwbqKsMTVLNtweGhL3p4xYj5ZD wtfSihFmyw93cDuRA370Zf8LfUA0lzR2bfb2Wn/KgG/vsH382cXfVPZLqF4GPWBSueNKllcyGrYd1 H8O5SRjzGDrlEz49ImH/4WitMz+7erFVnZZ6LNCAfv0tSo1gAsBsKAPdk8PgQVeZdBXxf0c6ACsZu 2mI8JBSG213GwlJrlYg9wMnHL13r2UtDkEsd83nu/GF8TcQXRT6qadr4kTyDwwpaZB3m87ptzHJUn 8qD+76qryOS6fds9ogFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRBtd-00HNmn-LA; Mon, 07 Mar 2022 11:51:25 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRBta-00HNm4-Qu for linux-arm-kernel@lists.infradead.org; Mon, 07 Mar 2022 11:51:24 +0000 Received: by mail-pg1-x52e.google.com with SMTP id e6so13353663pgn.2 for ; Mon, 07 Mar 2022 03:51:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=HTqHyHAKvxige/PSxTTIrGSB+7k0M0gtMTz44wQdR54=; b=NqJ7pwyhDUmrQwkEUqbtipOImjyNUT7+ucPtZrpPu1M0I0lkMEpwenZbTOy8vYpXqC 71oS1bKImehoMFHzJ+EHM9K4djN/eC3TicDalJZs3z0glqHnqH6Gdq0wjxvmlWetu7OD jwkiSk8pJR/21ETeqYIU8cxNEJeLYNhjKa3vVkrHkiL1dxE47TRmDgol/F8v3eUzbIVn vpxxeMoDWhb9MZrM+WVi8OdPSw7RzQa2lh3RO6/qIsu6SDPVfYYMprZ31EICTCrYweJO dfseJuUtM2mdLayX6hc7t6bTM5FsoFIN/MFknf4ThH26hOygZ+iqv4ta6A9T3Y9ParZ9 2dpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HTqHyHAKvxige/PSxTTIrGSB+7k0M0gtMTz44wQdR54=; b=WkYrgnPbn3+l4Ez9nWkWBl0NjJjwlLlaOB8qk6GypqhfSGvrDIB29Us/ogeKcqhE2f i6TyrQ+Cz9DDxKdktQjQU8ABitvo1c5yzmfBbPv6iHaC4Qzk8l5hc3knoMKlMTrTp64S 5zoejSnFdcxTDk+v4VohULP9qMNgYO9gHL9cy4YWyn1LpSxztDsmCmybWV5+/Qm0PHWD wA/XYh/73TYUP2skfl1FloPAQN1cNtLHoQ7TMakNaWqTPHL/BhtsQGNrmCpJ50qSgeEg Yh+RbCnAHfqFqehLKzeEsWs9Nw9DqkmXrH4dqxBn8oVWKSlDwgufMIyr9DL9fYfTTYVd RY6g== X-Gm-Message-State: AOAM532ZjduKV85wkHIVR9TwDIXNDTfMajavJVrkOisISyzUte9X3Jj4 3J6iNYi7uUxe/gdBMAr9Pgw= X-Google-Smtp-Source: ABdhPJyfH/yvR4m8poFpDnukyyRhn+9Hdq6N2qrjHsU03URTFwo5csdyqVUyGV6NfW4eL3cfoAR5bQ== X-Received: by 2002:aa7:9183:0:b0:4f6:d609:af66 with SMTP id x3-20020aa79183000000b004f6d609af66mr11231469pfa.23.1646653881989; Mon, 07 Mar 2022 03:51:21 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id g9-20020a056a0023c900b004e10365c47dsm15348809pfc.192.2022.03.07.03.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 03:51:21 -0800 (PST) From: Miaoqian Lin To: Linus Walleij , Lee Jones , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] pinctrl: nomadik: Add missing of_node_put() in nmk_pinctrl_probe Date: Mon, 7 Mar 2022 11:51:16 +0000 Message-Id: <20220307115116.25316-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220307_035122_926986_6B30AB02 X-CRM114-Status: GOOD ( 14.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This node pointer is returned by of_parse_phandle() with refcount incremented in this function. Calling of_node_put() to avoid the refcount leak. Fixes: 32e67eee670e ("pinctrl: nomadik: Allow prcm_base to be extracted from Device Tree") Signed-off-by: Miaoqian Lin --- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c index 39828e9c3120..4757bf964d3c 100644 --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c @@ -1883,8 +1883,10 @@ static int nmk_pinctrl_probe(struct platform_device *pdev) } prcm_np = of_parse_phandle(np, "prcm", 0); - if (prcm_np) + if (prcm_np) { npct->prcm_base = of_iomap(prcm_np, 0); + of_node_put(prcm_np); + } if (!npct->prcm_base) { if (version == PINCTRL_NMK_STN8815) { dev_info(&pdev->dev,