From patchwork Mon Mar 7 12:45:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12771790 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A47CCC433FE for ; Mon, 7 Mar 2022 12:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=vLX00KnLgCDRN1cf9Qg12nzMD7rZnlOa8PssRtg2KTI=; b=WtM7TBYL9qAIPj ZaAGTznnMGy8KB52jtP95Q9PKVukRjbRrWTCi8nuw7XaDVJn0HUHcoWcLJaknIhfD+rS4X0wBXY/X QPRzg6n7Va0YCVlhdUwiqpVGO9+QGdRA23M0EvwbXrjmLptS/KWx1p4Qx+R5OOUL/0YelzyKi2+Mp UCZVPWtg0usFnVj1Bfo//AERFiMhN9Ali+uTURbdZoDZg8faskUxG8ypQl8Hq45M9+jWYO3tt6RCu X/yMXzgePH7f/gl8F38HMyO09yJB1sIPbaMkC7vUy9IFjZDda00016Eh7fAD7bRMJ6s3n8mrRr3es W/dn0uloDsavPvCMw0Tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRCnS-0007QO-QI; Mon, 07 Mar 2022 12:49:07 +0000 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRCkF-0005zH-GK for linux-arm-kernel@lists.infradead.org; Mon, 07 Mar 2022 12:45:49 +0000 Received: by mail-pg1-x533.google.com with SMTP id e6so13466391pgn.2 for ; Mon, 07 Mar 2022 04:45:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=TlcCWdEmJAkGERXKgqWQ74vqcWFDfJqoMfNr678xADM=; b=cD+B9+HipufW4e6RKtDe7ZfrvlpAfbZv+pAr7A9bMzN8MCLzhK7ZEQl7a0NeLPOu5v sCYD99HPTLEJpnZvMMnl/YnDK92oPTXa3+fZAEFP7lM4c6+YsAziiePstIKroJ+qu89m DdgbkK8wwUvZ9LpQIUO7X/s/GR39hJk6yVIr8Nf5merry6RZD31q9qYYNScncF3ysBi6 3Ul0cWJD4QaxtEm9pe3lTDSR48dVW44mwUq/o/J5sqKj26lHcJlsoMcfkwyT5PckRn4J 0MPeF+2EBAOzCAc4jL6QLGXMc/3lbEUp9XFs3nh2it1tBskNG1pkP9hOPojgDOYxpE7A xXNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=TlcCWdEmJAkGERXKgqWQ74vqcWFDfJqoMfNr678xADM=; b=UkNf9fS+dFsTVRQGs7jN0EW/C6UladF2GTaLngaEBcw+UvdAxcwqtsQgeaMNrt5TBR wgjkYEqPnBvGtP/ogixjxUj/I1iUmLplIYSHbZ+xyp+hY6ruY6A1BQVxO+ai5+uW4WsV dbUxGWTCm+ntcUmDQwEPh76ldDsRC3Bz1MsyeLEBr+IHij7YtFkybMOdeSHWKMkg3Vgc rTBpf7ZW/8QaxqjnieW1suXzTMIuUnsoXvMCO/dTUJE7tKV76+vkp17oOLjcecP3qpM8 AtiXd8SZVnQFcr91AbYTtLIpk58jAH1jZGsUui1d68cFiLZMOi/ofVrWX/uRqyKENAlp iDHw== X-Gm-Message-State: AOAM532hCF1Vk08jDzk54Ux44ngx9kGo3L8qpzkIXrhXOAUwv8JwalV4 HEndldnVWTiqpDzIsnEfWYc= X-Google-Smtp-Source: ABdhPJzy1JniVTE0Xq7VuNwfKPIfVaxET2IZ7oF7c7FCET0xpvuAlZk491+K1c89c1SqMJ25A6Nnkg== X-Received: by 2002:a63:7:0:b0:37f:fa5b:95f9 with SMTP id 7-20020a630007000000b0037ffa5b95f9mr8901563pga.57.1646657145757; Mon, 07 Mar 2022 04:45:45 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id b5-20020a056a0002c500b004f6dbd217c9sm8246431pft.108.2022.03.07.04.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 04:45:45 -0800 (PST) From: Miaoqian Lin To: Codrin Ciubotariu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bo Shen , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] ASoC: atmel: Add missing of_node_put() in at91sam9g20ek_audio_probe Date: Mon, 7 Mar 2022 12:45:39 +0000 Message-Id: <20220307124539.1743-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220307_044547_598551_CFCBA459 X-CRM114-Status: GOOD ( 11.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This node pointer is returned by of_parse_phandle() with refcount incremented in this function. Calling of_node_put() to avoid the refcount leak. Fixes: 531f67e41dcd ("ASoC: at91sam9g20ek-wm8731: convert to dt support") Signed-off-by: Miaoqian Lin Reviewed-by: Codrin Ciubotariu --- sound/soc/atmel/sam9g20_wm8731.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c index 915da92e1ec8..33e43013ff77 100644 --- a/sound/soc/atmel/sam9g20_wm8731.c +++ b/sound/soc/atmel/sam9g20_wm8731.c @@ -214,6 +214,7 @@ static int at91sam9g20ek_audio_probe(struct platform_device *pdev) cpu_np = of_parse_phandle(np, "atmel,ssc-controller", 0); if (!cpu_np) { dev_err(&pdev->dev, "dai and pcm info missing\n"); + of_node_put(codec_np); return -EINVAL; } at91sam9g20ek_dai.cpus->of_node = cpu_np;