| Message ID | 20220307205357.66322-3-singh.kuldeep87k@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Arm based platforms dtc fixes for pl022 | expand |
On 07/03/2022 21:53, Kuldeep Singh wrote: > SPI clock name for pl022 is "sspclk" and not "spiclk". > Fix below dtc warning: > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] > > Also, update node name to spi instead of ssp to enable spi bindings > check. > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > --- > arch/arm/boot/dts/integratorap-im-pd1.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/integratorap-im-pd1.dts b/arch/arm/boot/dts/integratorap-im-pd1.dts > index d47bfb66d069..ebe938556645 100644 > --- a/arch/arm/boot/dts/integratorap-im-pd1.dts > +++ b/arch/arm/boot/dts/integratorap-im-pd1.dts > @@ -178,12 +178,12 @@ uart@200000 { > clock-names = "uartclk", "apb_pclk"; > }; > > - ssp@300000 { > + ssp0: spi@300000 { Is the alias used anywhere? Why adding it? Best regards, Krzysztof
On Mon, Mar 07, 2022 at 10:57:40PM +0100, Krzysztof Kozlowski wrote: > On 07/03/2022 21:53, Kuldeep Singh wrote: > > SPI clock name for pl022 is "sspclk" and not "spiclk". > > Fix below dtc warning: > > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] > > > > Also, update node name to spi instead of ssp to enable spi bindings > > check. > > > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > > --- > > arch/arm/boot/dts/integratorap-im-pd1.dts | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/integratorap-im-pd1.dts b/arch/arm/boot/dts/integratorap-im-pd1.dts > > index d47bfb66d069..ebe938556645 100644 > > --- a/arch/arm/boot/dts/integratorap-im-pd1.dts > > +++ b/arch/arm/boot/dts/integratorap-im-pd1.dts > > @@ -178,12 +178,12 @@ uart@200000 { > > clock-names = "uartclk", "apb_pclk"; > > }; > > > > - ssp@300000 { > > + ssp0: spi@300000 { > > Is the alias used anywhere? Why adding it? I added an alias so as not to lose originality. At other places, ssp is used more specifically for spi controller node and since here I need to enable bindings check, so I mentioned both. There are other platforms too which are using the same notation and personally, I couldn't find any harm in this. Regards Kuldeep
diff --git a/arch/arm/boot/dts/integratorap-im-pd1.dts b/arch/arm/boot/dts/integratorap-im-pd1.dts index d47bfb66d069..ebe938556645 100644 --- a/arch/arm/boot/dts/integratorap-im-pd1.dts +++ b/arch/arm/boot/dts/integratorap-im-pd1.dts @@ -178,12 +178,12 @@ uart@200000 { clock-names = "uartclk", "apb_pclk"; }; - ssp@300000 { + ssp0: spi@300000 { compatible = "arm,pl022", "arm,primecell"; reg = <0x00300000 0x1000>; interrupts-extended = <&impd1_vic 3>; clocks = <&impd1_sspclk>, <&sysclk>; - clock-names = "spiclk", "apb_pclk"; + clock-names = "sspclk", "apb_pclk"; }; impd1_gpio0: gpio@400000 {
SPI clock name for pl022 is "sspclk" and not "spiclk". Fix below dtc warning: clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] Also, update node name to spi instead of ssp to enable spi bindings check. Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> --- arch/arm/boot/dts/integratorap-im-pd1.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)