From patchwork Tue Mar 8 20:49:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Leach X-Patchwork-Id: 12774369 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7D66C433F5 for ; Tue, 8 Mar 2022 20:51:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pl8+eoGzoqp9Y/y5CdWAQgdCYrTvyzU38XMfEl2X7Zg=; b=R0eu04MPDLkPK6 31SKCpfwdJ/2m13YRDbFHyu935UqwshhE7kLNDEonrelDafwOPltBZ0CmjfUYEXG0U0THotKcMl6J eb+emqyX1VO7i8W6TxVZVb0QIfZBkT1Z5Sz4uRY6UdVixgFKOz/E+OnqvXuPteom2tTV9MC4bIks9 VMeDtY+CneCSp2GcvfzEGlAbPLJbbw+PyXsBDJYLYnHJuKCJzTY/uR8SqB5TCbIF32LeiEthMv6iZ Hcty4ioYDvaMxhRfnu+8ikzL2UCuET8izXWHkhhdpKfPhh7y8RqLXAc4UUwSx3/Ku0HJDCZL+Y0sZ k/shMBjOx4Gb5mR1bupw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRgmx-006C02-NI; Tue, 08 Mar 2022 20:50:35 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRgmW-006BnS-FC for linux-arm-kernel@lists.infradead.org; Tue, 08 Mar 2022 20:50:10 +0000 Received: by mail-wr1-x436.google.com with SMTP id i8so30405797wrr.8 for ; Tue, 08 Mar 2022 12:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LSx46Zr8CS5+IFp2YS6e6Ha2KieIvZZnjZpzZmpCaRc=; b=DKd1skywiEYI0uWSl4whWGPs1qJaVU0tgUMdx/rl+nePouWjVVzDg3uy8EiRce3+f+ 7yzBz83zfqUX6YHUi9tOyPa1k9jxBXjn5qdhTxnUXLKPzIDHMreRdzemfgV4vxrO7AXC y6yJRLCAS4dkGGN0MBvuyJZXoMGhsEBzX19izVvjuQdxxvyStOxHAXS1pcJgcZj9x/Ag 1nQDCprNuNnyFdvqveKnxpokO3qHKZhFv/vJq/zGp01AdAE4mS0pVHdK182R0sFKGOYC H3wQfvVWvIzSd1mM7styL1ujDtLC1sKnkNDRxZr8kV/ZlCayP/OAQFhEWytjhLfj7vR2 as2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LSx46Zr8CS5+IFp2YS6e6Ha2KieIvZZnjZpzZmpCaRc=; b=7z+NdMLQkDmPzOyNViiBuhxCyV/+czH27fJQXJMKPConVPKqgEhT2g1ioDMx7jCKe8 nfRyd57jnUgfC+97txi82j5WZ2f3SW9TaNKEYdG2Ch9qPuEbmWUa8gc4MqB91drN7l2l /uN4o2J3W+OLEc7TLZ60BIrqsACC18skvU/6W8oxKwf2yObe50L3qaFLhTp5pkIP3CER YrWiNrr19dOc7R/VfgKDoArmDafjtIy1ID4H/nFtj47Pdq6Pbvrfn4ry1GFjnqfCZNQA b0vbeziUuXPsGBPBRwgiT/SgGYa2Tj8RV5YCgnMgi88ePZyo/g9fWWGUFDETd/8feeqN cP6g== X-Gm-Message-State: AOAM532BxXpxdZMm+qEWEy+/rlSxJkcVmU7MMvZHWwX3oJ9qEzdUIK5M EJwlU8scATuwmzaAJja3HiHsgA== X-Google-Smtp-Source: ABdhPJyd7vwDkz1rPuDSK+nJGsWP1TastawOkho5vhwKTYa01x9JG6lgrXm0BwOOCtJ+IJesykYW0w== X-Received: by 2002:a5d:4811:0:b0:1f1:d736:4862 with SMTP id l17-20020a5d4811000000b001f1d7364862mr13771648wrq.147.1646772606714; Tue, 08 Mar 2022 12:50:06 -0800 (PST) Received: from linaro.org ([2a00:23c5:6809:2201:546d:7d59:1703:bf96]) by smtp.gmail.com with ESMTPSA id p26-20020a1c741a000000b00389ab9a53c8sm3245758wmc.36.2022.03.08.12.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 12:50:06 -0800 (PST) From: Mike Leach To: suzuki.poulose@arm.com, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: mathieu.poirier@linaro.org, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-perf-users@vger.kernel.org, leo.yan@linaro.org, Mike Leach Subject: [PATCH 02/10] coresight: trace-id: Set up source trace ID map for system Date: Tue, 8 Mar 2022 20:49:52 +0000 Message-Id: <20220308205000.27646-3-mike.leach@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220308205000.27646-1-mike.leach@linaro.org> References: <20220308205000.27646-1-mike.leach@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220308_125008_537178_877D30CD X-CRM114-Status: GOOD ( 21.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Adds in a CoreSight trace ID map for the entire system. This will be used by all source drivers to be allocated their trace IDs. The checks for sources to have unique IDs has been removed - this is now guaranteed by the ID allocation mechanisms, and inappropriate where multiple ID maps are in use in larger systems Signed-off-by: Mike Leach --- drivers/hwtracing/coresight/coresight-core.c | 64 ++++++-------------- drivers/hwtracing/coresight/coresight-priv.h | 1 + 2 files changed, 20 insertions(+), 45 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c index af00dca8d1ac..bbf415c252f9 100644 --- a/drivers/hwtracing/coresight/coresight-core.c +++ b/drivers/hwtracing/coresight/coresight-core.c @@ -22,6 +22,7 @@ #include "coresight-etm-perf.h" #include "coresight-priv.h" #include "coresight-syscfg.h" +#include "coresight-trace-id.h" static DEFINE_MUTEX(coresight_mutex); static DEFINE_PER_CPU(struct coresight_device *, csdev_sink); @@ -50,6 +51,19 @@ static DEFINE_PER_CPU(struct list_head *, tracer_path); */ static struct list_head *stm_path; +/* + * Set up a global trace ID map. + * We may need a per sink ID map in future for larger / multi sink systems. + */ +static struct coresight_trace_id_map trace_id_map; + +/* Allow drivers to reference ID map when getting trace IDs */ +struct coresight_trace_id_map *coresight_get_trace_id_map(void) +{ + return &trace_id_map; +} +EXPORT_SYMBOL_GPL(coresight_get_trace_id_map); + /* * When losing synchronisation a new barrier packet needs to be inserted at the * beginning of the data collected in a buffer. That way the decoder knows that @@ -84,45 +98,6 @@ struct coresight_device *coresight_get_percpu_sink(int cpu) } EXPORT_SYMBOL_GPL(coresight_get_percpu_sink); -static int coresight_id_match(struct device *dev, void *data) -{ - int trace_id, i_trace_id; - struct coresight_device *csdev, *i_csdev; - - csdev = data; - i_csdev = to_coresight_device(dev); - - /* - * No need to care about oneself and components that are not - * sources or not enabled - */ - if (i_csdev == csdev || !i_csdev->enable || - i_csdev->type != CORESIGHT_DEV_TYPE_SOURCE) - return 0; - - /* Get the source ID for both components */ - trace_id = source_ops(csdev)->trace_id(csdev); - i_trace_id = source_ops(i_csdev)->trace_id(i_csdev); - - /* All you need is one */ - if (trace_id == i_trace_id) - return 1; - - return 0; -} - -static int coresight_source_is_unique(struct coresight_device *csdev) -{ - int trace_id = source_ops(csdev)->trace_id(csdev); - - /* this shouldn't happen */ - if (trace_id < 0) - return 0; - - return !bus_for_each_dev(&coresight_bustype, NULL, - csdev, coresight_id_match); -} - static int coresight_find_link_inport(struct coresight_device *csdev, struct coresight_device *parent) { @@ -431,12 +406,6 @@ static int coresight_enable_source(struct coresight_device *csdev, u32 mode) { int ret; - if (!coresight_source_is_unique(csdev)) { - dev_warn(&csdev->dev, "traceID %d not unique\n", - source_ops(csdev)->trace_id(csdev)); - return -EINVAL; - } - if (!csdev->enable) { if (source_ops(csdev)->enable) { ret = coresight_control_assoc_ectdev(csdev, true); @@ -1763,11 +1732,15 @@ static int __init coresight_init(void) if (ret) goto exit_bus_unregister; + /* initialise the trace ID map */ + coresight_trace_id_init_id_map(coresight_get_trace_id_map()); + /* initialise the coresight syscfg API */ ret = cscfg_init(); if (!ret) return 0; + coresight_trace_id_release_id_map(coresight_get_trace_id_map()); etm_perf_exit(); exit_bus_unregister: bus_unregister(&coresight_bustype); @@ -1776,6 +1749,7 @@ static int __init coresight_init(void) static void __exit coresight_exit(void) { + coresight_trace_id_release_id_map(coresight_get_trace_id_map()); cscfg_exit(); etm_perf_exit(); bus_unregister(&coresight_bustype); diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h index ff1dd2092ac5..d3032ac545c1 100644 --- a/drivers/hwtracing/coresight/coresight-priv.h +++ b/drivers/hwtracing/coresight/coresight-priv.h @@ -166,6 +166,7 @@ int coresight_make_links(struct coresight_device *orig, struct coresight_device *target); void coresight_remove_links(struct coresight_device *orig, struct coresight_connection *conn); +struct coresight_trace_id_map *coresight_get_trace_id_map(void); #if IS_ENABLED(CONFIG_CORESIGHT_SOURCE_ETM3X) extern int etm_readl_cp14(u32 off, unsigned int *val);