From patchwork Wed Mar 9 10:24:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12774894 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4494C433EF for ; Wed, 9 Mar 2022 10:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=MeoJXezkbe4vk6YK+OGLFWLK+XptarQ3tYPiDiawe3A=; b=Ni7yyEX6LOr2XK XjifnJXSGhQx+8HperaYF8lw1xvV+oEDrkIW7wmLDzk4TB6KFxsE8/C2CYmwLuwjWn5de1drxWYmH gsUvlJ70LLzcNcl5NHQBdCWGqQO9EWRZhKsVufftMLSvsAunZtdQMeSyjELLu5073O/+VXPo+cWa2 1imQ6h1bDH3oAVgJNzH9QvBJSupzDrvHcnPOOr6YZmBbheQ4d1VQdxyWIjkYx2WcQEc1a5xcFlZxs QcpZT4EZVbsbJrlTTaHjGnLmM9rXL5AmhXX0gRfgu9SstFcF4tadIV8aKuvX1iXg03+H3+bYnWp5x Vcss2yOAUZmQl5E+B1zA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRtUx-0088X4-Ut; Wed, 09 Mar 2022 10:24:52 +0000 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRtUu-0088W6-G1 for linux-arm-kernel@lists.infradead.org; Wed, 09 Mar 2022 10:24:49 +0000 Received: by mail-pg1-x533.google.com with SMTP id bc27so1600799pgb.4 for ; Wed, 09 Mar 2022 02:24:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=Ce2OWqbOvhVGvkh9CKalayGwAHAmYG9YoQa70H7zwHk=; b=nhsB643oL1z7gSz9OhPKaYTp92GH9sg+/1DuFdJZk1fKbP62NAfuUgyhqycQ1FqFo+ 5rmoZlZtyivfZVAfYIzmCykCkAF7VU1tcpTtbcye+FzMNUMSpsDn1HqQQBeUEfkEWQYp phjIaBxXla2Fnmq5PQsLvQJ35lNRalRiFJpTO3Ize16CEx26rLuoCAWTk4XyO7syLutA J3tc9yg10WtAbYAUMBfgpJ+sR6FFaDtRA436mFodx2KdMVDsvM4z+cFoBv+/3JIWLk8M LpVMxj0oNuGCkXxkgBd9K3GEPtyHQUZeXY/NhLKujU7sDdSUUiB/QiXt1QbA8U9hCvIC UjkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Ce2OWqbOvhVGvkh9CKalayGwAHAmYG9YoQa70H7zwHk=; b=w9HLug0bFDg15dbjP/bPfyfhwB2TPa3k0cD00vhjOg0dww48lnUDe6QxLR/bBPEZgc nk8UMdm1oHMZNnzymBm/PNHTZd65qOiOTz7aXgJHv886VnMJW7/BeJJyrRwD2sIGBAGT NX/RoBEWA+66RgUECEgYrO2hGMM0qNh62vT1LIdY3psnvJs7Oi9TwhEPo1+CI0Tz9i04 0Lk/hjHvShvhEY4Fzc4dO91Zje8zkfEJHLXxJQZ4Fj1MWOlm7JZ8V8JVWcpSgmFIwXCo aS306rHKjzyH/MkAjskwTJg3XVoA1x5lMJngVpTOg61wvJyvn7xYXI9bgAR/MzdO8v0C de3A== X-Gm-Message-State: AOAM533Ng3Fv4ixQu9yq8UOwCtgzkA6mgBU2v+eUqtlEJdi3qxd/EnVc U47fjOiDeRXAD/AwQ5YGX10= X-Google-Smtp-Source: ABdhPJwWk0jNGLAAdDoKZXq4XIQ1YkfcmM4HG7VGwMH/fxjxX2ftGdpC0zjfa6zFKyVMKy6b1+9O+g== X-Received: by 2002:a63:3d48:0:b0:374:4b15:76e4 with SMTP id k69-20020a633d48000000b003744b1576e4mr17404308pga.593.1646821487378; Wed, 09 Mar 2022 02:24:47 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id a38-20020a056a001d2600b004f70d5e92basm2369076pfx.34.2022.03.09.02.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 02:24:47 -0800 (PST) From: Miaoqian Lin To: Stefano Stabellini , Russell King , Catalin Marinas , Shannon Zhao , Julien Grall , xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] arm/xen: Fix refcount leak in xen_dt_guest_init Date: Wed, 9 Mar 2022 10:24:41 +0000 Message-Id: <20220309102442.14726-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220309_022448_554517_8A75133F X-CRM114-Status: GOOD ( 11.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The of_find_compatible_node() function returns a node pointer with refcount incremented, We should use of_node_put() on it when done Add the missing of_node_put() to release the refcount. Fixes: 9b08aaa3199a ("ARM: XEN: Move xen_early_init() before efi_init()") Signed-off-by: Miaoqian Lin --- arch/arm/xen/enlighten.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c index ec5b082f3de6..262f45f686b6 100644 --- a/arch/arm/xen/enlighten.c +++ b/arch/arm/xen/enlighten.c @@ -424,6 +424,7 @@ static void __init xen_dt_guest_init(void) if (of_address_to_resource(xen_node, GRANT_TABLE_INDEX, &res)) { pr_err("Xen grant table region is not found\n"); + of_node_put(xen_node); return; } xen_grant_frames = res.start;