| Message ID | 20220312113853.63446-2-singh.kuldeep87k@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | DT fixes for pl022 for arm platforms | expand |
On Sat, Mar 12, 2022 at 12:39 PM Kuldeep Singh <singh.kuldeep87k@gmail.com> wrote: > As per spi pl022 binding, SPI clock name is "sspclk" and not "spiclk". > Fix it. > > Also update ssp node name to enable spi bindings check. > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > --- > v3: > - Reword commit message This and patches 2, 3/4 applied to the versatile DTS branch. Yours, Linus Walleij
On Thu, Mar 24, 2022 at 4:07 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Sat, Mar 12, 2022 at 12:39 PM Kuldeep Singh > <singh.kuldeep87k@gmail.com> wrote: > > > As per spi pl022 binding, SPI clock name is "sspclk" and not "spiclk". > > Fix it. > > > > Also update ssp node name to enable spi bindings check. > > > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > > --- > > v3: > > - Reword commit message > > This and patches 2, 3/4 applied to the versatile DTS branch. What happened to this? Rob
> > This and patches 2, 3/4 applied to the versatile DTS branch. > > What happened to this? Thanks Rob for pointing this out, I lost track for these changes. I just noticed Linus applied ste-dbx change only and skipped others(integrator, realview, versatile). These patches fix clock-name as per pl022 binding which causes no harm. Linus, Any reason to skip others? Regards Kuldeep
On Wed, Aug 10, 2022 at 9:47 PM Rob Herring <robh+dt@kernel.org> wrote: > On Thu, Mar 24, 2022 at 4:07 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > > > On Sat, Mar 12, 2022 at 12:39 PM Kuldeep Singh > > <singh.kuldeep87k@gmail.com> wrote: > > > > > As per spi pl022 binding, SPI clock name is "sspclk" and not "spiclk". > > > Fix it. > > > > > > Also update ssp node name to enable spi bindings check. > > > > > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > > > --- > > > v3: > > > - Reword commit message > > > > This and patches 2, 3/4 applied to the versatile DTS branch. > > What happened to this? I forgot to send them upstream this merge window :/ Simple as that. I'll send them pronto. Yours, Linus Walleij
On Mon, Aug 15, 2022 at 7:30 PM Kuldeep Singh <singh.kuldeep87k@gmail.com> wrote: > > > > This and patches 2, 3/4 applied to the versatile DTS branch. > > > > What happened to this? > > Thanks Rob for pointing this out, I lost track for these changes. > I just noticed Linus applied ste-dbx change only and skipped others(integrator, > realview, versatile). > > These patches fix clock-name as per pl022 binding which causes no harm. > Linus, Any reason to skip others? I just forgot to send them. I'll fix. Yours, Linus Walleij
On Thu, Aug 25, 2022 at 12:15:17AM +0200, Linus Walleij wrote: > On Mon, Aug 15, 2022 at 7:30 PM Kuldeep Singh > <singh.kuldeep87k@gmail.com> wrote: > > > > > > This and patches 2, 3/4 applied to the versatile DTS branch. > > > > > > What happened to this? > > > > Thanks Rob for pointing this out, I lost track for these changes. > > I just noticed Linus applied ste-dbx change only and skipped others(integrator, > > realview, versatile). > > > > These patches fix clock-name as per pl022 binding which causes no harm. > > Linus, Any reason to skip others? > > I just forgot to send them. I'll fix. Ok np. Thanks!
diff --git a/arch/arm/boot/dts/integratorap-im-pd1.dts b/arch/arm/boot/dts/integratorap-im-pd1.dts index d47bfb66d069..4c22e4436271 100644 --- a/arch/arm/boot/dts/integratorap-im-pd1.dts +++ b/arch/arm/boot/dts/integratorap-im-pd1.dts @@ -178,12 +178,12 @@ uart@200000 { clock-names = "uartclk", "apb_pclk"; }; - ssp@300000 { + spi@300000 { compatible = "arm,pl022", "arm,primecell"; reg = <0x00300000 0x1000>; interrupts-extended = <&impd1_vic 3>; clocks = <&impd1_sspclk>, <&sysclk>; - clock-names = "spiclk", "apb_pclk"; + clock-names = "sspclk", "apb_pclk"; }; impd1_gpio0: gpio@400000 {
As per spi pl022 binding, SPI clock name is "sspclk" and not "spiclk". Fix it. Also update ssp node name to enable spi bindings check. Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> --- v3: - Reword commit message v2: -Remove ssp alias arch/arm/boot/dts/integratorap-im-pd1.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)