diff mbox series

clk: imx: Select MXC_CLK for i.MX93 clock driver

Message ID 20220315082446.3120850-1-abel.vesa@nxp.com (mailing list archive)
State New, archived
Headers show
Series clk: imx: Select MXC_CLK for i.MX93 clock driver | expand

Commit Message

Abel Vesa March 15, 2022, 8:24 a.m. UTC
Most of the i.MX clock generic API is built by selecting MXC_CLK.
Without it, the i.MX93 clock driver will fail to build:

aarch64-linux-gnu-ld: drivers/clk/imx/clk-imx93.o:
in function `imx93_clocks_probe': clk-imx93.c:(.text+0xa8):
undefined reference to `imx_obtain_fixed_clk_hw'

So fix this by selecting MXC_CLK for the CLK_IMX93.

Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk")
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
Reported-by: kernel test robot <lkp@intel.com>
---
 drivers/clk/imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Peng Fan March 15, 2022, 8:26 a.m. UTC | #1
> Subject: [PATCH] clk: imx: Select MXC_CLK for i.MX93 clock driver
> 
> Most of the i.MX clock generic API is built by selecting MXC_CLK.
> Without it, the i.MX93 clock driver will fail to build:
> 
> aarch64-linux-gnu-ld: drivers/clk/imx/clk-imx93.o:
> in function `imx93_clocks_probe': clk-imx93.c:(.text+0xa8):
> undefined reference to `imx_obtain_fixed_clk_hw'
> 
> So fix this by selecting MXC_CLK for the CLK_IMX93.
> 
> Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk")
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> Reported-by: kernel test robot <lkp@intel.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  drivers/clk/imx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig index
> cc464a42d646..25785ec9c276 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -109,6 +109,7 @@ config CLK_IMX8ULP
>  config CLK_IMX93
>  	tristate "IMX93 CCM Clock Driver"
>  	depends on ARCH_MXC || COMPILE_TEST
> +	select MXC_CLK
>  	help
>  	    Build the driver for i.MX93 CCM Clock Driver
> 
> --
> 2.34.1
Abel Vesa March 15, 2022, 9:11 p.m. UTC | #2
On 22-03-15 10:26:43, Peng Fan wrote:
> > Subject: [PATCH] clk: imx: Select MXC_CLK for i.MX93 clock driver
> > 
> > Most of the i.MX clock generic API is built by selecting MXC_CLK.
> > Without it, the i.MX93 clock driver will fail to build:
> > 
> > aarch64-linux-gnu-ld: drivers/clk/imx/clk-imx93.o:
> > in function `imx93_clocks_probe': clk-imx93.c:(.text+0xa8):
> > undefined reference to `imx_obtain_fixed_clk_hw'
> > 
> > So fix this by selecting MXC_CLK for the CLK_IMX93.
> > 
> > Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk")
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> 
> Reviewed-by: Peng Fan <peng.fan@nxp.com>

Thanks, Peng.

Stephen, can you please pick this up?

> 
> > ---
> >  drivers/clk/imx/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig index
> > cc464a42d646..25785ec9c276 100644
> > --- a/drivers/clk/imx/Kconfig
> > +++ b/drivers/clk/imx/Kconfig
> > @@ -109,6 +109,7 @@ config CLK_IMX8ULP
> >  config CLK_IMX93
> >  	tristate "IMX93 CCM Clock Driver"
> >  	depends on ARCH_MXC || COMPILE_TEST
> > +	select MXC_CLK
> >  	help
> >  	    Build the driver for i.MX93 CCM Clock Driver
> > 
> > --
> > 2.34.1
>
Stephen Boyd March 15, 2022, 9:45 p.m. UTC | #3
Quoting Abel Vesa (2022-03-15 01:24:46)
> Most of the i.MX clock generic API is built by selecting MXC_CLK.
> Without it, the i.MX93 clock driver will fail to build:
> 
> aarch64-linux-gnu-ld: drivers/clk/imx/clk-imx93.o:
> in function `imx93_clocks_probe': clk-imx93.c:(.text+0xa8):
> undefined reference to `imx_obtain_fixed_clk_hw'
> 
> So fix this by selecting MXC_CLK for the CLK_IMX93.
> 
> Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk")
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> Reported-by: kernel test robot <lkp@intel.com>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
index cc464a42d646..25785ec9c276 100644
--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig
@@ -109,6 +109,7 @@  config CLK_IMX8ULP
 config CLK_IMX93
 	tristate "IMX93 CCM Clock Driver"
 	depends on ARCH_MXC || COMPILE_TEST
+	select MXC_CLK
 	help
 	    Build the driver for i.MX93 CCM Clock Driver