diff mbox series

[1/2] dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711

Message ID 20220315200929.74952-2-athierry@redhat.com (mailing list archive)
State New, archived
Headers show
Series Add support for bcm2711 in vchiq_arm | expand

Commit Message

Adrien Thierry March 15, 2022, 8:09 p.m. UTC
Add a new compatible string for BCM2711. This is the chip used on the
Raspberry Pi 4.

Signed-off-by: Adrien Thierry <athierry@redhat.com>
---
 .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml     | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Rob Herring (Arm) March 23, 2022, 6:44 p.m. UTC | #1
On Tue, Mar 15, 2022 at 04:09:28PM -0400, Adrien Thierry wrote:
> Add a new compatible string for BCM2711. This is the chip used on the
> Raspberry Pi 4.
> 
> Signed-off-by: Adrien Thierry <athierry@redhat.com>
> ---
>  .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml     | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> index e04439b3355b..599bd283df1b 100644
> --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> @@ -27,6 +27,12 @@ properties:
>                - brcm,bcm2836-vchiq
>            - const: brcm,bcm2835-vchiq
>  
> +      - description: BCM2711 based boards
> +        items:
> +          - enum:
> +              - brcm,bcm2711-vchiq
> +          - const: brcm,bcm2711-vchiq

Why do you have the same compatible twice?

> +
>    reg:
>      description: Physical base address and length of the doorbell register pair
>      minItems: 1
> -- 
> 2.35.1
> 
>
Adrien Thierry March 24, 2022, 5:34 p.m. UTC | #2
Hi,

> Why do you have the same compatible twice?

Sorry, I misunderstood the yaml doc fields. I submitted a v2 that fixes
this.

Thanks,
Adrien
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
index e04439b3355b..599bd283df1b 100644
--- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
+++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
@@ -27,6 +27,12 @@  properties:
               - brcm,bcm2836-vchiq
           - const: brcm,bcm2835-vchiq
 
+      - description: BCM2711 based boards
+        items:
+          - enum:
+              - brcm,bcm2711-vchiq
+          - const: brcm,bcm2711-vchiq
+
   reg:
     description: Physical base address and length of the doorbell register pair
     minItems: 1