From patchwork Fri Mar 18 19:59:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ali Saidi X-Patchwork-Id: 12785872 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B72CFC433F5 for ; Fri, 18 Mar 2022 20:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6gsA2TYE3y7HocsYnyai2Wo0BVo/eY2Bo8+F8aFDlls=; b=E7XmWCG0I4jhAB /TuCd1FoFpzyMjAIwd/iLNuYg495Wguybp/uXxytiBNehfqMNhnD0Ulg5PrgmaOe4mF+/EuxzI2Wi TcrGJMNEPyBKzNjfozlLIYG7KbQsHE/ffnOx7d6D9C2OmgIlYZ1hD3oNdtERhgKiCQyMis2q3aegh jwhyr7NR39SPbJHS9jAYmUHXL8YOa74inX05ZrVgoRaKq90JLcdwZ+rOC4PkLQPTzuF3UE2uDgnLF n7iHhoFp8S4agGfuDsQml+tKA6h+AAI88Y/0ezy99vgYwS9LusIQ2XeIS/r2HEeUpuSehIROC0j9y nzvpB4Ez8tkyjj9XUR9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVIl5-002jaa-Ot; Fri, 18 Mar 2022 19:59:36 +0000 Received: from smtp-fw-80006.amazon.com ([99.78.197.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVIl1-002jY6-74 for linux-arm-kernel@lists.infradead.org; Fri, 18 Mar 2022 19:59:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1647633571; x=1679169571; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Khi4kBeH9SGzO7ZWXykd26lWjrq52nVJrfKWlqa0m44=; b=WK9TzkJTA2rzyYfxhHA5RYd8xaXRppyHYjrGAnkklU1dQW8Mptnlz8MJ CnfmhJJfpdul0HueJl5sr9U1mmAxtaizBX9EGvYu4Q7ZheVMuFmKwBO8c wpPS81g3JH5P6S00kMvW5Mr8r3GGKe4yf0a3FenQILUV2gZAeKy/0uQ9O E=; X-IronPort-AV: E=Sophos;i="5.90,192,1643673600"; d="scan'208";a="72160464" Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO email-inbound-relay-pdx-2a-2dbf0206.us-west-2.amazon.com) ([10.25.36.214]) by smtp-border-fw-80006.pdx80.corp.amazon.com with ESMTP; 18 Mar 2022 19:59:28 +0000 Received: from EX13MTAUWC001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-2a-2dbf0206.us-west-2.amazon.com (Postfix) with ESMTPS id CF876A0DA0; Fri, 18 Mar 2022 19:59:27 +0000 (UTC) Received: from EX13D02UWC001.ant.amazon.com (10.43.162.243) by EX13MTAUWC001.ant.amazon.com (10.43.162.135) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Fri, 18 Mar 2022 19:59:27 +0000 Received: from EX13MTAUEA001.ant.amazon.com (10.43.61.82) by EX13D02UWC001.ant.amazon.com (10.43.162.243) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Fri, 18 Mar 2022 19:59:27 +0000 Received: from dev-dsk-alisaidi-1d-b9a0e636.us-east-1.amazon.com (172.19.181.128) by mail-relay.amazon.com (10.43.61.243) with Microsoft SMTP Server id 15.0.1497.32 via Frontend Transport; Fri, 18 Mar 2022 19:59:26 +0000 Received: by dev-dsk-alisaidi-1d-b9a0e636.us-east-1.amazon.com (Postfix, from userid 5131138) id 87481BBB; Fri, 18 Mar 2022 19:59:25 +0000 (UTC) From: Ali Saidi To: , , , , CC: , , , , , , , , , , , , , , , , Subject: [PATCH v3 3/3] perf mem: Support HITM for when mem_lvl_num is any Date: Fri, 18 Mar 2022 19:59:13 +0000 Message-ID: <20220318195913.17459-4-alisaidi@amazon.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220318195913.17459-1-alisaidi@amazon.com> References: <20220318195913.17459-1-alisaidi@amazon.com> MIME-Version: 1.0 Precedence: Bulk X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220318_125931_343688_F136FB2D X-CRM114-Status: GOOD ( 14.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org For loads that hit in a the LLC snoop filter and are fulfilled from a higher level cache on arm64 Neoverse cores, it's not usually clear what the true level of the cache the data came from (i.e. a transfer from a core could come from it's L1 or L2). Instead of making an assumption of where the line came from, add support for incrementing HITM if the source is CACHE_ANY. Since other architectures don't seem to populate the mem_lvl_num field here there shouldn't be a change in functionality. Signed-off-by: Ali Saidi --- tools/perf/util/mem-events.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c index e5e405185498..084977cfebef 100644 --- a/tools/perf/util/mem-events.c +++ b/tools/perf/util/mem-events.c @@ -539,6 +539,15 @@ do { \ stats->ld_llchit++; } + /* + * A hit in another cores cache must mean a llc snoop + * filter hit + */ + if (lnum == P(LVLNUM, ANY_CACHE)) { + if (snoop & P(SNOOP, HITM)) + HITM_INC(lcl_hitm); + } + if (lvl & P(LVL, LOC_RAM) || lnum == P(LVLNUM, RAM)) { stats->lcl_dram++; if (snoop & P(SNOOP, HIT))