| Message ID | 20220318202547.1650687-8-michael@walle.cc (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pinctrl: ocelot: convert to YAML format | expand |
Hello! On 3/18/22 11:25 PM, Michael Walle wrote: > The pinctrl device tree binding will be converted to YAML format. All > the pin nodes should end with "-pins". Fix them. It does end with "pins" already, right? > Fixes: 290deaa10c50 ("ARM: dts: add DT for lan966 SoC and 2-port board pcb8291") > Signed-off-by: Michael Walle <michael@walle.cc> > --- > arch/arm/boot/dts/lan966x-pcb8291.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts > index 3281af90ac6d..3c7e3a7d6f14 100644 > --- a/arch/arm/boot/dts/lan966x-pcb8291.dts > +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts > @@ -35,7 +35,7 @@ fc3_b_pins: fcb3-spi-pins { > function = "fc3_b"; > }; > > - can0_b_pins: can0_b_pins { > + can0_b_pins: can0-b-pins { Mhm, I can't even see what is changed here... :-/ [...] MBR, Sergey
Hi, Am 2022-03-19 09:24, schrieb Sergei Shtylyov: > Hello! > > On 3/18/22 11:25 PM, Michael Walle wrote: > >> The pinctrl device tree binding will be converted to YAML format. All >> the pin nodes should end with "-pins". Fix them. > > It does end with "pins" already, right? It ends with "_pins". Please note the underscore. >> Fixes: 290deaa10c50 ("ARM: dts: add DT for lan966 SoC and 2-port board >> pcb8291") >> Signed-off-by: Michael Walle <michael@walle.cc> >> --- >> arch/arm/boot/dts/lan966x-pcb8291.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts >> b/arch/arm/boot/dts/lan966x-pcb8291.dts >> index 3281af90ac6d..3c7e3a7d6f14 100644 >> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts >> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts >> @@ -35,7 +35,7 @@ fc3_b_pins: fcb3-spi-pins { >> function = "fc3_b"; >> }; >> >> - can0_b_pins: can0_b_pins { >> + can0_b_pins: can0-b-pins { > > Mhm, I can't even see what is changed here... :-/ The name of the node, s/_/-/ -michael
On 3/19/22 2:38 PM, Michael Walle wrote: [...] >>> The pinctrl device tree binding will be converted to YAML format. All >>> the pin nodes should end with "-pins". Fix them. >> >> It does end with "pins" already, right? > > It ends with "_pins". Please note the underscore. Ah! >>> Fixes: 290deaa10c50 ("ARM: dts: add DT for lan966 SoC and 2-port board pcb8291") >>> Signed-off-by: Michael Walle <michael@walle.cc> >>> --- >>> arch/arm/boot/dts/lan966x-pcb8291.dts | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts >>> index 3281af90ac6d..3c7e3a7d6f14 100644 >>> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts >>> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts >>> @@ -35,7 +35,7 @@ fc3_b_pins: fcb3-spi-pins { >>> function = "fc3_b"; >>> }; >>> >>> - can0_b_pins: can0_b_pins { >>> + can0_b_pins: can0-b-pins { >> >> Mhm, I can't even see what is changed here... :-/ > > The name of the node, s/_/-/ Indeed! I must have been blind then, sorry. :-) > -michael MBR, Sergey
diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts index 3281af90ac6d..3c7e3a7d6f14 100644 --- a/arch/arm/boot/dts/lan966x-pcb8291.dts +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts @@ -35,7 +35,7 @@ fc3_b_pins: fcb3-spi-pins { function = "fc3_b"; }; - can0_b_pins: can0_b_pins { + can0_b_pins: can0-b-pins { /* RX, TX */ pins = "GPIO_35", "GPIO_36"; function = "can0_b";
The pinctrl device tree binding will be converted to YAML format. All the pin nodes should end with "-pins". Fix them. Fixes: 290deaa10c50 ("ARM: dts: add DT for lan966 SoC and 2-port board pcb8291") Signed-off-by: Michael Walle <michael@walle.cc> --- arch/arm/boot/dts/lan966x-pcb8291.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)