From patchwork Fri Apr 1 14:11:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 12798346 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38552C433EF for ; Fri, 1 Apr 2022 14:14:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d9V8Pay8nRW08rJ6aL+cpzvu1PZ5uVOXK1YYOz+HHts=; b=lK1pOlhOar3+oJ HM2E78o/xxwfNFRW5qS1SeQ4ATyknmR3h/7A9IeEASSgJ6320QhrOD4fEqSYhAfvnzOkRF21iXNGf PEZ/keKp+yqGs5VmabyfoaI4fT9hZrxV+OwpEt4GVP5BW9z+A2kUbuDVGhyWVZQJ5Qlnq1GB7gdIu oQVmyg1RHzD+g1d3bZ0K5XYHM5fR2aCNtC+W678FnhkRsPAMvFdOMW6wTmrJEa/IWA/ixWs15ii0i RJxDxiOE9CRNZb7VbuubI4cQ13FwPEBH6IDCQ6/axFDKlcsAXj6ANilA3jyoklGIV+6INXWrANzbM sw6tC8sfTq1zr2oj5T5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naI1A-005vZB-9f; Fri, 01 Apr 2022 14:12:48 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1naI08-005uzs-7y for linux-arm-kernel@lists.infradead.org; Fri, 01 Apr 2022 14:11:46 +0000 Received: by mail-lf1-x130.google.com with SMTP id e16so5101701lfc.13 for ; Fri, 01 Apr 2022 07:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dc7bcPLHSzDeVD5ow88/lepa6mD08+FL5qt0hCCvM24=; b=Gs++QERUQ6VZTav+T8iX4NX+HP4paalYcpGZTaqYgcvKWD3gcJnCjsvRq74CalCDQD ZOZ3jfl0z6fqX3p2JCZN5YBH7DjJDvfmf7DYHZIAZfaENweW5oy/yBOAjRde0PJm+BiK +BNTFmNl9QnskE96uabMgEt8GQ4rq/UdCp1KFldhsjEBrjipJC3aBK/XcfUJ2+38jd9E vQdNrorAoW97tRvVl4/wKRr9TNlHynMSIUHXgaelkssAMco89uegyP468+KlYXFz2wgQ VK/ZjUasEbG6bqEm1sgTD7iDNsDhiFPjPO674O0E3k7da6H+a/VJhJaweshHL0bkC9Wc s+xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dc7bcPLHSzDeVD5ow88/lepa6mD08+FL5qt0hCCvM24=; b=mZ64t4IglhzBEYmg8lDnAUx8m38c2xvCs6JCU5fvbOIIU0D0RQmd2UqnF28FfFGnRe Il9Dp+n15wWovFaseKbL8hnX0bA0GbDcESpAFldbhvWPK3g53eJrmFlE7fM6VJbk9NSZ CUnc+l8afVuJqztAvL3CQ8CasDdzxIxu5sXtN6SRddTqqAxTvJYwgD4qz6J8amdHXGbm KL7cIQ52MdqgTiYAn9wgdyshK6pIXAitKXTJ3sV1zgZZe6cdHI1E4SSZSbd0H08Vnee4 1/GfmblpmbMk7lc4jP2EpWaGmFGzZklnQmgeRHrr8946m+FWHXUWqVTXHNI68H3G2cEj Qorg== X-Gm-Message-State: AOAM532KHz8xlvx1jT7K9vFt40Z87eKNKjtw9cd5gsaHoTm0yIV/jGOb gji/8935hXE8ESyqh0HGdwMOwg== X-Google-Smtp-Source: ABdhPJxRtRhtqUT7n7uSs6oA1DmMyYSR5uMWLnIib8aSgqAuEV/CUQy3xIotPv+wra+vfJMp5vzoRw== X-Received: by 2002:a05:6512:c01:b0:448:6aec:65c5 with SMTP id z1-20020a0565120c0100b004486aec65c5mr14350038lfu.193.1648822297707; Fri, 01 Apr 2022 07:11:37 -0700 (PDT) Received: from localhost.localdomain (h-98-128-181-154.NA.cust.bahnhof.se. [98.128.181.154]) by smtp.gmail.com with ESMTPSA id 16-20020ac24d50000000b0044a255c8d3bsm251926lfp.116.2022.04.01.07.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 07:11:36 -0700 (PDT) From: Ulf Hansson To: "Rafael J . Wysocki" , Sudeep Holla , Lorenzo Pieralisi , linux-pm@vger.kernel.org Cc: Maulik Shah , Daniel Lezcano , Lukasz Luba , Vincent Guittot , Stephen Boyd , Bjorn Andersson , Alexandre Torgue , Ulf Hansson , linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] PM: runtime: Allow to call __pm_runtime_set_status() from atomic context Date: Fri, 1 Apr 2022 16:11:23 +0200 Message-Id: <20220401141124.27272-2-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220401141124.27272-1-ulf.hansson@linaro.org> References: <20220401141124.27272-1-ulf.hansson@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_071144_317902_B1062CCC X-CRM114-Status: GOOD ( 12.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The only two users of __pm_runtime_set_status() are pm_runtime_set_active() and pm_runtime_set_suspended(). These are widely used and should be called from non-atomic context to work as expected. However, it would be convenient to allow them be called from atomic context too, as shown from a subsequent change, so let's add support for this. Signed-off-by: Ulf Hansson Tested-by: Maulik Shah --- drivers/base/power/runtime.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c index d4059e6ffeae..91d757914686 100644 --- a/drivers/base/power/runtime.c +++ b/drivers/base/power/runtime.c @@ -1210,12 +1210,13 @@ int __pm_runtime_set_status(struct device *dev, unsigned int status) { struct device *parent = dev->parent; bool notify_parent = false; + unsigned long flags; int error = 0; if (status != RPM_ACTIVE && status != RPM_SUSPENDED) return -EINVAL; - spin_lock_irq(&dev->power.lock); + spin_lock_irqsave(&dev->power.lock, flags); /* * Prevent PM-runtime from being enabled for the device or return an @@ -1226,7 +1227,7 @@ int __pm_runtime_set_status(struct device *dev, unsigned int status) else error = -EAGAIN; - spin_unlock_irq(&dev->power.lock); + spin_unlock_irqrestore(&dev->power.lock, flags); if (error) return error; @@ -1247,7 +1248,7 @@ int __pm_runtime_set_status(struct device *dev, unsigned int status) device_links_read_unlock(idx); } - spin_lock_irq(&dev->power.lock); + spin_lock_irqsave(&dev->power.lock, flags); if (dev->power.runtime_status == status || !parent) goto out_set; @@ -1288,7 +1289,7 @@ int __pm_runtime_set_status(struct device *dev, unsigned int status) dev->power.runtime_error = 0; out: - spin_unlock_irq(&dev->power.lock); + spin_unlock_irqrestore(&dev->power.lock, flags); if (notify_parent) pm_request_idle(parent);