From patchwork Mon Apr 4 14:38:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12800309 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 562E0C433F5 for ; Mon, 4 Apr 2022 14:39:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=cQAI1HuWxGE86dCxGAnpdBiZZLSY6JtjjJPdSTEGVSQ=; b=LukwRjbir+w9JM gyRoeTXoiawl6ZUuuSNcn4UAXiAaWFe8Sk1tGlDYzSC8164gjFnzaTgONBruV0eTV/oQYrUj1YkQV werEJ87bbwATAjazH9WY/Us5FA7Lhzb1+qH9fox5ztnB84j8cZRmwK2iJKHdKBtZPXgGDhl+ZGkUE va5PWVJNoZQEzCUdkP+PGV/n4D8RhAK4IrKRRI4G3FmF7VL43bxQi/vFazZt05sOuziNEe0j/VMO9 utAGLsN5bDaWF8rGui1pTLW0IFol4/G60HodvfOuAuUq+U1aTrOtESe0400Cdc7IZZ7uBcepUFGoS C/kklAYszJyakltORgog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbNr4-00FNh0-Gl; Mon, 04 Apr 2022 14:38:54 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbNr0-00FNfv-OQ for linux-arm-kernel@lists.infradead.org; Mon, 04 Apr 2022 14:38:51 +0000 Received: by mail-pj1-x102d.google.com with SMTP id j20-20020a17090ae61400b001ca9553d073so3137492pjy.5 for ; Mon, 04 Apr 2022 07:38:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id; bh=/OOC2V7xZiaknaBKj4i3q7VnOh6KcuMP7wXUOuaSHIk=; b=XbFFVR/b5q9T/ccQwMNV7oS8jmz/8ydhO2wbuZ4dnTMtjIzB6jdnZMtjVA+gVPOlNi Fh3L/YtSRG0H+pWEhoLWfqjheiDJivSt2rc02u/dwUeHsKoBGABxJRp9Jbb48MYAIpim O64PfE/ok5JMyRZ3CQZiEICQ5VUUxCnwUPfrsPhqA1dALFfBxFleTbQd5I0odX5BNO59 lKbzkBuY3TkjHZXaiTT997YZJcB8tyMTKt+oGo6mJ+/QS2cIoRy8bam9Qw/r6vdNGJhI sSITUz76YsxGcaKHQZJ+gQ3pAf+eeVfQMh7bey9qc6JpwoJpJoEYlSE3bBgYBWIehayO Q7kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id; bh=/OOC2V7xZiaknaBKj4i3q7VnOh6KcuMP7wXUOuaSHIk=; b=MAjZHWMEMzgMd9cdbtuV8g0BcAsd9Sh/KJQf2ND+UunCo1cN7Nzr2/rx/ysv9gspy8 /BoaM3OD45DjxxJhvo0Us6RXWe2mcOmiuHPj2nWHwMPtmOREzJbtlUHtSEg1Ejuo/iqJ YobSUHijVOwzmCJ1xtUWgh8N2+wonYXxf/XaSsjnWv/WGC9x75RTjwBDCHlLsF2NqhKv xvbbAW+p5nsuuETO/7XPBZCW93w0JaNdYo9aC9tFza4KGktWd3qbrvsuADhj53z5g1x6 hO2J+1zy6f/hdUhZykZKbpMAVqWfYEGuJn9ulBEWsSGybyVfKRn5LEMsy7XsEcaYqcK8 5X5Q== X-Gm-Message-State: AOAM531DnF8lO5rjTIaC9HsXOuqH6phUfanLs8qyOiLbQFqN/GxZ8flU BLBOKCpVo1BTYDl6aGByuw8= X-Google-Smtp-Source: ABdhPJyhtOBPPj1peqOQfSYtTssZudXWivrHTu/PMrPp1u6em61raME54CbKsHs/3PFKQmSppHnJWA== X-Received: by 2002:a17:90b:4d85:b0:1c7:3933:d810 with SMTP id oj5-20020a17090b4d8500b001c73933d810mr27001609pjb.129.1649083128678; Mon, 04 Apr 2022 07:38:48 -0700 (PDT) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id a11-20020a056a000c8b00b004fade889fb3sm13135860pfv.18.2022.04.04.07.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 07:38:48 -0700 (PDT) From: Miaoqian Lin To: Greg Kroah-Hartman , Jiri Slaby , Joel Stanley , Andrew Jeffery , Zev Weiss , Johan Hovold , Yang Guang , Miaoqian Lin , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] serial: 8250_aspeed_vuart: Fix potential NULL dereference in aspeed_vuart_probe Date: Mon, 4 Apr 2022 14:38:40 +0000 Message-Id: <20220404143842.16960-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220404_073850_845390_6E8E3CE6 X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org platform_get_resource() may fail and return NULL, so we should better check it's return value to avoid a NULL pointer dereference. Fixes: 54da3e381c2b ("serial: 8250_aspeed_vuart: use UPF_IOREMAP to set up register mapping") Signed-off-by: Miaoqian Lin --- drivers/tty/serial/8250/8250_aspeed_vuart.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c b/drivers/tty/serial/8250/8250_aspeed_vuart.c index 93fe10c680fb..9d2a7856784f 100644 --- a/drivers/tty/serial/8250/8250_aspeed_vuart.c +++ b/drivers/tty/serial/8250/8250_aspeed_vuart.c @@ -429,6 +429,8 @@ static int aspeed_vuart_probe(struct platform_device *pdev) timer_setup(&vuart->unthrottle_timer, aspeed_vuart_unthrottle_exp, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -EINVAL; memset(&port, 0, sizeof(port)); port.port.private_data = vuart;