diff mbox series

[v2] arm64: defconfig: Config that had RPMSG_CHAR now gets RPMSG_CTRL

Message ID 20220405115524.1020499-1-arnaud.pouliquen@foss.st.com (mailing list archive)
State New, archived
Headers show
Series [v2] arm64: defconfig: Config that had RPMSG_CHAR now gets RPMSG_CTRL | expand

Commit Message

Arnaud Pouliquen April 5, 2022, 11:55 a.m. UTC
In the commit 617d32938d1b ("rpmsg: Move the rpmsg control device
from rpmsg_char to rpmsg_ctrl"), we split the rpmsg_char driver in two.
By default give everyone who had the old driver enabled the rpmsg_ctrl
driver too.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>

This patch is extracted from the series [1] that has been partially
integrated in the Linux Kernel 5.18-rc1.

Update vs previous version:
- remove "Fixes:" tag in commit, requested by Mathieu Poirier in [2]

[1]https://lore.kernel.org/lkml/15be2f08-ba03-2b80-6f53-2056359d5c41@gmail.com/T/
[2]https://lore.kernel.org/linux-arm-kernel/CANLsYky1_b80qPbgOaLGVYD-GEr21V6C653iGEB7VCU=GbGvAQ@mail.gmail.com/T/
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Mathieu Poirier April 5, 2022, 3:25 p.m. UTC | #1
On Tue, Apr 05, 2022 at 01:55:24PM +0200, Arnaud Pouliquen wrote:
> In the commit 617d32938d1b ("rpmsg: Move the rpmsg control device
> from rpmsg_char to rpmsg_ctrl"), we split the rpmsg_char driver in two.
> By default give everyone who had the old driver enabled the rpmsg_ctrl
> driver too.
> 
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>

This patch is missing a separation marker, i.e "---", just above.  Without it
the text below is also included in the changelog, and it shouldn't.

Thanks,
Mathieu

> 
> This patch is extracted from the series [1] that has been partially
> integrated in the Linux Kernel 5.18-rc1.
> 
> Update vs previous version:
> - remove "Fixes:" tag in commit, requested by Mathieu Poirier in [2]
> 
> [1]https://lore.kernel.org/lkml/15be2f08-ba03-2b80-6f53-2056359d5c41@gmail.com/T/
> [2]https://lore.kernel.org/linux-arm-kernel/CANLsYky1_b80qPbgOaLGVYD-GEr21V6C653iGEB7VCU=GbGvAQ@mail.gmail.com/T/
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 50aa3d75ab4f..3f8906b8a2ca 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1053,6 +1053,7 @@ CONFIG_QCOM_Q6V5_PAS=m
>  CONFIG_QCOM_SYSMON=m
>  CONFIG_QCOM_WCNSS_PIL=m
>  CONFIG_RPMSG_CHAR=m
> +CONFIG_RPMSG_CTRL=m
>  CONFIG_RPMSG_QCOM_GLINK_RPM=y
>  CONFIG_RPMSG_QCOM_GLINK_SMEM=m
>  CONFIG_RPMSG_QCOM_SMD=y
> -- 
> 2.25.1
>
Arnaud Pouliquen April 5, 2022, 4:04 p.m. UTC | #2
On 4/5/22 17:25, Mathieu Poirier wrote:
> On Tue, Apr 05, 2022 at 01:55:24PM +0200, Arnaud Pouliquen wrote:
>> In the commit 617d32938d1b ("rpmsg: Move the rpmsg control device
>> from rpmsg_char to rpmsg_ctrl"), we split the rpmsg_char driver in two.
>> By default give everyone who had the old driver enabled the rpmsg_ctrl
>> driver too.
>>
>> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
> 
> This patch is missing a separation marker, i.e "---", just above.  Without it
> the text below is also included in the changelog, and it shouldn't.

A badly controlled cleaning... I send a V3

My apologizes,
Arnaud 

> 
> Thanks,
> Mathieu
> 
>>
>> This patch is extracted from the series [1] that has been partially
>> integrated in the Linux Kernel 5.18-rc1.
>>
>> Update vs previous version:
>> - remove "Fixes:" tag in commit, requested by Mathieu Poirier in [2]
>>
>> [1]https://lore.kernel.org/lkml/15be2f08-ba03-2b80-6f53-2056359d5c41@gmail.com/T/
>> [2]https://lore.kernel.org/linux-arm-kernel/CANLsYky1_b80qPbgOaLGVYD-GEr21V6C653iGEB7VCU=GbGvAQ@mail.gmail.com/T/
>> ---
>>  arch/arm64/configs/defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 50aa3d75ab4f..3f8906b8a2ca 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -1053,6 +1053,7 @@ CONFIG_QCOM_Q6V5_PAS=m
>>  CONFIG_QCOM_SYSMON=m
>>  CONFIG_QCOM_WCNSS_PIL=m
>>  CONFIG_RPMSG_CHAR=m
>> +CONFIG_RPMSG_CTRL=m
>>  CONFIG_RPMSG_QCOM_GLINK_RPM=y
>>  CONFIG_RPMSG_QCOM_GLINK_SMEM=m
>>  CONFIG_RPMSG_QCOM_SMD=y
>> -- 
>> 2.25.1
>>
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 50aa3d75ab4f..3f8906b8a2ca 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1053,6 +1053,7 @@  CONFIG_QCOM_Q6V5_PAS=m
 CONFIG_QCOM_SYSMON=m
 CONFIG_QCOM_WCNSS_PIL=m
 CONFIG_RPMSG_CHAR=m
+CONFIG_RPMSG_CTRL=m
 CONFIG_RPMSG_QCOM_GLINK_RPM=y
 CONFIG_RPMSG_QCOM_GLINK_SMEM=m
 CONFIG_RPMSG_QCOM_SMD=y