From patchwork Sun Apr 10 15:08:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 12808166 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BDBBC433EF for ; Sun, 10 Apr 2022 15:10:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=yXQLNJQ4xGF3NbKJT25I0OpMzMR1sDDfUu32yVIwtXY=; b=BGB1OeWVim1mHg bFToKW+1F2bx62hsE8J1SAgs/+hEV58ftgGLOPx5uKxMuadWk3sDp64jTOIuRDXr64qg3cfGF4QRx GCGUTR1e6XGyyXiUT6dgtLBewB8XXNGc8NWIlXxF0XGIqQP3M8zmzphplXBowwUSmIJCSnBD3mzrw DVFihVCiMOjjgME4xynDB7StSy3iybGRm8bvv1+z963zSsHQtqePg5gJwe2kYnZkFFpB3B0YbALeD zpfNhS5DDya08AyQQz1kwZZEeuapRWfe7uGYLscyZwRYzr5P8J0lAxYH+XGPBIW8PR86sAICP1XbI cRp+vkTCW/P9v+YUuhIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndZBN-00527e-Az; Sun, 10 Apr 2022 15:08:53 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndZBI-00525j-E3 for linux-arm-kernel@lists.infradead.org; Sun, 10 Apr 2022 15:08:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649603322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0fBEBq6RqOmAXN69Pg2n48BAzr3YZ3kkOQrunZvVvGw=; b=itnHFUCWcyFpl5XDcq3/ISSZ4wgH5/NLNwWwKt9CFrtdbPNARNe7rXGVBC+zMKfJAwgaja R6aoqYlBt5wJ5t0TmTi9pPFr7kLR5tygo/k7md4fCnXWtjQ3UPcaNH4PDNHgofrb4OzCck rVuUdYJediH+3Go5NuU3GzNwePR/jTA= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-133-_gQ6n9RuNSa8ncMrHNvGgQ-1; Sun, 10 Apr 2022 11:08:40 -0400 X-MC-Unique: _gQ6n9RuNSa8ncMrHNvGgQ-1 Received: by mail-qv1-f72.google.com with SMTP id 7-20020a0562140dc700b004442d23d2d8so4369419qvt.2 for ; Sun, 10 Apr 2022 08:08:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0fBEBq6RqOmAXN69Pg2n48BAzr3YZ3kkOQrunZvVvGw=; b=Rz9RIyTqeoVyiGhCQyzfbJ0WHYM8/LNcPGKDraTPtQyhXkXMvZdxnjAxF2+O/uVTHj zydyakzcveNjznBHtV+2irwJj3uWSJEGXWROVhZ8kmORL/U3KJDtCWwf4mqZWo6dtTcQ WJUK//FylPQ/L77AdlNHj5EwxGZmBCzJ0j6LQinFes4DKCL3bSocxi5gslugt1FNCyY7 VK6yryGwUPP611bvOItnmnsMX38mv1QwMiwgQ9iOMwFrKlpb7B6IKS30Yb1/tMyx6Bwp Dl+47zeiEKN+85beuNQQKwcHtzYATp8nYR2+cn+I/jwuN43yHouzqrgsoLJSMhkIMdka V83A== X-Gm-Message-State: AOAM532MwkCze1bnbhK6oXeZ7l17R4RqFZaYG47l5S9YHmwdR0vyHTPa wM2IjUPLrbHkPFnBJoE3OUqIMvg2Us78IekOfSEd3TOQL0jzh0Yg2j9x5AtHbrQIctjsEcQB/tr GQg5oG19WiObMi6M43+VRF4zZS+jiLcIde74= X-Received: by 2002:a05:622a:1793:b0:2e1:ba41:ed2 with SMTP id s19-20020a05622a179300b002e1ba410ed2mr22788819qtk.238.1649603320227; Sun, 10 Apr 2022 08:08:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKeGNEEMC9VIu0CY/yX+G5qpcMSSfbg6/dzIhH0M4SK2dAYg8MtigVjD0z4TpmKs/XK+8K7Q== X-Received: by 2002:a05:622a:1793:b0:2e1:ba41:ed2 with SMTP id s19-20020a05622a179300b002e1ba410ed2mr22788754qtk.238.1649603319616; Sun, 10 Apr 2022 08:08:39 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id p12-20020a05622a00cc00b002ebdd6ef303sm7685357qtw.43.2022.04.10.08.08.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Apr 2022 08:08:39 -0700 (PDT) From: Tom Rix To: balbi@kernel.org, gregkh@linuxfoundation.org, joel@jms.id.au, andrew@aj.id.au, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, alcooperx@gmail.com, christophe.jaillet@wanadoo.fr, cai.huoqing@linux.dev, benh@kernel.crashing.org, neal_liu@aspeedtech.com, miles.chen@mediatek.com, balamanikandan.gunasundar@microchip.com, macpaul.lin@mediatek.com, s.shtylyov@omp.ru, jakobkoschel@gmail.com, stern@rowland.harvard.edu, andriy.shevchenko@linux.intel.com, quic_wcheng@quicinc.com, yashsri421@gmail.com, rdunlap@infradead.org Cc: linux-geode@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, bcm-kernel-feedback-list@broadcom.com, Tom Rix Subject: [PATCH] usb: gadget: udc: clean up comments Date: Sun, 10 Apr 2022 11:08:28 -0400 Message-Id: <20220410150828.1891123-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220410_080848_588007_19AA4F19 X-CRM114-Status: GOOD ( 22.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SPDX *.h use /* */ style comments For double words, remove with, also Spelling replacements wayt to way wakup to wakeup Contrl to Control cheks to checks initiaization to initialization dyanmic to dynamic Signed-off-by: Tom Rix --- drivers/usb/gadget/udc/amd5536udc.h | 2 +- drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++-- drivers/usb/gadget/udc/at91_udc.c | 2 +- drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++-- drivers/usb/gadget/udc/core.c | 4 ++-- drivers/usb/gadget/udc/trace.h | 2 +- 9 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/usb/gadget/udc/amd5536udc.h b/drivers/usb/gadget/udc/amd5536udc.h index 055436016503..e670d251e16f 100644 --- a/drivers/usb/gadget/udc/amd5536udc.h +++ b/drivers/usb/gadget/udc/amd5536udc.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * amd5536.h -- header for AMD 5536 UDC high/full speed USB device controller * diff --git a/drivers/usb/gadget/udc/aspeed-vhub/core.c b/drivers/usb/gadget/udc/aspeed-vhub/core.c index 7a635c499777..8eba6d744090 100644 --- a/drivers/usb/gadget/udc/aspeed-vhub/core.c +++ b/drivers/usb/gadget/udc/aspeed-vhub/core.c @@ -180,7 +180,7 @@ void ast_vhub_init_hw(struct ast_vhub *vhub) * We do *NOT* set the VHUB_CTRL_CLK_STOP_SUSPEND bit * to stop the logic clock during suspend because * it causes the registers to become inaccessible and - * we haven't yet figured out a good wayt to bring the + * we haven't yet figured out a good way to bring the * controller back into life to issue a wakeup. */ diff --git a/drivers/usb/gadget/udc/aspeed-vhub/ep0.c b/drivers/usb/gadget/udc/aspeed-vhub/ep0.c index b4cf46249fea..3c64c00546ec 100644 --- a/drivers/usb/gadget/udc/aspeed-vhub/ep0.c +++ b/drivers/usb/gadget/udc/aspeed-vhub/ep0.c @@ -366,7 +366,7 @@ static int ast_vhub_ep0_queue(struct usb_ep* u_ep, struct usb_request *u_req, struct device *dev = &vhub->pdev->dev; unsigned long flags; - /* Paranoid cheks */ + /* Paranoid checks */ if (!u_req || (!u_req->complete && !req->internal)) { dev_warn(dev, "Bogus EP0 request ! u_req=%p\n", u_req); if (u_req) { diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c b/drivers/usb/gadget/udc/aspeed-vhub/hub.c index 65cd4e46f031..70001decf8c0 100644 --- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c +++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c @@ -551,7 +551,7 @@ void ast_vhub_device_connect(struct ast_vhub *vhub, 0, true); /* - * If the hub is set to wakup the host on connection events + * If the hub is set to wakeup the host on connection events * then send a wakeup. */ if (vhub->wakeup_en) diff --git a/drivers/usb/gadget/udc/aspeed-vhub/vhub.h b/drivers/usb/gadget/udc/aspeed-vhub/vhub.h index 6b9dfa6e10eb..81b92d683c35 100644 --- a/drivers/usb/gadget/udc/aspeed-vhub/vhub.h +++ b/drivers/usb/gadget/udc/aspeed-vhub/vhub.h @@ -23,9 +23,9 @@ #define AST_VHUB_USBSTS 0x24 /* USB Status Register */ #define AST_VHUB_EP_TOGGLE 0x28 /* Programmable Endpoint Pool Data Toggle Value Set */ #define AST_VHUB_ISO_FAIL_ACC 0x2C /* Isochronous Transaction Fail Accumulator */ -#define AST_VHUB_EP0_CTRL 0x30 /* Endpoint 0 Contrl/Status Register */ +#define AST_VHUB_EP0_CTRL 0x30 /* Endpoint 0 Control/Status Register */ #define AST_VHUB_EP0_DATA 0x34 /* Base Address of Endpoint 0 In/OUT Data Buffer Register */ -#define AST_VHUB_EP1_CTRL 0x38 /* Endpoint 1 Contrl/Status Register */ +#define AST_VHUB_EP1_CTRL 0x38 /* Endpoint 1 Control/Status Register */ #define AST_VHUB_EP1_STS_CHG 0x3C /* Endpoint 1 Status Change Bitmap Data */ #define AST_VHUB_SETUP0 0x80 /* Root Device Setup Data Buffer0 */ #define AST_VHUB_SETUP1 0x84 /* Root Device Setup Data Buffer1 */ diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c index 728987280373..c80d0902bb30 100644 --- a/drivers/usb/gadget/udc/at91_udc.c +++ b/drivers/usb/gadget/udc/at91_udc.c @@ -994,7 +994,7 @@ static const struct usb_gadget_ops at91_udc_ops = { .udc_stop = at91_stop, /* - * VBUS-powered devices may also also want to support bigger + * VBUS-powered devices may also want to support bigger * power budgets after an appropriate SET_CONFIGURATION. */ /* .vbus_power = at91_vbus_power, */ diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c index 9849e0c86e23..223e08e53f94 100644 --- a/drivers/usb/gadget/udc/bdc/bdc_core.c +++ b/drivers/usb/gadget/udc/bdc/bdc_core.c @@ -296,7 +296,7 @@ static void bdc_mem_init(struct bdc *bdc, bool reinit) for (i = 1; i < bdc->num_eps; ++i) bdc->bdc_ep_array[i]->flags = 0; } else { - /* One time initiaization only */ + /* One time initialization only */ /* Enable status report function pointers */ bdc->sr_handler[0] = bdc_sr_xsf; bdc->sr_handler[1] = bdc_sr_uspc; @@ -361,7 +361,7 @@ int bdc_reinit(struct bdc *bdc) return ret; } -/* Allocate all the dyanmic memory */ +/* Allocate all the dynamic memory */ static int bdc_mem_alloc(struct bdc *bdc) { u32 page_size; diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index 85b194011a16..bf472478239b 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -162,7 +162,7 @@ EXPORT_SYMBOL_GPL(usb_ep_disable); /** * usb_ep_alloc_request - allocate a request object to use with this endpoint - * @ep:the endpoint to be used with with the request + * @ep:the endpoint to be used with the request * @gfp_flags:GFP_* flags to use * * Request objects must be allocated with this call, since they normally @@ -897,7 +897,7 @@ EXPORT_SYMBOL_GPL(usb_gadget_unmap_request); /** * usb_gadget_giveback_request - give the request back to the gadget layer - * @ep: the endpoint to be used with with the request + * @ep: the endpoint to be used with the request * @req: the request being given back * * This is called by device controller drivers in order to return the diff --git a/drivers/usb/gadget/udc/trace.h b/drivers/usb/gadget/udc/trace.h index 98584f6b6c66..75987cae2a15 100644 --- a/drivers/usb/gadget/udc/trace.h +++ b/drivers/usb/gadget/udc/trace.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0 +/* SPDX-License-Identifier: GPL-2.0 */ /* * udc.c - Core UDC Framework *