From patchwork Tue Apr 12 09:04:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philippe Schenker X-Patchwork-Id: 12810246 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33733C433EF for ; Tue, 12 Apr 2022 09:06:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=9ApK9w2oe034sGSlNYct1eftnHv/NUGxQjzwUa1kI88=; b=FiYl9EaCVHkaNj n94BJELWrJ1Yby/jRbz4SBD2jR6FpcyoDYNgGVd87yl5z/q0eG1EKbyG5GrT7HUJx9uR+xlg1a5Ji AjUUFunvxQIX4Of5OGDUWnEaFMbkhU1EiNH5veMVTOU8C3UvAsJVXguxVOgXSEJ/FIyOSNxDrEps3 Ud7OwXRZfke14KieHPKRgNyOElL8eWeJJfbtD/1/NXWgH9ED3HMLdsKog5VYVOX2xVwGjUavx81RU y5PHywLYZIF0wFM/t42drfDI5bhPeNpSD6Ne4CfEpm5lD7JGAIqeVghTa82w7w9RiesVHk6Oniune LqOpcOBRJUJl16k9nSGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCSn-00CmTl-FJ; Tue, 12 Apr 2022 09:05:29 +0000 Received: from mxout012.mail.hostpoint.ch ([2a00:d70:0:e::312]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCSj-00CmQ3-82; Tue, 12 Apr 2022 09:05:27 +0000 Received: from [10.0.2.44] (helo=asmtp014.mail.hostpoint.ch) by mxout012.mail.hostpoint.ch with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.95 (FreeBSD)) (envelope-from ) id 1neCSD-000OOB-IK; Tue, 12 Apr 2022 11:04:53 +0200 Received: from 31-10-206-124.static.upc.ch ([31.10.206.124] helo=localhost.localdomain) by asmtp014.mail.hostpoint.ch with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.95 (FreeBSD)) (envelope-from ) id 1neCSD-000CGw-Ce; Tue, 12 Apr 2022 11:04:53 +0200 X-Authenticated-Sender-Id: dev@pschenker.ch From: Philippe Schenker To: linux-wireless@vger.kernel.org, Felix Fietkau Cc: linux@leemhuis.info, Philippe Schenker , "David S. Miller" , Deren Wu , Jakub Kicinski , Kalle Valo , Lorenzo Bianconi , Matthias Brugger , Paolo Abeni , Ryder Lee , Sean Wang , Shayne Chen , YN Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH] Revert "mt76: mt7921: enable aspm by default" Date: Tue, 12 Apr 2022 11:04:14 +0200 Message-Id: <20220412090415.17541-1-dev@pschenker.ch> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_020525_309919_7CD7DA5C X-CRM114-Status: UNSURE ( 9.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8. This commit introduces a regression on some systems where the kernel is crashing in different locations after a reboot was issued. This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest firmware. Link: https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/ Signed-off-by: Philippe Schenker --- drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c index 1a01d025bbe5..59f9ee089389 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c @@ -20,10 +20,6 @@ static const struct pci_device_id mt7921_pci_device_table[] = { { }, }; -static bool mt7921_disable_aspm; -module_param_named(disable_aspm, mt7921_disable_aspm, bool, 0644); -MODULE_PARM_DESC(disable_aspm, "disable PCI ASPM support"); - static void mt7921_rx_poll_complete(struct mt76_dev *mdev, enum mt76_rxq_id q) { @@ -280,8 +276,7 @@ static int mt7921_pci_probe(struct pci_dev *pdev, if (ret) goto err_free_pci_vec; - if (mt7921_disable_aspm) - mt76_pci_disable_aspm(pdev); + mt76_pci_disable_aspm(pdev); mdev = mt76_alloc_device(&pdev->dev, sizeof(*dev), &mt7921_ops, &drv_ops);