From patchwork Mon Apr 18 14:44:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 12816666 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92493C433F5 for ; Mon, 18 Apr 2022 14:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=PWBG7w8USX5Kyo3SHgBW/ayAs4AVX5WSMilVI1+RW0w=; b=xSPWLjIibOXXoz vFldSzGQfQsAH7JkwJyOcJFPzaicm6wJmoF9BG4qhe7tuPU1ZyvVVyhNW00cb9RIA6BMoy+ZcACVM R7M9+93FpU7Zhr7BbWMxGBJkKY6JqGobPadgTzxHdbBYu22QwskEeEPrWTenIjHbokz3QqN2NceZR 6U2t6tDR4cl0fjoCUubMB1bURrm5DIQWuiJcrDsO6/vtCvOY3YEsbvDxq3yp6vszb/Xu7mTLOMM/A mYHXTkqrELm19XoGw6d0Lx9piO3I25Ie/El6Qzy6ZL75fiDLZnwbadLIqlHAt8GOe6ItJxCr+xWhS bQmmQu0YegXLl0p84HTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngSc2-00HLjm-Gi; Mon, 18 Apr 2022 14:44:22 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngSbz-00HLjP-JK for linux-arm-kernel@lists.infradead.org; Mon, 18 Apr 2022 14:44:20 +0000 Received: by mail-wr1-x42b.google.com with SMTP id g18so18776126wrb.10 for ; Mon, 18 Apr 2022 07:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=U/BmndimxRUeGnhgbDunPyQq29ma5+SBfEP8BqMsdFU=; b=ZLnqQm98G+ZMkFQXpLyGZSX7fecCPhjMaUZd1GrcqcdgaP6HD6TuQSlDJ3MYDJ6g7y fjGPUCmal/HdSK6Joq1ZM5PJTvmmrMpUwmh9uy8kZyyOytxq4Fz91uEVLK/alpOxuHD+ hhKyyIWY6OZg4IaB8v/e30AnJ50CeXu34skkKWsH66GkjbeNa7HhkbRLzoYi5D01P4Gb G5IiYD7NH9MxyhCdiPXFNJ0pIWeASI4bs01Vyn9WUV+AurAIfp9oIcZHa0DdeIQuZLEK 6dv3Howdcd6jr+QU19tVb12STIXLZaknW+Tm6Q12MyVCw1Mz9sQRQ7882olvihPcasSD Z0nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=U/BmndimxRUeGnhgbDunPyQq29ma5+SBfEP8BqMsdFU=; b=Z8S+DyDcCBHNG1mHh1tj7CySdu7tDQeST3i/aR4ptNdKzSEtMfeX88lWsNyPGFEyak qrKaKTGJZrya/MoQQWZNI182Lf5mGgHqt+3CIpRtLlfk/gVO9mamrbVOTJVPDuIfpsox cRVzOlw9G68v3uj+u/oJ9a5wg82SwJwF30DhtxEA/Nrn/5IbTESnYZ7FFJsGOSwuYL8e O88IapOiL6PxZDRbzs6NMYJbMQPub9BWWzxg1HYyHeRpmKHCUcH56ND8vRWldDmFSNfX MfiOw4PVrLXkwkw8eYYaq8XQBAgkTNEQViEftAX+2SkWqUk/45qsAFgHAGkYl+R4Yqjp My8A== X-Gm-Message-State: AOAM5324ZREj+ACzzvflZ3G0AClSklVsv5FFhVZToLnIPLkTciNIOOZQ wBAjiw/go2qatSFkS/owWmw6cUvImpmbKA== X-Google-Smtp-Source: ABdhPJy6pPOJ+6VhwxYN/pnIzTHx+lgfuKlb7rqnPNvgzd2Y+LUnRXOI5h+9yUgPBmkfSXaE05jaAQ== X-Received: by 2002:a05:6000:1ace:b0:203:d465:1a83 with SMTP id i14-20020a0560001ace00b00203d4651a83mr8476727wry.26.1650293058002; Mon, 18 Apr 2022 07:44:18 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id d2-20020a056000186200b0020a7be3f1d2sm9107529wri.53.2022.04.18.07.44.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 07:44:17 -0700 (PDT) From: Colin Ian King To: Rob Herring , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH] PCI: versatile: Remove redundant variable retval Date: Mon, 18 Apr 2022 15:44:16 +0100 Message-Id: <20220418144416.86121-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220418_074419_694739_A159F21C X-CRM114-Status: GOOD ( 12.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Variable retval is being assigned a value that is never read, the variable is redundant and can be removed. Cleans up clang scan build warning: drivers/pci/controller/pci-versatile.c:37:10: warning: Although the value stored to 'retval' is used in the enclosing expression, the value is never actually read from 'retval' [deadcode.DeadStores] Signed-off-by: Colin Ian King --- drivers/pci/controller/pci-versatile.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pci/controller/pci-versatile.c b/drivers/pci/controller/pci-versatile.c index 653d5d0ecf81..7991d334e0f1 100644 --- a/drivers/pci/controller/pci-versatile.c +++ b/drivers/pci/controller/pci-versatile.c @@ -31,10 +31,9 @@ static u32 pci_slot_ignore; static int __init versatile_pci_slot_ignore(char *str) { - int retval; int slot; - while ((retval = get_option(&str, &slot))) { + while (get_option(&str, &slot)) { if ((slot < 0) || (slot > 31)) pr_err("Illegal slot value: %d\n", slot); else