From patchwork Fri Apr 22 01:33:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12822646 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFA13C433EF for ; Fri, 22 Apr 2022 01:34:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FuLY6NZic7Nn3C8+Dp73IWJvkWFUgftc9Z6xpB5ZZJM=; b=py8q081H5wW9bE ezdBfJdvIdQJjV8X/gbiTgN31W4VQmeUmpCedRgHMG7Nn0YJWZ+PF8aBktsKY43wMtQvru+By3IRB UNdOD+EwqbTPpYoapWULsyCyFvgYuo0MFFFtc64uNXshT5A9j4ShyfwbuGSPayWZAIZpJ0XSKw01x nBaI7q9cbJScpbOjy51Cu+XRDylLISnonfrlimTcMIdWE6cbDvxDn4z4NhDIYUVWMSwE+CZL24zZa SuqGz/vpXCYNsxalReIKZpuN/9qiDsRRJ9fcZUlcxAK6kDHqTvLh9Xsb4/1WxyIAc+ZB6YIHIUZpz MKq2dcCpYvkbL6MOQ3DA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhiAq-00Fa99-Cr; Fri, 22 Apr 2022 01:33:28 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhiAn-00Fa8Q-IX for linux-arm-kernel@lists.infradead.org; Fri, 22 Apr 2022 01:33:26 +0000 Received: by mail-pg1-x529.google.com with SMTP id s137so6130084pgs.5 for ; Thu, 21 Apr 2022 18:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ihxe6zxbUA/1vzj66/JVhIWgSQBXfTvpOsIAjBTzmgI=; b=dMgP5O6mpu60na3kHGDMSK73m9DHFBs2SGazQ1eRLrH0DwCHnlEfFT8bmKffGEga+C yiugD8GVWVG32heRbcq/6H35SUnC90ACuAyGywpOaDYjPTPviqG2YxJFvOs4J3Pg5RVk EU6m/ozHfU4JfH5S/b1YU8D4cUE2YGUoXFnI46nqv2C3L/hqLF0MY7rO4Fht5PlXk2Vy iNbHpyQm7dqb3Ui6U/pnIVg8MHQhRjGSDP0ScdZcUyO1PrpQvg6OW+nJ835fulm0iYLP Hi3yhfO6w81oYUsokRogJ9MECCBYWz09wGRww4n4/IJQH9pYpUq8CqUc6NbI35ms6T3g VJ9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ihxe6zxbUA/1vzj66/JVhIWgSQBXfTvpOsIAjBTzmgI=; b=qyRDG8YU4SjQfS/dWVXucBYOr1ipd2xoB43Vm3kAUg/DECSP18B4Ob/vI6ycN5u1Y5 ydRdbrJaqMizOPU2Ar2ZqLwQKRULMuaYFkfgy+qnDaw8cSsuxpowb9eMfkxzGN+ry7uq ZTOVZP7JkFHTFte+KAiZ62CNgIv6qB53y/LlH+6GI5YX2D6JR/vpAY2ds+hqerA1grdm B3IyDxvoPYyyoMEr7/v7nW0CtFmxkH1rZTplx6O5Gz8l0cP1rJzUGik4pOEUd7L9q3yb CEF5St4xCZmnAhU9YrP6YnMQ/V7uey/O7BlpoS7HXTq0X589+URtaF9WLyvABs4m3Sqf 5t+A== X-Gm-Message-State: AOAM533H8YVzqeXk1yWh3fbrXvfwk2bwJwx1bIDR374jFhR7MPsnJ3nw Tmfk5IaCBnbXXEAvgENXLMw= X-Google-Smtp-Source: ABdhPJyZwxQGChQpNHE19k0m0w52P/We+iqsLDG16PSwTJvTGWUMlaU+NNKLetC+Bi3ifjkdMJWr/w== X-Received: by 2002:a63:2a02:0:b0:3aa:c641:cd86 with SMTP id q2-20020a632a02000000b003aac641cd86mr537891pgq.614.1650591204218; Thu, 21 Apr 2022 18:33:24 -0700 (PDT) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id 21-20020a630715000000b003aa63b1fd1bsm395634pgh.1.2022.04.21.18.33.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 18:33:23 -0700 (PDT) From: Miaoqian Lin To: Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Dong Aisheng , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH v2] clk: imx: scu: Use pm_runtime_resume_and_get to fix pm_runtime_get_sync() usage Date: Fri, 22 Apr 2022 09:33:16 +0800 Message-Id: <20220422013317.30362-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220422012059.52267C385A5@smtp.kernel.org> References: <20220422012059.52267C385A5@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220421_183325_645265_E36A8E0B X-CRM114-Status: GOOD ( 14.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If the device is already in a runtime PM enabled state pm_runtime_get_sync() will return 1. Also, we need to call pm_runtime_put_noidle() when pm_runtime_get_sync() fails, so use pm_runtime_resume_and_get() instead. this function will handle this. Fixes: 78edeb080330 ("clk: imx: scu: add runtime pm support") Signed-off-by: Miaoqian Lin --- drivers/clk/imx/clk-scu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c index 083da31dc3ea..2044e62980e3 100644 --- a/drivers/clk/imx/clk-scu.c +++ b/drivers/clk/imx/clk-scu.c @@ -528,7 +528,7 @@ static int imx_clk_scu_probe(struct platform_device *pdev) pm_runtime_use_autosuspend(&pdev->dev); pm_runtime_enable(dev); - ret = pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); if (ret) { pm_genpd_remove_device(dev); pm_runtime_disable(dev);