From patchwork Tue Apr 26 14:15:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 12827298 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7820AC433EF for ; Tue, 26 Apr 2022 14:19:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vusw7cTafi8LBlxOHmhX4DrJLEva7ye92WAfvZsWLFM=; b=VR7T9jcCN2Rqr5 B5YiOuRXIhXH4QegUoDAfkaeaPi2exlxub0+jmvIWyEjdx8oFKbybQizWTiMpsUzXwCZIsFczpta0 CoVRr6oWqzj+HZ1R7QFIebQjJFrE+GsKJQ3d+EPZPcabvaaTJVWYcsyGvj4b0sJVQD6sheo66emne 5NYUQn9YT317BUENoArYTVcLsvEvoqQg9Q94q9kktW0geiX+1sCMDDHYEC/FpZ7ogJQ+DcskwzCxn ps86WhPT8TI0o1phPChBBScvV3p8P4yIUvjfyAjBT8gs9XgorODdfvZw8k2Eyz7BSWAWYhCNNWTik DO69L1A4BTfQobMeLrnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njM0x-00EwcD-Lt; Tue, 26 Apr 2022 14:18:03 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njLyV-00EvZu-9i for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2022 14:15:41 +0000 Received: by mail-lf1-x136.google.com with SMTP id x17so32192020lfa.10 for ; Tue, 26 Apr 2022 07:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zxzRefBI77z9hgqatEhKgv+DKfty9U6ghK1LVbo7j6g=; b=QLGRhd2Pi4JCAUmodnhxjytlHsjYsMztxt8K9xc9qpYANI7AaZrhTsscio79IjkUQI yXTk3H5XAsGl1hvlWbmja6j8KSC4ujPyuzGpvoJ01C56f1V0zQfoiuUmz3llwVoHJKBg 4mSQSgXTuwl2xGlP0GuQRQ1CKGSwZ/N6zsFtXfB8Wn3ROzZS1nEFZHTrsxZ0cQlZcroP 7v7G8RaiUEDKK2NNHSGXscxZjbEwOqX3Fw7eaNovtrd6HauNzxO+YfXM4TdncNnICHFv PdU/ClRkVedYyYqtUjd9ZuU23nbodUEy0nQIR2/45L2R9leg7o8jvY1UQa95gM8Y9CD+ f2QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zxzRefBI77z9hgqatEhKgv+DKfty9U6ghK1LVbo7j6g=; b=Frq03QEuq2X0Ko92FpeYIYU6t+KGSIKoioOORnwCNqzAPuZJJVaFzXz7UmVBUBmGhM H9J/R+r16H9up8FEHsFfFXfjKka7fIlGjtJCyMSbMVlHaoeBUgLiZcT535ZwbD3XxUyh /gBis5lRoZxISsoQMVEONsCCY/jeJGpvA2ec8pK2E9iqoIykpPvmzrm9PhqfJ1syPkQ3 97z0cAQgv1IfasaHhsR0HDWncWS1WdMKPVzvrDQYqTnfQj5pafVT9a8l/xaJ7Zs2LiZN HnicOioUuxbY80PBsQUfE/JJNd3h37FYq64h+HN5i5EMUdPDjs+x3McSRO08n8ERwtIw 4/6Q== X-Gm-Message-State: AOAM531RKIUfGGVRKJ40JeczlaEmJvgH2yihqDaVDdKUg86t/TnaFyZP Z/xoDk3ne7y0zRIVUJyPgnZtog== X-Google-Smtp-Source: ABdhPJwZM0hz5NTNslZdZTT4y9WKN1tMWLtl28kfh2I/DoQpBRrptcN0q0StrVDO9i2WSkdgy7mAhw== X-Received: by 2002:a05:6512:6c2:b0:46b:9578:7c63 with SMTP id u2-20020a05651206c200b0046b95787c63mr17462809lff.204.1650982527150; Tue, 26 Apr 2022 07:15:27 -0700 (PDT) Received: from localhost.localdomain (h-98-128-181-154.NA.cust.bahnhof.se. [98.128.181.154]) by smtp.gmail.com with ESMTPSA id g23-20020a2ea4b7000000b0024f096abebdsm1043360ljm.78.2022.04.26.07.15.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 07:15:22 -0700 (PDT) From: Ulf Hansson To: "Rafael J . Wysocki" , linux-pm@vger.kernel.org Cc: Kevin Hilman , Vincent Guittot , Geert Uytterhoeven , Dmitry Osipenko , Ulf Hansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] PM: domains: Drop redundant code for genpd always-on governor Date: Tue, 26 Apr 2022 16:15:06 +0200 Message-Id: <20220426141507.89868-3-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220426141507.89868-1-ulf.hansson@linaro.org> References: <20220426141507.89868-1-ulf.hansson@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220426_071531_419874_D925CC12 X-CRM114-Status: GOOD ( 11.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Due to recent changes, the always-on governor is always used with a genpd that has the GENPD_FLAG_RPM_ALWAYS_ON flag being set. This means genpd, doesn't invoke the governor's ->power_down_ok() callback, which makes the code in governor redundant, so let's drop it. Signed-off-by: Ulf Hansson --- drivers/base/power/domain_governor.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/base/power/domain_governor.c b/drivers/base/power/domain_governor.c index cd08c5885190..c13e44823f16 100644 --- a/drivers/base/power/domain_governor.c +++ b/drivers/base/power/domain_governor.c @@ -327,11 +327,6 @@ static bool default_power_down_ok(struct dev_pm_domain *pd) return _default_power_down_ok(pd, ktime_get()); } -static bool always_on_power_down_ok(struct dev_pm_domain *domain) -{ - return false; -} - #ifdef CONFIG_CPU_IDLE static bool cpu_power_down_ok(struct dev_pm_domain *pd) { @@ -401,6 +396,5 @@ struct dev_power_governor simple_qos_governor = { * pm_genpd_gov_always_on - A governor implementing an always-on policy */ struct dev_power_governor pm_domain_always_on_gov = { - .power_down_ok = always_on_power_down_ok, .suspend_ok = default_suspend_ok, };