From patchwork Thu May 12 02:06:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12846783 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76D96C433F5 for ; Thu, 12 May 2022 02:07:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=TtjrHXuCfj2w3hHWhj8baBv9Dn5jasDKiojwTizbFZQ=; b=Efw+xNfWzsJje9 b+oAibEzFLlBY9RWumT8ONESgSjrzWZX1zSoKNFZ5mJLZDSjOp2/JB1toPMDG5ONkdopFjLhUG4qC tJOLXgVqVMLoFvwG/+BYOzPaFSdwarjab4NT9PRIY6VSHsB9+ni4WBBEqv28Qw4XIQicQlAmNxJc1 6mOfetjFNj6jna9aVw97pNbrWb0JWFLQs/U0gDgMtE62/yWH5yEDZjkqL0C6OPEbdoV85oi5a08NL 4eRzbgv5mYplEtA5PI2+G9PVq2jB7lVkoi/C4vxKdsG8EL0pBDrm0etC26+oUjCa0ARbivW9Uuicf lIqP2oeowqHZISDn9D0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noyEB-009MOR-SC; Thu, 12 May 2022 02:06:55 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noyE8-009MNk-8p for linux-arm-kernel@lists.infradead.org; Thu, 12 May 2022 02:06:53 +0000 Received: by mail-pg1-x52a.google.com with SMTP id v10so3299304pgl.11 for ; Wed, 11 May 2022 19:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=e5ejgBXTAIUixboB4DJUAMoeq/lr5AGnM16DSQO4iD0=; b=fWC+os+5n3q5/oM2q5UhHNUR8KmKwVjjKQfn64+siR+2+lrAqRjVCkyp9Q+pkXlfBz lJrhatB9kQcByfRRRra7p7C6S7etFxRUVRMGsSorHmPfK0zW9HpaQHCiPllXxTZITPjn Pc1GYf7Z2nvpXE9yI1Z4fU4Oaibv0Wng+1u0O+JtyrO7cAe8zltj5qAtrm0jVouWDKqp wxMXtnNaw+UGugaLoMKnhca/+qSPA51U27Y+WPH9LhzTdaPMLJthwqy+o2H/kHGJFU5v zcex7eucr8UcmLQnC6Hw8Xt1iKiDNkbv/OqyTLli2z6Mj162j4ytc253hzEt5AbqVh0l Md5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=e5ejgBXTAIUixboB4DJUAMoeq/lr5AGnM16DSQO4iD0=; b=xEn2Ml+BSAYPpObnA9QJ+zemSNmJahqv1Y9LkUpvyusDrYRJxAev6Vp44hS22FqlE3 AOu1PGpLvfJlu/RRJMkjPbRWuh9Eobq4nyNu6DJAtrLIB4YXAMSIz707/ZvSeKY5zdCv YBkCKRvKJiTHIJR+8RNTil3KsRNVroPItBR1h//yITl2EMxLjXhYka4tmVmpiKVAEQav JeKyRk/U48W1mBmRTH4n/aTAELl30Om+q5o7v3Dc5COWteBO+h6ziYFug6/TaoenTaRL yT3EZ5GpyDBKwlwHKXkIhGey9W4ZdAmEdgvVEyT/VnqO5rc8a1y2Sx/18bfXS/S/M2/T gy3Q== X-Gm-Message-State: AOAM531fPwNyt9U1E9RAhRupHxUF8QuqINZZAE1zVk4R3i6rHZe4F78a Frs7JL9gpKXuEoWlzsyoVsE= X-Google-Smtp-Source: ABdhPJxxgUYp/Q7pUWclcnmdGsopJnbeev5DMjUldDXikj/BlTisP/Hk4WZo8xQgJnuYpuARQyVVUQ== X-Received: by 2002:a63:81c6:0:b0:3ab:616b:35b with SMTP id t189-20020a6381c6000000b003ab616b035bmr23545343pgd.256.1652321210709; Wed, 11 May 2022 19:06:50 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id a17-20020a63d411000000b003c14af5063fsm520814pgh.87.2022.05.11.19.06.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 19:06:50 -0700 (PDT) From: Miaoqian Lin To: Russell King , Miaoqian Lin , Linus Walleij , Anders Berg , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: Fix refcount leak in axxia_boot_secondary Date: Thu, 12 May 2022 06:06:39 +0400 Message-Id: <20220512020641.45156-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220511_190652_342692_61AE645E X-CRM114-Status: GOOD ( 12.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 1d22924e1c4e ("ARM: Add platform support for LSI AXM55xx SoC") Signed-off-by: Miaoqian Lin --- arch/arm/mach-axxia/platsmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-axxia/platsmp.c b/arch/arm/mach-axxia/platsmp.c index 512943eae30a..2e203626eda5 100644 --- a/arch/arm/mach-axxia/platsmp.c +++ b/arch/arm/mach-axxia/platsmp.c @@ -39,6 +39,7 @@ static int axxia_boot_secondary(unsigned int cpu, struct task_struct *idle) return -ENOENT; syscon = of_iomap(syscon_np, 0); + of_node_put(syscon_np); if (!syscon) return -ENOMEM;