From patchwork Thu May 12 08:15:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12847302 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57FAFC433EF for ; Thu, 12 May 2022 08:17:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Y9IGjFCk/FvX53cR3Dgm8h2hWl1kR/gZ9H9YvXGoX1E=; b=B7hLPYgSrX62xZ cMpCQFlfsa3xrdOSTWmlXR1DoNkBTGQc8DKBfxAaZcAzJTcknjYY4UrZolvatRHywtisFXTAYmvlv ha5PWdp7WgS6CIS9jmCJw183jIksmKhboOu15912k58Q9FjmlK5r0cAKGDP0q6X5Q1dOfMSX8OS1Q gJG8HZWE7HkxYWxk8jRS1KrlhFPhhKt35AafE7dOXv8KZsRZTQJJhEnWibtirNoMgfWGaf+bqzzjs /27KCrzTc0eRBLlMnkf6iNcr1/WWsav1kApDf1Hbo3Ts9/WI9I/rMgl67JUVvOetYZvyCueONz+Dm 8rNdUvtf0AUeG7bfsG5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1np3zY-00AtjX-9R; Thu, 12 May 2022 08:16:12 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1np3zR-00Atfl-Dj for linux-arm-kernel@lists.infradead.org; Thu, 12 May 2022 08:16:06 +0000 Received: by mail-pg1-x52f.google.com with SMTP id a19so3729476pgw.6 for ; Thu, 12 May 2022 01:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tUkJOIS8lwBZmrt5a2OvebuTUCP3blFkLYSYRFyjeQY=; b=Np32Pz60lGHyi5QgB4d6enqs5e24lUOA+sXhYI684Gk8Sj/D8pzT1/wyZHty3fVAAy Y4oeH691lpGUi4tr7yKIOwe3FtSebEjbJW4xx57BGrDumWR/lnnAbyqqbXfnfdcT/TFC IGBUc0oBbXMbNIm7xjFcVk/HI0aGA3HXopY0l7XTI2vMpy/0Hiorj6XMin4WfKLIEY+n YNyUbnbKzmyCc555vbO4nV8uLP/cCFjGM0LKHDngPENpCHaRyVMryOCx1iHeAnTQaNQC 6y+SuJ9KMoCBd62+U1VV0eErirt0xIhv2gQ7AvLsSgFt9MMPxJsF9xYi9MkaZXFJvr6G yQqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tUkJOIS8lwBZmrt5a2OvebuTUCP3blFkLYSYRFyjeQY=; b=S6SuX9yYaY4WbeBQJWj5wZmOvxbUo/6+YJ1fRcTitO90sLT+ttHo6TbAUc71skISQ3 3fCNmPrbPZ5/zPiwzRnL8tUNnzA2P0Uu1ag5c2qY8z3SBWzXHMasP2odMa3mbUZj3HQC J3URJVMcwEfYDoGSDAbL6wWHO9XkF4Q/lHpYC0wLc1EWIo8qayg6GHRO6O5s6Kyx7Frv Sz515/uQQNUAI+C4a4oJP9+hXNbgr+1v8CBHpPl1Sru9Me5MPMU4kWIMN+dleNbNZSWJ DzkU+ju3meWs7japemStAXO90Fb0G6qe2wQlCAAsHtFycI1SZJofniA1POkN/qkBLix7 Jm2w== X-Gm-Message-State: AOAM533mDVwqL5pjqs5SX6s7yB4s633HEDzIIFc8N4RFoW2xhrxAzkrH uSKyDLAQLK1Chd6nCmxDvUE= X-Google-Smtp-Source: ABdhPJyzuQEUlIMDx98SBZY7SWhn0EDZgQDhOP33U0ZSGHiOS48GCmCZ4reUHEUYam6IzMd2Dy9Dvw== X-Received: by 2002:a05:6a00:1a87:b0:50e:22b:c4a1 with SMTP id e7-20020a056a001a8700b0050e022bc4a1mr28950140pfv.75.1652343362244; Thu, 12 May 2022 01:16:02 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id l20-20020a056a00141400b0050dc76281a1sm3170790pfu.123.2022.05.12.01.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 01:16:01 -0700 (PDT) From: Miaoqian Lin To: Russell King , Taichi Sugaya , Takao Orito , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] ARM: milbeaut: Fix refcount leak in m10v_smp_init Date: Thu, 12 May 2022 12:15:53 +0400 Message-Id: <20220512081554.28562-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220512_011605_530358_6857D023 X-CRM114-Status: GOOD ( 11.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 9fb29c734f9e ("ARM: milbeaut: Add basic support for Milbeaut m10v SoC") Signed-off-by: Miaoqian Lin Acked-by: Sugaya Taichi --- arch/arm/mach-milbeaut/platsmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-milbeaut/platsmp.c b/arch/arm/mach-milbeaut/platsmp.c index 3ea880f5fcb7..1f1ff21c7140 100644 --- a/arch/arm/mach-milbeaut/platsmp.c +++ b/arch/arm/mach-milbeaut/platsmp.c @@ -53,6 +53,7 @@ static void m10v_smp_init(unsigned int max_cpus) return; m10v_smp_base = of_iomap(np, 0); + of_node_put(np); if (!m10v_smp_base) return;