From patchwork Mon May 16 07:41:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12850353 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D39BC433FE for ; Mon, 16 May 2022 07:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=pEVAFV/zgNrpBYMUtYEwajnMithYluuHD1s/RHO3NSE=; b=DEAmqhKNAJZZeX cqxzawt/Rj9CIXQU4oavzASKZpRhOCdYvW2ICs5kk668IyUymiQ2c1MZzNSQcEe1YUcQwM1Y5pF4A AkA5h4oO7BdlUDkz4kEpKFiGu54dH8aLDqGKX0twORM2cAORqpwqb3x8gdbg0MakV0p0MTJjmuymA MHljOnhCXtSGshVEwAjxe3x+/7xqFeaBwU7i0yowaj1KAbx7e20AhL8mWaBhaEysYdejRXgybP3W1 SScp0u7ouJbogCNsiUWlbt0jSCy/i/7m4OhRoKtVlghMTl9J4xiV//2qDifYaqbA1NF589YgN2JlL QrPD90QuDbBPJkzrlopQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqVLt-006W0d-4S; Mon, 16 May 2022 07:41:13 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqVLq-006Vza-O3 for linux-arm-kernel@lists.infradead.org; Mon, 16 May 2022 07:41:11 +0000 Received: by mail-pj1-x102c.google.com with SMTP id ds11so2112460pjb.0 for ; Mon, 16 May 2022 00:41:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zv3IxfM9rqsBN5giYrSVliQlXB5yWJw2YJUUlPgHgY0=; b=KIkAtTgwPJvQoPRr9kQ1tZV/jSmVC6GHNojs95fbMqX43hgUvjQWWZOS9+8+ZGBfWO OhVjk5d6YCV+uouSxT1R+5DnYjyBpfgExMMczeeDVuMuQhsuEQZb7e4gTzztpnf6fjDL 34cC8mthpS7+5hLRZGFcSPXogWc9ceMjqDHSPuRII6IkFArZRMGIGbZQertEZYAUEnU6 G/kQShRY/7XBpLH57e6ZCkbN2VQpW8EnpTg2gEcjXk4qxFPAK1hF6w9ISXDpC7jDSYcJ Nh79hC9zAUp0pK604fL34fe84p18BzkAlkbv2QvseTctH8DF7Ebq0aUXDPRtVzYkN95B JCkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zv3IxfM9rqsBN5giYrSVliQlXB5yWJw2YJUUlPgHgY0=; b=k4SxZaKEj5tM38FaiLEMtmydEveAnk7spCSeK+ZvC9EHVmeZLYGvw1/YEKPd1FXO2D wJF2gVoWPBxmXvhoxmZd/DJ8HVKZA9+4qJed2iAowaNaXNjnT/N7DX++NOr00WjM0hfN 2zeTv8jk4eCBLyYvTOh5wp+001vuoicHigzfswyBsbme/w3ySVGYyVbELbXn6Wo9AeNH 3znGX3lF03IC9egDPOzgo2mreI3pnw0OeNE/V5ZQuwPBX1dtbpf+ksS+bdc/CccKtYXb 0vdMKwuoRTJxRJqbOCHPbVGhwXfRELj2l2YljlDzqgMe4YZyNmcGZL4l0TU9//ZqvAvV yg5A== X-Gm-Message-State: AOAM533NgthGC/2utaOIfUzFF6EgV2T1iDpHDgPI3Y6J6e3CPIGhkzdD 6h8TZkgscLbmHAeFktDmUGN8OQqO+usURR1T X-Google-Smtp-Source: ABdhPJxRzUTJ5CbOjcZmRtE5V/PlMxtaQrKw43ndH8TAqTmZnio7gI8cDrdKjb+E+wlB30I3g0/9lg== X-Received: by 2002:a17:902:e747:b0:161:822b:5fa9 with SMTP id p7-20020a170902e74700b00161822b5fa9mr2961831plf.8.1652686868992; Mon, 16 May 2022 00:41:08 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id q11-20020a056a00150b00b0050dc76281d9sm5698833pfu.179.2022.05.16.00.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 00:41:08 -0700 (PDT) From: Miaoqian Lin To: Nishanth Menon , Santosh Shilimkar , Keerthy , Tony Lindgren , Dave Gerlach , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: linmq006@gmail.com Subject: [PATCH] soc: ti: pm33xx: Fix refcount leak in am33xx_pm_rtc_setup Date: Mon, 16 May 2022 11:41:00 +0400 Message-Id: <20220516074100.30599-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_004110_824212_B2A016D7 X-CRM114-Status: GOOD ( 13.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_node_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 5a99ae0092fe ("soc: ti: pm33xx: AM437X: Add rtc_only with ddr in self-refresh support") Signed-off-by: Miaoqian Lin --- drivers/soc/ti/pm33xx.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/soc/ti/pm33xx.c b/drivers/soc/ti/pm33xx.c index 7bab4bbaf02d..b4d6e6ad85f4 100644 --- a/drivers/soc/ti/pm33xx.c +++ b/drivers/soc/ti/pm33xx.c @@ -445,8 +445,10 @@ static int am33xx_pm_rtc_setup(void) if (of_device_is_available(np)) { /* RTC interconnect target module clock */ rtc_fck = of_clk_get_by_name(np->parent, "fck"); - if (IS_ERR(rtc_fck)) - return PTR_ERR(rtc_fck); + if (IS_ERR(rtc_fck)) { + error = PTR_ERR(rtc_fck); + goto err_node_put; + } rtc_base_virt = of_iomap(np, 0); if (!rtc_base_virt) { @@ -479,6 +481,7 @@ static int am33xx_pm_rtc_setup(void) } else { pr_warn("PM: no-rtc available, rtc-only mode disabled.\n"); } + of_node_put(np); return 0; @@ -486,7 +489,8 @@ static int am33xx_pm_rtc_setup(void) iounmap(rtc_base_virt); err_clk_put: clk_put(rtc_fck); - +err_node_put: + of_node_put(np); return error; }