From patchwork Tue May 17 11:07:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 12852294 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CA54C433F5 for ; Tue, 17 May 2022 11:09:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sq2eiLuVCChXOcMV+jl6WNYbqMT2Q2o47YaeoL4ShZA=; b=cmmqXZ4Mga6wpE r4iXMviSIVb/iek5uWGoAgpXw7Qd0v4hCfRyUsDd6udAtltFNG7XeNbYdFUT5PD3EalAwRODODr6G TX44c5sC0ZYTyp/7gxJcurfpcKAx4EHlUTpaa4XOZnW303M3sTRad+wsswdxKvrdh2K2bpeRgRLyD mmKEVp/ci2gmEfjUsfBF93c0c590FZ7HIeVcqnUfEwBSVFTqP27s1qXQu0gBd1S+g95beprNlQQKG tyzv4Ghn5koddTl2AbUIF0qGES2VF1FfuiFdi32Ed6z8GDJAbssXQZaq3gGRjhLpYqPU1zYEPUmiu zHSq83/hG0shr7zryQJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqv3i-00DHPR-1M; Tue, 17 May 2022 11:08:10 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqv3e-00DHMO-Fk for linux-arm-kernel@lists.infradead.org; Tue, 17 May 2022 11:08:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652785686; x=1684321686; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9slmVJB08S/xmRyUkvYJ6Tki39bkbQlupsPD2XkQ7Yw=; b=JPvRh9Nn/hCSlo/ERF7fbs3ZJf1cq/dd11bLSG8SuR8XvGvzwPtYd0t+ lFDEWzaYQIQZVKbgtT0WQE6b3GgAfBavaETbK0+UuSjdSbF3WtpKUmTqQ qMFyf5pMldY2TFWXNiYL9mNQw0bu62R28oq+abosNrI7pmNs/KGxoqWF+ bUwZqGzx54o5SpNkxoHobxFN89eCJnTvczwgbLd1mj688d1yesnWNoJSC 45F/zmqvu+sSJ3r87RmsLUXNubqOWATfu9y9rG/20fQW0xkOSrdbPYAPW NTtziz2M7MEVkA1RPFk9pSy0toLDTDQ7p5eqefj+/K7BMCVKdTY3vXCpS w==; X-IronPort-AV: E=McAfee;i="6400,9594,10349"; a="269969378" X-IronPort-AV: E=Sophos;i="5.91,232,1647327600"; d="scan'208";a="269969378" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 04:08:01 -0700 X-IronPort-AV: E=Sophos;i="5.91,232,1647327600"; d="scan'208";a="568830955" Received: from mtarral-mobl.ger.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.252.52.88]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 04:07:58 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: linux-serial@vger.kernel.org, Greg KH , Jiri Slaby , Baruch Siach , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH 2/9] serial: digicolor-usart: Don't allow CS5-6 Date: Tue, 17 May 2022 14:07:30 +0300 Message-Id: <20220517110737.37148-3-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220517110737.37148-1-ilpo.jarvinen@linux.intel.com> References: <20220517110737.37148-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_040806_587442_9A3E52DE X-CRM114-Status: UNSURE ( 9.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Only CS7 and CS8 seem supported but CSIZE is not sanitized to CS8 in the default: block. Set CSIZE correctly so that userspace knows the effective value. Incorrect CSIZE also results in miscalculation of the frame bits in tty_get_char_size() or in its predecessor where the roughly the same code is directly within uart_update_timeout(). Cc: Baruch Siach Fixes: 5930cb3511df (serial: driver for Conexant Digicolor USART) Signed-off-by: Ilpo Järvinen Acked-by: Baruch Siach --- drivers/tty/serial/digicolor-usart.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/digicolor-usart.c b/drivers/tty/serial/digicolor-usart.c index 6d70fea76bb3..65e653eb5026 100644 --- a/drivers/tty/serial/digicolor-usart.c +++ b/drivers/tty/serial/digicolor-usart.c @@ -309,6 +309,8 @@ static void digicolor_uart_set_termios(struct uart_port *port, case CS8: default: config |= UA_CONFIG_CHAR_LEN; + termios->c_cflag &= ~CSIZE; + termios->c_cflag |= CS8; break; }