Message ID | 20220517111710.37753-1-linmq006@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A15E8C433EF for <linux-arm-kernel@archiver.kernel.org>; Tue, 17 May 2022 11:18:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Dxcf4pYAXA4f/vVUtkMWrL/3MfNtqW9jBvAXufE7k/U=; b=qlkU3UvqA0FlfZ RWd7fX2PpV+1c2Pracj3tGg/PHA8rsZLie8Gn49icR3LZC10kVSTZOXu2ICEpB3UxEXzoiXxHGAWj VKWio+6zpulnloqjQaRpWg261uMZeELSqjMm2kqbXmiiONQH2K4MM5+GT6/ee2ZBDZJctkW88FIys NFAdL0zTq97OLEboVkLxTlREaRFgfaZO51yMuAr2IJdY7BHFRYMnsQ+WtxWBVzTHO5UWeq2siFIr4 Mgt+S7EYLu8CHFot+mu8uHm8fltCu6BXtoQKLdkZ9WumBBZx+tvxUvq50vfUdq1GA13ebp82u/XCX zoOASE+FTH2fwr0G8PwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqvCf-00DL7K-Ou; Tue, 17 May 2022 11:17:25 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqvCc-00DL6Z-D4 for linux-arm-kernel@lists.infradead.org; Tue, 17 May 2022 11:17:23 +0000 Received: by mail-pf1-x42b.google.com with SMTP id k16so9827625pff.5 for <linux-arm-kernel@lists.infradead.org>; Tue, 17 May 2022 04:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3He5zqQafCaqxIZZoOREzUNxsIzRMeOPPdePDkzSSxg=; b=qiKm1mbardgIojujIEXZig/+qJiCfV5w3aki/6jtJF49OSvbAvTeya8kkPRO3xQZXo SZfsaP2xwY3T+dbidEWwbVJjQTGHKqsR1Pn0ZsNBHdAiBYW107qT/z9cV6KyVaKCy/a2 muO3OlKawuiRWJ7Iu2SuOk8wjw8fLi2M1XizS0MWZZT4J7HleJ4nlw3C6A3x5VX1TQeu RPPUKACz1ByBMGjQrMVgvKSHUpLc/POEtjr4WpHIt8Sk/AgS1AYACUGiDYs4Y5Al7pCk K8AMNJRjsnutWKKzmG3llFcMjxGwCLikuBDWFBcg6VEq92wHeLgi1ye77RVwC98uO8WJ Q8PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3He5zqQafCaqxIZZoOREzUNxsIzRMeOPPdePDkzSSxg=; b=wLg+vGKvx4ZKjg4hVLy2x68PgVRdsgg7HH0gNDgwD66A4XNd2q/Av98p/vSf9iTVgK RQTO8hydqWJieyQdr+Pm6fdaN528E+5cGxRVwa8USsF1T8gBKCXn7XWK9KKjo9noA+/7 1r4DdO77JprVT4aiu8hIMGwBgnEMkFynyTTXqQZFdJlMmikLyfT5SDCNrQ0zH3oiTFjm QfV1jo1kKpYMCzIS3O7VckUxnIM4OE1u5ET7QcEj88NOGlSLMK4OgekTjuUmcAjUhWIu bBR6Kb//hgx9Tq/OPfmItZ2M/h6o//shyHNp0UvC7XG/pQD9k9ty2VyPxPVxKGPObM8Y A+7A== X-Gm-Message-State: AOAM530EyjZ1zAyKVJmiR7r/5P+D52Gt99fSx4wj2/G4YZd9AknmCb53 UlZDlTeXUk4jMDI2Yi3uu+Q= X-Google-Smtp-Source: ABdhPJxiX2+4JCzqJi4lQkLBZjwoKutGXIxRhWZ5Awu1vC+sL4AHnlsvrnw3OzuvWGorZf8YwuII4w== X-Received: by 2002:aa7:9557:0:b0:50d:b868:4798 with SMTP id w23-20020aa79557000000b0050db8684798mr22212636pfq.84.1652786239205; Tue, 17 May 2022 04:17:19 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id n11-20020a170902f60b00b0015ec71f72d6sm8800503plg.253.2022.05.17.04.17.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 04:17:18 -0700 (PDT) From: Miaoqian Lin <linmq006@gmail.com> To: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>, Alyssa Rosenzweig <alyssa@rosenzweig.io>, Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] irqchip/apple-aic: Fix refcount leak in build_fiq_affinity Date: Tue, 17 May 2022 15:17:09 +0400 Message-Id: <20220517111710.37753-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_041722_476875_08F58B61 X-CRM114-Status: GOOD ( 11.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
irqchip/apple-aic: Fix refcount leak in build_fiq_affinity
|
expand
|
diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c index 12dd48727a15..478d0af16d9f 100644 --- a/drivers/irqchip/irq-apple-aic.c +++ b/drivers/irqchip/irq-apple-aic.c @@ -1035,6 +1035,7 @@ static void build_fiq_affinity(struct aic_irq_chip *ic, struct device_node *aff) continue; cpu = of_cpu_node_to_id(cpu_node); + of_node_put(cpu_node); if (WARN_ON(cpu < 0)) continue;
of_find_node_by_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: a5e8801202b3 ("irqchip/apple-aic: Parse FIQ affinities from device-tree") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/irqchip/irq-apple-aic.c | 1 + 1 file changed, 1 insertion(+)