arm: dts: imx6ulz-bsh-smm-m2: Support proper board power off

Commit Message

Michael Nazzareno Trimarchi May 17, 2022, 1:35 p.m. UTC

From: Simon Holesch <[e-mail]>

Supports initiating poweroff on SNVS_PMIC_ON_REQ signal.

Signed-off-by: Simon Holesch <[e-mail]>
---
 arch/arm/boot/dts/imx6ulz-bsh-smm-m2.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Fabio Estevam May 17, 2022, 1:41 p.m. UTC | #1

Hi Michael,

On 17/05/2022 10:35, Michael Trimarchi wrote:
> From: Simon Holesch <[e-mail]>
> 
> Supports initiating poweroff on SNVS_PMIC_ON_REQ signal.
> 
> Signed-off-by: Simon Holesch <[e-mail]>

You missed your own Signed-off-by tag here.

Michael Nazzareno Trimarchi May 17, 2022, 1:44 p.m. UTC | #2

Hi Fabio

On Tue, May 17, 2022 at 3:41 PM Fabio Estevam <[e-mail]> wrote:
>
> Hi Michael,
>
> On 17/05/2022 10:35, Michael Trimarchi wrote:
> > From: Simon Holesch <[e-mail]>
> >
> > Supports initiating poweroff on SNVS_PMIC_ON_REQ signal.
> >
> > Signed-off-by: Simon Holesch <[e-mail]>
>
> You missed your own Signed-off-by tag here.

It's fine, I can add Tested-by: Michael Trimarchi <[e-mail]>

Michael

Fabio Estevam May 17, 2022, 1:50 p.m. UTC | #3

Hi Michael,

On 17/05/2022 10:44, Michael Nazzareno Trimarchi wrote:

>> You missed your own Signed-off-by tag here.
> 
> It's fine, I can add Tested-by: Michael Trimarchi 
> <[e-mail]>

If you are transmitting someone else's patch, then you need to add
your own Signed-off-by to it.

This is explained in Documentation/process/submitting-patches.rst:

"Any further SoBs (Signed-off-by:'s) following the author's SoB are from
people handling and transporting the patch, but were not involved in its
development. SoB chains should reflect the **real** route a patch took
as it was propagated to the maintainers and ultimately to Linus, with
the first SoB entry signalling primary authorship of a single author."

Michael Nazzareno Trimarchi May 17, 2022, 1:54 p.m. UTC | #4

Hi

On Tue, May 17, 2022 at 3:50 PM Fabio Estevam <[e-mail]> wrote:
>
> Hi Michael,
>
> On 17/05/2022 10:44, Michael Nazzareno Trimarchi wrote:
>
> >> You missed your own Signed-off-by tag here.
> >
> > It's fine, I can add Tested-by: Michael Trimarchi
> > <[e-mail]>
>
> If you are transmitting someone else's patch, then you need to add
> your own Signed-off-by to it.
>
> This is explained in Documentation/process/submitting-patches.rst:
>
> "Any further SoBs (Signed-off-by:'s) following the author's SoB are from
> people handling and transporting the patch, but were not involved in its
> development. SoB chains should reflect the **real** route a patch took
> as it was propagated to the maintainers and ultimately to Linus, with
> the first SoB entry signalling primary authorship of a single author."

Done, thank you

Michael

Patch

diff --git a/arch/arm/boot/dts/imx6ulz-bsh-smm-m2.dts b/arch/arm/boot/dts/imx6ulz-bsh-smm-m2.dts
index 59bcfc9a6b10..c92e4e2f6ab9 100644
--- a/arch/arm/boot/dts/imx6ulz-bsh-smm-m2.dts
+++ b/arch/arm/boot/dts/imx6ulz-bsh-smm-m2.dts
@@ -29,6 +29,10 @@  &gpmi {
 	status = "okay";
 };
 
+&snvs_poweroff {
+	status = "okay";
+};
+
 &uart3 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart3>;