From patchwork Sat May 21 19:07:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 12857996 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7657DC433F5 for ; Sat, 21 May 2022 19:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=9njnXFEmAqXhee49C1zKWlq5O18KLZv9W/JhQsQtjlc=; b=TxN8QH/+zbSSe9 BVjjBM0Wg4nI0dBgtBtkHDnDKKvKB0ihu6JBFnfi+s5Q1h0pfb0MYXMm5h8tXjIXUVw239uWA9P3H jH30ThZlEXb7PmCmw1Y5W+FhfmUd/v5d9LPzyTrmDtfUKmvER9FCgjAioYpGHLcHEVtkKiCVifLY5 DsEbNjCdvKHm11ngti4aBnh+xAYQbZyCv0kmi2SSGckgKPi3Wwinyd8D2zdll2B5cCrnS9abGtifQ 4S/di8SdhyayzZ507TmRlfvBKKQVaRrwwuDhU/blEFBNfmCRRIGEAGbMF0h1WqJLXRE9ISHZlTuGw dpWKBA18vEPIA6j9rQHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsUS0-00HIxk-44; Sat, 21 May 2022 19:07:44 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsURw-00HIx8-PI for linux-arm-kernel@lists.infradead.org; Sat, 21 May 2022 19:07:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653160059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Wjy70z3rYdJmy6N/G7PkmPiJBr+st53+xede1hwp8ZM=; b=S4Nni5PB/ocQmpjCOa+bPRdYscUkeyzRKu5HHEaYALG7LRRdF7E9JUh9qE7JsDtxBi7Eap V5CZhDXO5NsHz8As5ezX0ha/0XM/Xg9oVQODtoq39IsPrjtFkN0eU5HB6SwffvqI8I+Y21 BuqDhjt2StlTqmNVvojr1khIzK14Juw= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-458-KRqvki5eNSOsUDCc-hXlUQ-1; Sat, 21 May 2022 15:07:36 -0400 X-MC-Unique: KRqvki5eNSOsUDCc-hXlUQ-1 Received: by mail-ot1-f70.google.com with SMTP id 104-20020a9d0bf1000000b0060aee3fc1a9so1585180oth.19 for ; Sat, 21 May 2022 12:07:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Wjy70z3rYdJmy6N/G7PkmPiJBr+st53+xede1hwp8ZM=; b=648JPv+6iqKd+P6sOGPx+E4J1TRy4c0c6lN4hkm/gjLrOviSO5FZulfHdbJungzepe +5dCeN7amMpRTWxnHwCnQZySjaMCa1N/63M2Nu8WHKmfOC+45ceaM42xC1qP8oy6rwnq m3fYWBwWomoqVN8hgZGUD/epf9AuY+Cz4IEyDTndX3UbISJvbdIgtMasY6njJF6MNV4j tF0V2+EuzmKgbDLzfWo/1G5cBZ4vkpLkk/CGhi87WqKCXkHGewSYrt+jdUZsoKCq+VOO weZ97TLpg6RjIBPXTp8Nj4o3xDAurucTk7jPxn7EG+EEN2nHH2yBZ1/RRJJzJ0zdTUQZ Eomw== X-Gm-Message-State: AOAM532f6/aIdzsDodo+SsKyNMoCq3S3WZyCfDUd20hQ9UD74IwYk74z mjotvCv+pXJUEgk/kJQW4QLoitrvxPJn6aKkeINCst4kWUrEkMqJ/reTa5zoCrmhO+KPxz4kdAX 6cgxsXstUkJrybT8FH0SKAW2unxqAFqXpHz0= X-Received: by 2002:a4a:d40d:0:b0:33a:33be:9c1e with SMTP id n13-20020a4ad40d000000b0033a33be9c1emr6340067oos.96.1653160056074; Sat, 21 May 2022 12:07:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQFuSj7FFYoeGmIJnrtvUhAvMCbQ7XefIximmy8LWnPFdHFdaJq2T5go68pyrOKFdwywHEYg== X-Received: by 2002:a4a:d40d:0:b0:33a:33be:9c1e with SMTP id n13-20020a4ad40d000000b0033a33be9c1emr6340058oos.96.1653160055856; Sat, 21 May 2022 12:07:35 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id q203-20020aca5cd4000000b00326cb6225f8sm2495564oib.44.2022.05.21.12.07.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 May 2022 12:07:35 -0700 (PDT) From: Tom Rix To: hjc@rock-chips.com, heiko@sntech.de, airlied@linux.ie, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] drm/rockchip: remove vop_writel Date: Sat, 21 May 2022 15:07:16 -0400 Message-Id: <20220521190716.1936193-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220521_120740_972313_65B0EFB5 X-CRM114-Status: UNSURE ( 9.42 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org cppcheck reports [drivers/gpu/drm/rockchip/rockchip_drm_vop.c:186]: (style) The function 'vop_writel' is never used. vop_writel is static function that is not used, so remove it. Signed-off-by: Tom Rix --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 74562d40f639..d1026e78feff 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -183,12 +183,6 @@ struct vop { struct vop_win win[]; }; -static inline void vop_writel(struct vop *vop, uint32_t offset, uint32_t v) -{ - writel(v, vop->regs + offset); - vop->regsbak[offset >> 2] = v; -} - static inline uint32_t vop_readl(struct vop *vop, uint32_t offset) { return readl(vop->regs + offset);