From patchwork Mon May 23 14:10:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12859115 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A614C433FE for ; Mon, 23 May 2022 14:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=wOmLvPRQnAcLK/wXjSMYex2QnIKVEvXtSiPzF/IUR0k=; b=dVGXZ8gl/svnbe AUXOSy/HTJPwvfPLU4KucrFitU0jLySzXZMTpE/gRvclxpMUCEo+Tg3XUSBGOIi+KUIlxjpkmTpTG IAYP0UAu8qxbly1LoxM/0XzusUR39jvunQ7dtRC03E1MGz6aDu6WOBc4Md5d7SkC0VYnLafQNZpuD P5+e/taM05Bt96ZWjgJTT9VweuAQ1/29UYBRqz2kgD9QjGZlUaPziQjzJcU4lNPc+MbVDlfVqcnpN GebXrfOO6EimKhCCWmMl9PuRGtqUBVpwzDz5GEDyOPiH7kRpRlIRkPB8TVvrvzeGdne6akDbHsL11 0EVu2fKtnmwcoP/+S3Ow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt8lK-004eeH-JA; Mon, 23 May 2022 14:10:22 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt8lH-004ed7-Ho for linux-arm-kernel@lists.infradead.org; Mon, 23 May 2022 14:10:20 +0000 Received: by mail-pj1-x1029.google.com with SMTP id ob14-20020a17090b390e00b001dff2a43f8cso56039pjb.1 for ; Mon, 23 May 2022 07:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=R3RSpzzzY3JZZbYrwfIv8X7HA01iUXqRO11CiRRnNTA=; b=CCaXciB0HrPIfHW4OYFfp8Xu+XcV8jkOLQieBcUvCvw8ktgh5+W7sS5XCmfgoOqJvA FUdVGvohBwrH3OxvN/j1TSAbchsq5yCUjHPRuQcKBR8FVsN2+G2ZamzujfGCBiM4WgB4 HhhJ1XuXymf7noXgUUUr6Acs81sv4GIJWCbN/SoEwti9MLDODJT2GGX2JVsB9XWLgA7t usBMPdNt083prkxSZaF6Y1BkfuQPQz0SKOUGTIGPM8YMXmlkw4L1hBjlkIxKT0+6z4U6 Awn37ymRsYTm0+R4subOFSdGXLv9ETh+rqKAhZq9/mehFGeO8g27zTnKeDWaa7nCTmlx 1Rlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=R3RSpzzzY3JZZbYrwfIv8X7HA01iUXqRO11CiRRnNTA=; b=kIHyzun/Yp3G6PTc3MmuDQTm9SwivCi9Hgb/sMw2IyPBnSNXZi+zv6pj8cHot/9Cb8 9sIa7RWdjumiFbMbszgn2/L0kIb8gpQK5pgD75zeV3IFrAFobS/sFcXLS9Sjs+48DLb1 wTs37o6oyDPt+lZm3fOUA/dMFh0IVPxRPKkOFqeTBwmvkXhzUwTIYrXIFPh+FFWVWDGD Vel5Py2w+HjC++4wuuO59KkMfzCkn+b4CJly8Kj9gslkPFGeT4filmw46o6eO7Ss4X2/ y4rHvOw1/+2phDF4RMeKaYoVVpkqRGMKS4v3V5Fua12lSGiICmc5e99LlmoRJzGUyD3Y Mi0A== X-Gm-Message-State: AOAM531ruWPy4KswQ4SqRrWyV90r97KBt6MpC/1KrglXEK2CGBfPIiZV KmmDVJ3cGAkPufh/GcJF+W8= X-Google-Smtp-Source: ABdhPJwnwzZ247rGnWWT561/VOBtHcUhdKJaqnbkD3UvumIf37wGGxc3SxdbdgOwKLJor6GuR3pLNw== X-Received: by 2002:a17:902:a517:b0:161:e5f2:9a26 with SMTP id s23-20020a170902a51700b00161e5f29a26mr19611785plq.132.1653315017546; Mon, 23 May 2022 07:10:17 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id jb11-20020a17090b408b00b001dcf9fe5cddsm7225190pjb.38.2022.05.23.07.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 07:10:17 -0700 (PDT) From: Miaoqian Lin To: Linus Walleij , Sebastian Reichel , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] power/reset: arm-versatile: Fix refcount leak in versatile_reboot_probe Date: Mon, 23 May 2022 18:10:09 +0400 Message-Id: <20220523141009.52965-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220523_071019_622859_C106DEBE X-CRM114-Status: GOOD ( 12.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_matching_node_and_match() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 0e545f57b708 ("power: reset: driver for the Versatile syscon reboot") Signed-off-by: Miaoqian Lin Reviewed-by: Linus Walleij --- drivers/power/reset/arm-versatile-reboot.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/power/reset/arm-versatile-reboot.c b/drivers/power/reset/arm-versatile-reboot.c index 08d0a07b58ef..c7624d7611a7 100644 --- a/drivers/power/reset/arm-versatile-reboot.c +++ b/drivers/power/reset/arm-versatile-reboot.c @@ -146,6 +146,7 @@ static int __init versatile_reboot_probe(void) versatile_reboot_type = (enum versatile_reboot)reboot_id->data; syscon_regmap = syscon_node_to_regmap(np); + of_node_put(np); if (IS_ERR(syscon_regmap)) return PTR_ERR(syscon_regmap);