| Message ID | 20220525155714.1837360-2-nfraprado@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MT8192 pinctrl properties adjustments | expand |
On Wed, 25 May 2022 11:57:13 -0400, Nícolas F. R. A. Prado wrote: > Commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic > PIN_CONFIG_DRIVE_STRENGTH_UA") added support for using > drive-strength-microamp instead of mediatek,drive-strength-adv. > > Since there aren't any users of mediatek,drive-strength-adv on mt8192 > yet, remove this property and add drive-strength-microamp in its place, > which has a clearer meaning. > > Fixes: 4ac68333ff6d ("dt-bindings: pinctrl: mt8192: Add mediatek,drive-strength-adv property") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > --- > > .../bindings/pinctrl/pinctrl-mt8192.yaml | 27 ++----------------- > 1 file changed, 2 insertions(+), 25 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
Il 25/05/22 17:57, Nícolas F. R. A. Prado ha scritto: > Commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic > PIN_CONFIG_DRIVE_STRENGTH_UA") added support for using > drive-strength-microamp instead of mediatek,drive-strength-adv. > > Since there aren't any users of mediatek,drive-strength-adv on mt8192 > yet, remove this property and add drive-strength-microamp in its place, > which has a clearer meaning. > > Fixes: 4ac68333ff6d ("dt-bindings: pinctrl: mt8192: Add mediatek,drive-strength-adv property") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogiocchino.delregno@collabora.com>
On Wed, May 25, 2022 at 11:58 PM Nícolas F. R. A. Prado <nfraprado@collabora.com> wrote: > > Commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic > PIN_CONFIG_DRIVE_STRENGTH_UA") added support for using > drive-strength-microamp instead of mediatek,drive-strength-adv. > > Since there aren't any users of mediatek,drive-strength-adv on mt8192 > yet, remove this property and add drive-strength-microamp in its place, > which has a clearer meaning. Cool! Thanks for taking care of this~ I was looking at this and tried to make drive-strength and drive-strength-microamp mutually exclusive, but since they are optional, it didn't really work, and I put it on the back burner. ChenYu
On Mon, May 30, 2022 at 04:48:51PM +0800, Chen-Yu Tsai wrote: > On Wed, May 25, 2022 at 11:58 PM Nícolas F. R. A. Prado > <nfraprado@collabora.com> wrote: > > > > Commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic > > PIN_CONFIG_DRIVE_STRENGTH_UA") added support for using > > drive-strength-microamp instead of mediatek,drive-strength-adv. > > > > Since there aren't any users of mediatek,drive-strength-adv on mt8192 > > yet, remove this property and add drive-strength-microamp in its place, > > which has a clearer meaning. > > Cool! Thanks for taking care of this~ I was looking at this and tried > to make drive-strength and drive-strength-microamp mutually exclusive, > but since they are optional, it didn't really work, and I put it on the > back burner. I didn't think of enforcing the properties to be mutually exclusive in the dt-binding, but that is indeed a good idea. After a bit of head-scratching seems like it is possible although unintuitive (by using 'required' inside the if block). I'll send a v2 with this restriction added, and the same thing for patch 2, since bias-pull-up/down also shouldn't be used together with bias-disable. Thanks, Nícolas > > > ChenYu
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml index c90a132fbc79..8ede8b750237 100644 --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml @@ -80,31 +80,8 @@ patternProperties: dt-bindings/pinctrl/mt65xx.h. It can only support 2/4/6/8/10/12/14/16mA in mt8192. enum: [2, 4, 6, 8, 10, 12, 14, 16] - mediatek,drive-strength-adv: - description: | - Describe the specific driving setup property. - For I2C pins, the existing generic driving setup can only support - 2/4/6/8/10/12/14/16mA driving. But in specific driving setup, they - can support 0.125/0.25/0.5/1mA adjustment. If we enable specific - driving setup, the existing generic setup will be disabled. - The specific driving setup is controlled by E1E0EN. - When E1=0/E0=0, the strength is 0.125mA. - When E1=0/E0=1, the strength is 0.25mA. - When E1=1/E0=0, the strength is 0.5mA. - When E1=1/E0=1, the strength is 1mA. - EN is used to enable or disable the specific driving setup. - Valid arguments are described as below: - 0: (E1, E0, EN) = (0, 0, 0) - 1: (E1, E0, EN) = (0, 0, 1) - 2: (E1, E0, EN) = (0, 1, 0) - 3: (E1, E0, EN) = (0, 1, 1) - 4: (E1, E0, EN) = (1, 0, 0) - 5: (E1, E0, EN) = (1, 0, 1) - 6: (E1, E0, EN) = (1, 1, 0) - 7: (E1, E0, EN) = (1, 1, 1) - So the valid arguments are from 0 to 7. - $ref: /schemas/types.yaml#/definitions/uint32 - enum: [0, 1, 2, 3, 4, 5, 6, 7] + drive-strength-microamp: + enum: [125, 250, 500, 1000] mediatek,pull-up-adv: description: |
Commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic PIN_CONFIG_DRIVE_STRENGTH_UA") added support for using drive-strength-microamp instead of mediatek,drive-strength-adv. Since there aren't any users of mediatek,drive-strength-adv on mt8192 yet, remove this property and add drive-strength-microamp in its place, which has a clearer meaning. Fixes: 4ac68333ff6d ("dt-bindings: pinctrl: mt8192: Add mediatek,drive-strength-adv property") Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- .../bindings/pinctrl/pinctrl-mt8192.yaml | 27 ++----------------- 1 file changed, 2 insertions(+), 25 deletions(-)