From patchwork Thu May 26 07:53:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12862052 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55CAAC433EF for ; Thu, 26 May 2022 07:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=sA4WVrUZG8ciTYJuPlctCZCKwvlzuCm4wZdXkde3Y5Q=; b=z5NQx1XkF0UY+I WngkhsoeYS3KHDwyMuY+TL8w56GZHG8/b02tLvYl9Jl39k/65C8jEGYbMSVKqxjiFReFg8VTv0iwR 6CxAo2wfhI83uPRQdyFZRDj9Sw9kivlHRYfX7jDkAT/QZAz0uNbwBkeAvNPLiVc51PA83SF6aeStq hPRJGAOesXfTgQGR+zhCl8i/ZOQU08F6ZDg6LB2Ow17VTE//yqJb0e0ph4hkt2ybKaTG+NZavyL/x wj3bDHrxgCNJLw/ZisyyJhccLFApRQ5JOkTyphLWUU7yPvolrdX9P+2cTOmNJt2rTLARoPiPLYnWS E2xs1v8nsB9pIF1aPevA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nu8JP-00DuZj-9u; Thu, 26 May 2022 07:53:39 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nu8JM-00DuYs-5s for linux-arm-kernel@lists.infradead.org; Thu, 26 May 2022 07:53:37 +0000 Received: by mail-pj1-x102c.google.com with SMTP id n10so1096763pjh.5 for ; Thu, 26 May 2022 00:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=FKY1rhZkdMBMrUZfIZycOdY5avxDQ/iGSLMXJ6LNb9Y=; b=cOnZJZkCCOkLxMjqnILedHexQv4MnUbOCfd5g4h+kDF3L/Noq+vogXEzH2Qq8dsCHe FMsx5MJc5GUVWNVZv5ZxpforSlgXZ0RE3SLShVOWJomcSaSzExdB5rzk2u2vddlbpFG6 PMBIXaPc+HXXJvFcEAjUQ8UG3JoJaUtzqC1Ks3Nh0dbLVT1YSqpK9cxf6LDRFfPHJOV0 m0gkVelPUPm2YjYbDrQFQCRHYOVnARIGpwzbIMPmYbRbltnIxliimz36f3/YTcuTLGPX jcUGEM+njcXYJDAYRvGEH44cP8lOYBqnVEQ+64hJugvXNwp8OZaikuSAm3a4VAA5xjC+ lewA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=FKY1rhZkdMBMrUZfIZycOdY5avxDQ/iGSLMXJ6LNb9Y=; b=dcZHFI547OeutqMr1OM7bZZTPeNHm08RIvesqHsdx/bPtx8QMntVOwqVfXcXmug9Pl x7j/m+K4NVWSaoxTx6qFIOZiXEIQRX/KV56+Y6S5rdCuM2uA/ACEXW2edH49qEvWv8Qy 20IyacAxcqvSxLzQhLqgDeTTUMeQ0BH9OEtf9geRDleMNfXmCoGOCx6/RLsPNqcJU8JR zhKespacfwA1YCJFvG8kfKu5FP6X1p0yY0dWbaQfwna314d2fPcSqi2jlsAVsQoHiT9W WZZTsG6h4EuzjQ5iKlvxLc3OxvGE4d4cOGOGdo9ZTgpie3yoLcPtQJ4PesNX64YJ4yzy GqFw== X-Gm-Message-State: AOAM533sd/9u2GW/ZrU1l2WGamw0sl3NJTcnGDHBIp+pgqrmLN/nbeeq lB5B+uKq8n0oWAcyDif+Lu4= X-Google-Smtp-Source: ABdhPJxqBIu27yeZ8CeO+ejoJRAiquRkOF+CBgzynV7NDz/kiHon6lkshbFEPrrujS/uC6pdXy7keA== X-Received: by 2002:a17:902:ce8f:b0:162:1aa9:f543 with SMTP id f15-20020a170902ce8f00b001621aa9f543mr21167302plg.123.1653551615494; Thu, 26 May 2022 00:53:35 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id q20-20020a170902789400b0015eaa9aee50sm747028pll.202.2022.05.26.00.53.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 00:53:35 -0700 (PDT) From: Miaoqian Lin To: Florian Fainelli , Broadcom Kernel Team , Andrew Morton , Thomas Bogendoerfer , Kees Cook , Helge Deller , Bjorn Andersson , Andy Shevchenko , Miaoqian Lin , Gareth Powell , Brian Norris , Doug Berger , Justin Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] soc: bcm: brcmstb: pm: pm-arm: Fix refcount leak in brcmstb_pm_probe Date: Thu, 26 May 2022 11:53:22 +0400 Message-Id: <20220526075325.27356-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220526_005336_255701_8259F500 X-CRM114-Status: GOOD ( 13.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. In brcmstb_init_sram, it pass dn to of_address_to_resource(), of_address_to_resource() will call of_find_device_by_node() to take reference, so we should release the reference returned by of_find_matching_node(). Fixes: 0b741b8234c8 ("soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM)") Signed-off-by: Miaoqian Lin Reviewed-by: Andy Shevchenko --- drivers/soc/bcm/brcmstb/pm/pm-arm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/bcm/brcmstb/pm/pm-arm.c b/drivers/soc/bcm/brcmstb/pm/pm-arm.c index 3cbb165d6e30..70ad0f3dce28 100644 --- a/drivers/soc/bcm/brcmstb/pm/pm-arm.c +++ b/drivers/soc/bcm/brcmstb/pm/pm-arm.c @@ -783,6 +783,7 @@ static int brcmstb_pm_probe(struct platform_device *pdev) } ret = brcmstb_init_sram(dn); + of_node_put(dn); if (ret) { pr_err("error setting up SRAM for PM\n"); return ret;