| Message ID | 20220531121913.48722-2-chanho61.park@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | support secondary ufs for Exynos Auto v9 SoC | expand |
On 31/05/2022 14:19, Chanho Park wrote: > To support secondary ufs phy devices, we need to get an offset value > from pmu-syscon. > > Signed-off-by: Chanho Park <chanho61.park@samsung.com> > --- > .../devicetree/bindings/phy/samsung,ufs-phy.yaml | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > index f6ed1a005e7a..80c3ec14375a 100644 > --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > @@ -40,9 +40,14 @@ properties: > - const: tx0_symbol_clk > > samsung,pmu-syscon: > - $ref: '/schemas/types.yaml#/definitions/phandle' > - description: phandle for PMU system controller interface, used to > - control pmu registers bits for ufs m-phy > + $ref: '/schemas/types.yaml#/definitions/phandle-array' > + items: > + - items: > + - description: phandle for PMU system controller interface, used to > + control pmu registers bits for ufs m-phy Wrong indentation. > + - description: offset of pmu control register for ufs m-phy > + description: > + can be phandle/offset pair. The offset can be optional. You made offset required, not optional. You need minItems:1 on the level of second "items". > > required: > - "#phy-cells" > @@ -63,7 +68,7 @@ examples: > compatible = "samsung,exynos7-ufs-phy"; > reg = <0x15571800 0x240>; > reg-names = "phy-pma"; > - samsung,pmu-syscon = <&pmu_system_controller>; > + samsung,pmu-syscon = <&pmu_system_controller 0x720>; > #phy-cells = <0>; > clocks = <&clock_fsys1 SCLK_COMBO_PHY_EMBEDDED_26M>, > <&clock_fsys1 PHYCLK_UFS20_RX1_SYMBOL_USER>, Best regards, Krzysztof
On Tue, 31 May 2022 21:19:10 +0900, Chanho Park wrote: > To support secondary ufs phy devices, we need to get an offset value > from pmu-syscon. > > Signed-off-by: Chanho Park <chanho61.park@samsung.com> > --- > .../devicetree/bindings/phy/samsung,ufs-phy.yaml | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml:46:9: [warning] wrong indentation: expected 10 but found 8 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
> > + items: > > + - items: > > + - description: phandle for PMU system controller interface, used > to > > + control pmu registers bits for ufs m-phy > > Wrong indentation. This will be fixed on the next patchset. > > > + - description: offset of pmu control register for ufs m-phy > > + description: > > + can be phandle/offset pair. The offset can be optional. > > You made offset required, not optional. You need minItems:1 on the level > of second "items". Thanks. I didn't know how I make such that.. I'll apply this to next patchset. > > > > > required: > > - "#phy-cells" > > @@ -63,7 +68,7 @@ examples: > > compatible = "samsung,exynos7-ufs-phy"; > > reg = <0x15571800 0x240>; > > reg-names = "phy-pma"; > > - samsung,pmu-syscon = <&pmu_system_controller>; > > + samsung,pmu-syscon = <&pmu_system_controller 0x720>; This will be dropped as well. Best Regards, Chanho Park
diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml index f6ed1a005e7a..80c3ec14375a 100644 --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml @@ -40,9 +40,14 @@ properties: - const: tx0_symbol_clk samsung,pmu-syscon: - $ref: '/schemas/types.yaml#/definitions/phandle' - description: phandle for PMU system controller interface, used to - control pmu registers bits for ufs m-phy + $ref: '/schemas/types.yaml#/definitions/phandle-array' + items: + - items: + - description: phandle for PMU system controller interface, used to + control pmu registers bits for ufs m-phy + - description: offset of pmu control register for ufs m-phy + description: + can be phandle/offset pair. The offset can be optional. required: - "#phy-cells" @@ -63,7 +68,7 @@ examples: compatible = "samsung,exynos7-ufs-phy"; reg = <0x15571800 0x240>; reg-names = "phy-pma"; - samsung,pmu-syscon = <&pmu_system_controller>; + samsung,pmu-syscon = <&pmu_system_controller 0x720>; #phy-cells = <0>; clocks = <&clock_fsys1 SCLK_COMBO_PHY_EMBEDDED_26M>, <&clock_fsys1 PHYCLK_UFS20_RX1_SYMBOL_USER>,
To support secondary ufs phy devices, we need to get an offset value from pmu-syscon. Signed-off-by: Chanho Park <chanho61.park@samsung.com> --- .../devicetree/bindings/phy/samsung,ufs-phy.yaml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)