From patchwork Wed Jun 1 08:09:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12866480 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E7E2C433EF for ; Wed, 1 Jun 2022 08:12:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KzsTmMnjkRNenpJAoQm+imezKGlTL9O9oBvKbqzn504=; b=zDtJYs+0Ul4CRz ZrSFQ1uLa6VlHsr4DvzxRoMy1X0scVbsRGiFvy0TqG4SP/kU26vuiAem/sJbhJin/YpmMx3fPhJC4 X0fu57slPr3i6UZ3vZB3fBu4EfmmBJeluf7CX+h4Yj+QIWI76a/yoE0t9M+2sUvYR2abeh0+hc+04 gSbbs3EBekpiNjyT0KnS0pRBPDLR/CDZA9/ypdRe5J6+xzlZDjqOuXQjFeKH/g/QdEtw95JwmH116 2qKFOiibE7yWKL2/rDrt19Fj1WqGR+D88W1el8U2wNhZ9EUAnQRvm6Z6MXcI9atZttX6BLMquVMir duoQIliDImg5Qh4DaR1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJS6-00EXlH-7H; Wed, 01 Jun 2022 08:11:38 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJS1-00EXjp-EF for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 08:11:34 +0000 Received: by mail-pl1-x636.google.com with SMTP id i1so1081299plg.7 for ; Wed, 01 Jun 2022 01:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Px54YeB8y4JCFlFNgwFGWbi1FoMMkCqF3KundDZ3EiM=; b=M8QTLybUaNBk1aN+aW6WTC6oMiD4gHTGH1IngOQcZXfUt6/9wkK5VwiDq6/TgBjLAi VVsj1zx/ZRNW6HwMWapL1em5dRTDFO1BdGM4XJEzdGl465emrnSipiJlkXL99sIWN7qI 9CSmCdLCdbtaS5kOdWFVaX+dXjXQFG3VInPenaz9FVnGInt6sogEJ3OUq9UKXKTUi8Tg y3iCO9U3saux5xWEPNNxjZUTr3CRhtjY9lza1ynF5mNDhIArJKqHuSDLhxPIyjv8C8Q+ tVZdl1wi9BZZSp8Cv+flw3+ENseAF/nVTGBzMznepyaQD+/Awxu8IeXC1MK+Dka/qAib EvnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Px54YeB8y4JCFlFNgwFGWbi1FoMMkCqF3KundDZ3EiM=; b=Nc8UuNF0fGSO3X1pZCkg1FV0H/2vOfSY9e6X4dX8Wp6iT74+Qu6OSfaSEbojhjXiJG VCUqBkBfYDjIqiCw+RdsagkZVSlj/e2DkvNOVcBIs+Gvvt7XGspwbc65jZR2AtULljIP KiJwkEbVzXJZn7xj0MFgUT8X1JkomXwm/6BIRavGKKtbChHO9uL5CJwgIPjUEfgq9CH+ XkuqNb+KBbxpVKH67mvuMKw6ysd62l/RxTsifhj8w/8OKaHu1YLbD5Pufd1BcGQG9uS4 yvK/U1oX5zaTs0+c5W5BGH/JomdSMCKWm38+O+Bpj2wKrOAjYslwaMmvK4ieG589eyuG uVwg== X-Gm-Message-State: AOAM531UgfXpN0x21K1FXWrTwy4Nbmn9JzEtsnjfalpsUAPTw2MobrM0 et8vL/xDGov1ONa2bP/Fqv0= X-Google-Smtp-Source: ABdhPJzG3vlU3jO48Ym1PPOrpdAe+gZj7tJD29o/oekC+E8060IQUrfmuoDVjXjxS3qI7mfLWO385Q== X-Received: by 2002:a17:902:690b:b0:159:65c:9044 with SMTP id j11-20020a170902690b00b00159065c9044mr66244014plk.47.1654071090228; Wed, 01 Jun 2022 01:11:30 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id y1-20020a17090ad0c100b001e2f3831102sm792288pjw.17.2022.06.01.01.11.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 01:11:29 -0700 (PDT) From: Miaoqian Lin To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Thomas Gleixner , Marc Zyngier , Linus Walleij , Birger Koblitz , John Crispin , Bert Vermeulen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Miaoqian Lin Subject: [PATCH 1/6] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init Date: Wed, 1 Jun 2022 12:09:25 +0400 Message-Id: <20220601080930.31005-2-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220601080930.31005-1-linmq006@gmail.com> References: <20220601080930.31005-1-linmq006@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_011133_517092_87A22938 X-CRM114-Status: GOOD ( 13.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_matching_node_and_match() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants") Signed-off-by: Miaoqian Lin --- drivers/irqchip/irq-gic-realview.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-gic-realview.c b/drivers/irqchip/irq-gic-realview.c index b4c1924f0255..38fab02ffe9d 100644 --- a/drivers/irqchip/irq-gic-realview.c +++ b/drivers/irqchip/irq-gic-realview.c @@ -57,6 +57,7 @@ realview_gic_of_init(struct device_node *node, struct device_node *parent) /* The PB11MPCore GIC needs to be configured in the syscon */ map = syscon_node_to_regmap(np); + of_node_put(np); if (!IS_ERR(map)) { /* new irq mode with no DCC */ regmap_write(map, REALVIEW_SYS_LOCK_OFFSET,