From patchwork Thu Jun 2 12:50:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12867830 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35503C43334 for ; Thu, 2 Jun 2022 12:51:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=8RBIy/gGCPWpQyOr9EJosae+VnoTPgMxOaIMQWPLwYo=; b=LplkZaMRs46E2l 9Utbdcp660HAppqx0fkHBx/REbmvbns6b873pDwcUYteCZXm1cvZkC2faYS48nDiun0Ve7FsVbora 7lRXZqlspn48PYo7i8P+1MWgpcWIj52xzVgMDGfQPB5a1+M9lySUiMDYIP8pIYU8QTopd6cmy6SDg /x38bFA58K4uqDwTpKrfWPwfWOA7Yg3/5+OMtpZ3wo8+OFgUG8FuEXDzj6uAIei4s6u+qktBWkAat tGERXLXclJ6IZPcP4HKpb8eEdNfPXKdlYGqQYuKzcqcr/w/yKgGY/uqxdpMeGDUKS7Xdj5jxvuxtW J+gZNTeUu6DuptFCpKiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwkHL-003Gnu-Cm; Thu, 02 Jun 2022 12:50:19 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwkHH-003Gmm-2S; Thu, 02 Jun 2022 12:50:16 +0000 Received: by mail-pj1-x102c.google.com with SMTP id gd1so4852798pjb.2; Thu, 02 Jun 2022 05:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kcZmoDNkypwVXAUGHN+8MXLjQTBcIwGXqyPCDHsu1M0=; b=kpVZpW9n9dbKqWRHDXzfVLoSjAdUYchpilbWAnfoSAcUlK+dSDFLQ+Vtf4qyy19tfY GSPyJIxmj+urIEtCa8WMmrJ8f4r0SlPLCQ9YnvFoWgJ8dLDoQ3T0vnXYRoS4JzZr4t+2 I80dzyJG5TC/KAy9AII28TcnUb9IcbEaz2MYARNdo60J0P0xZz6nb4caD1ihsGIwb126 xaEU9lVdNBkZad7j5nn59k/jg4AOyrgeEXz1bPGEW1AsAzG8JuE7KXbyMuR/YMB+BfRI a6v63NoTwxvDhMmq0BcOPNY3ckQjEqmLr2XVtTOrJoGDp/ZrCSZbA9T6ZAuQIEaoGQUr 6jnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kcZmoDNkypwVXAUGHN+8MXLjQTBcIwGXqyPCDHsu1M0=; b=ub0IWTivS8jCv2GwRxYryBvehaCZ+aFNDsC+JZO2Y8N0IR4Udm07jz1L/u7tB9jadi YkB6MCws/Fel4C8eUU8OGeaLzhN1w17M4RGG4SEYMutkBs3r2n5Qjmf939tMN1mHETtj Obpq5PoNw77GNdetNbTNJLclvuxMSeXL+L/2mtVVVI/k052BHq7ErBj3oIgJOSN4Ra5b rfw7ZJR2g4X7hWazTrz2XKaVOIMMeBdgvURysR3GR1qTK1GEeVerN+giJ8IK61uB7vF4 EApHjPoz9zDV+Rj2Si8b5qZhzLYq1kHxHxNfmyNWKdTYAPejAd8C5S6iIGIKOuXeBLaa 9WMQ== X-Gm-Message-State: AOAM533nb0devsAcqb99gDOmfOpy72ldLcHICGRUEuyt6lXfLxuhnsdU 4lBk4IVOP0+lIQsLWQ3CtyY= X-Google-Smtp-Source: ABdhPJwDj60u40yHeOaBRKIgUx6FsuYrv4FjYePtp/TN3VzzNi90RvcmoTsOqA5IAnuznJgiiMtgXg== X-Received: by 2002:a17:902:6e01:b0:164:27c:1135 with SMTP id u1-20020a1709026e0100b00164027c1135mr4810408plk.8.1654174213729; Thu, 02 Jun 2022 05:50:13 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id ju10-20020a17090b20ca00b001df264610c4sm2849408pjb.0.2022.06.02.05.50.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jun 2022 05:50:13 -0700 (PDT) From: Miaoqian Lin To: Nicolas Saenz Julienne , Broadcom internal kernel review list , Jim Quinlan , Florian Fainelli , Lorenzo Pieralisi , Rob Herring , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] PCI: brcmstb: Fix refcount leak in brcm_pcie_probe Date: Thu, 2 Jun 2022 16:50:02 +0400 Message-Id: <20220602125003.10723-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220602_055015_148318_0D596ED6 X-CRM114-Status: GOOD ( 10.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: format:40ca1bf580ef ("PCI: brcmstb: Add MSI support") Signed-off-by: Miaoqian Lin --- drivers/pci/controller/pcie-brcmstb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 375c0c40bbf8..e3b673441a11 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1597,8 +1597,10 @@ static int brcm_pcie_probe(struct platform_device *pdev) ret = brcm_pcie_enable_msi(pcie); if (ret) { dev_err(pcie->dev, "probe of internal MSI failed"); + of_node_put(msi_np); goto fail; } + of_node_put(msi_np); } bridge->ops = pcie->type == BCM7425 ? &brcm_pcie_ops32 : &brcm_pcie_ops;