| Message ID | 20220603094422.2112746-2-l.goehrs@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: dts: stm32: fix missing internally connected voltage regulator for OSD32MP1 | expand |
On 03.06.22 11:44, Leonard Göhrs wrote: > According to the OSD32MP1 Power System overview[1] the EEPROM is connected to > the VDD line and not to some single-purpose fixed regulator. > Set the EEPROM supply according to the diagram to eliminate this parent-less > regulator. > > [1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections > > Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de> Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Thanks, Ahmad > --- > arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi > index e997c4953fd1..935b7084b5a2 100644 > --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi > +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi > @@ -50,12 +50,6 @@ retram: retram@38000000 { > no-map; > }; > }; > - > - reg_sip_eeprom: regulator_eeprom { > - compatible = "regulator-fixed"; > - regulator-name = "sip_eeprom"; > - regulator-always-on; > - }; > }; > > &i2c4 { > @@ -204,7 +198,7 @@ pmic_watchdog: watchdog { > > sip_eeprom: eeprom@50 { > compatible = "atmel,24c32"; > - vcc-supply = <®_sip_eeprom>; > + vcc-supply = <&vdd>; > reg = <0x50>; > }; > };
Hi On 6/3/22 11:44, Leonard Göhrs wrote: > According to the OSD32MP1 Power System overview[1] the EEPROM is connected to > the VDD line and not to some single-purpose fixed regulator. > Set the EEPROM supply according to the diagram to eliminate this parent-less > regulator. > > [1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections > > Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de> > --- > arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi > index e997c4953fd1..935b7084b5a2 100644 > --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi > +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi > @@ -50,12 +50,6 @@ retram: retram@38000000 { > no-map; > }; > }; > - > - reg_sip_eeprom: regulator_eeprom { > - compatible = "regulator-fixed"; > - regulator-name = "sip_eeprom"; > - regulator-always-on; > - }; > }; > > &i2c4 { > @@ -204,7 +198,7 @@ pmic_watchdog: watchdog { > > sip_eeprom: eeprom@50 { > compatible = "atmel,24c32"; > - vcc-supply = <®_sip_eeprom>; > + vcc-supply = <&vdd>; > reg = <0x50>; > }; > }; Applied on stm32-next. Thanks. Alex
diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi index e997c4953fd1..935b7084b5a2 100644 --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi @@ -50,12 +50,6 @@ retram: retram@38000000 { no-map; }; }; - - reg_sip_eeprom: regulator_eeprom { - compatible = "regulator-fixed"; - regulator-name = "sip_eeprom"; - regulator-always-on; - }; }; &i2c4 { @@ -204,7 +198,7 @@ pmic_watchdog: watchdog { sip_eeprom: eeprom@50 { compatible = "atmel,24c32"; - vcc-supply = <®_sip_eeprom>; + vcc-supply = <&vdd>; reg = <0x50>; }; };
According to the OSD32MP1 Power System overview[1] the EEPROM is connected to the VDD line and not to some single-purpose fixed regulator. Set the EEPROM supply according to the diagram to eliminate this parent-less regulator. [1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de> --- arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)