From patchwork Fri Jun 3 12:39:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12869040 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E981C43334 for ; Fri, 3 Jun 2022 12:40:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=8U+tyt0ySjA9i5kOp0hsr+m/LH7j4DhOaXkXqNYhnzs=; b=fy7bDa1Xg4hwfT AntAI8yb6aaAxFLIT+bDvvtXchTPBlnVBKNL0YcyiqyFZzkDKXA5Viomip7jf9MYdf2EfsdFCUewH NMrgnW5iltAaqiKHZQ59efmqKqzfLVnW2flrDUuWmRuiLd+KVhc7rg+mlIIThvb63Tf1u524exAeR OyVIBOHmmGgECbQR/GjblSj4WLQPN/0560WAtji529ajWfNwBZ59WSrVMbamyh5MhSj9WdTtUgXyp VnCAnr2K+U40yNQKwQDlUreI5F1j6/teY0giLQcQqHIIkrZZoHjbfDJdWUwM3f/UYqU96DyoqyBOi bWx5OwXfuFwu4y8sY8XA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nx6aF-007Skj-74; Fri, 03 Jun 2022 12:39:19 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nx6aC-007Sk9-EJ for linux-arm-kernel@lists.infradead.org; Fri, 03 Jun 2022 12:39:17 +0000 Received: by mail-pl1-x632.google.com with SMTP id i1so6758184plg.7 for ; Fri, 03 Jun 2022 05:39:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=WZeh6dPlumSxGZHW+VabBQeUNOylTh9kH627gkvPD+A=; b=Y007TVDTsVw2lMEBXkR/FDRNRV6iyelZ51Ogy3OHkyUxu5lyWsKT5NvAJWTmGx+5ku 7SPyy8Q9FvgqXHsRr3cqUCSu8P0sEmUphieQGMnAL4rwzKq1/T4o8SShk7nGIIuVIJ7s sAJk9SBu059Jsf3aZBF3WgzYewGjI/izch7jta9PIaaDYRVT6UjFIg59Z+5UdKL1n4Z3 o1RAhsDEs+moKuck8+3NPVgX1ag1oBcCxuxJU62Q+r8JbVAjV/qtCkNu2gSTr33n+QDj 5y8ZvVS/3Msue9oUKSevHa0iFV31Zdkhk/sAaYrGGFtJL/RWndHjEkXEn0sSba712JPq t08g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=WZeh6dPlumSxGZHW+VabBQeUNOylTh9kH627gkvPD+A=; b=g2337G5aTPOGOiXWw7Q8PbB0OLdzjviEy5FS1bCkqI4HI4lSWd6P8wW12ctdzbJiYJ C27fly6hVDNw/XQiHVTS5OOS5Ef9z33hxrUM1OYmSPS2tcqnvNh1nDm+qzNT9Q94fhuY 8RVka0j02dzTYWYtuucJxT9gkmCm7Qi6rIrl5YoyPtbPcFc6opa63mMdlDt6Xf1wfOC2 epJw6jkJg67l17VpnCAfFAIAQ6pM9d0PwZ1D1gMjqYdlkQI5BnkldSSN3shcU+LR25v+ dSJYCwVXJfYl0IVdYy6qWvyVMU14UtFdN2yLeWWhtdZea500Or9J3eH7Q0tPP1w+V7+p mRuw== X-Gm-Message-State: AOAM533DJQ7CxBpAInO/8fjj+5IuOSfn+qCJ9epczUMpW7EoUgizXjr6 yVoGYMGRcIC/defKgFeG434BrE84tURin8oQ8ts= X-Google-Smtp-Source: ABdhPJxTwFTdmtpYkEYSdKalAhQdMMJ2P6PK6DiB3tuvARtFEmIIk6ddSDvYnFSLZ94zcHu1HAEyVQ== X-Received: by 2002:a17:902:d592:b0:161:3bf4:9047 with SMTP id k18-20020a170902d59200b001613bf49047mr3355736plh.137.1654259954469; Fri, 03 Jun 2022 05:39:14 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id ju10-20020a17090b20ca00b001df264610c4sm5483212pjb.0.2022.06.03.05.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jun 2022 05:39:13 -0700 (PDT) From: Miaoqian Lin To: Joel Stanley , Andrew Jeffery , Chia-Wei Wang , Miaoqian Lin , Patrick Venture , Robert Lippert , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] soc: aspeed: Fix IRQ check in aspeed_lpc_snoop_config_irq Date: Fri, 3 Jun 2022 16:39:02 +0400 Message-Id: <20220603123904.30714-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220603_053916_518029_B070FC55 X-CRM114-Status: GOOD ( 13.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example: int irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; Fix the check of return value to catch errors correctly. Fixes: 9f4f9ae81d0a ("drivers/misc: add Aspeed LPC snoop driver") Signed-off-by: Miaoqian Lin Reviewed-by: Andrew Jeffery --- v1 Link: https://lore.kernel.org/r/20220114064357.18562-1-linmq006@gmail.com In previous v1 thread: Reviewed-by: Chia-Wei Wang Signed-off-by: Patrick Venture v2 Link: https://lore.kernel.org/r/20220603082336.3867-1-linmq006@gmail.com --- drivers/soc/aspeed/aspeed-lpc-snoop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/aspeed-lpc-snoop.c index eceeaf8dfbeb..c4a03b3a5cf8 100644 --- a/drivers/soc/aspeed/aspeed-lpc-snoop.c +++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c @@ -167,8 +167,8 @@ static int aspeed_lpc_snoop_config_irq(struct aspeed_lpc_snoop *lpc_snoop, int rc; lpc_snoop->irq = platform_get_irq(pdev, 0); - if (!lpc_snoop->irq) - return -ENODEV; + if (lpc_snoop->irq < 0) + return lpc_snoop->irq; rc = devm_request_irq(dev, lpc_snoop->irq, aspeed_lpc_snoop_irq, IRQF_SHARED,