From patchwork Fri Jun 3 14:02:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12869113 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 062BFC433EF for ; Fri, 3 Jun 2022 14:04:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=28awQZRoZfZXjboTiS/fBgfmxgDwkKzZzlnG2mtzR7s=; b=1XASIhmsh7sEGC BL+0LW3IbvoiXaLEXuiulwIDaoAShX1FAVNMvgcazpGSdn1TiHqrLy11TrU65aVuTGfEWuWW9tzAE UW4KVy9CqS9BGFu/hZhhpmYVeUbhGpcxH1PxQmoZWpZbkhTRYr9cADfDOoHZX4e1wt+3Uf8dQMzKd GGkRPqmrnmF7dJIk8ZppNkqUu4is8n/+b7BgiSwO+84vmL6Kml+BrxIkw8ahs4WB8hBcWLD79hv4w QneY6Ikg5aU+nXrbVUt8MLhuPFCRvGpxhHRl14DUsXH+UG09VPwLeT4d6FHq7fcnk2yptY9b1UWr2 pmDmcZwDbf3X9lLPOonA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nx7tF-007cAa-Uk; Fri, 03 Jun 2022 14:03:02 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nx7tC-007c8E-MM for linux-arm-kernel@lists.infradead.org; Fri, 03 Jun 2022 14:02:59 +0000 Received: by mail-pg1-x534.google.com with SMTP id r71so7323821pgr.0 for ; Fri, 03 Jun 2022 07:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=lISSvWak6FLRrO5psSLs6i76bhB1ZmPsSb/17A5+cjY=; b=hTSUCHd4eqE/1RDHL5S1oKpSN5h9bqgrO29tfXVGaKvp9x1/Z4ByT9XMzKKptzqGLY oyfY0K1HQZX2lVTpm57VOYoOoipmY+D536vd5rWWB9+5ew2w2modqlK6G4bT3y/GErbB qZ/KeSFbiQZra88y6VdoUUkkOAQBCCYBVh0nuvZ3N1v0IkBFz6xawSjJj7Zgb1obJ8V1 5qkoNXvybmeuS/QZwnjGcpYQ9TuVJlgnEm25XqK19WndRB4dIcJgZ6qEYrbcrAiw8OQ+ k/RQnYB44SZxrUuwbjif6AUTBco2HS7QNQR1N60WNVM4bLtpFzmJChEO7SqlRHZpHYp4 N55A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=lISSvWak6FLRrO5psSLs6i76bhB1ZmPsSb/17A5+cjY=; b=lvrxCXHHlExRyALW/xz0tHRdLjpdd8/BUFjA5Lk49NHRWuyUr1dQBTzwp27wkdtYEo sC1tSSz4FLVFj2kyXZsJNoheanMx1FY7M1eYWThXMVWP5b4g6TcW1xCshNsbVZj7Rp+t +N/pq1njBbOo/ZnCKL1qLYZJY+VGqcwenCdrY8MwCJCtFwPoZ0A5UcGJm3876IootbbU XU4gri6h4CydVav6LYADPL0asMRM/cHZzCVoJm7pH1uyS6iEfecACijgeirXHMiEnUca fz5UlthZtCIfxVYmexdx+SLIPRv2it+X9cl0bPmS6CVHC0fin6Z1i69TiRs27KfAad6I AkwA== X-Gm-Message-State: AOAM533VHRNepTay6RAUiu1EHhQoh4r3RVVuiYWfDdKHrIekC7Qc9xOR OwGks4cWxNgh27EMgs09JIA= X-Google-Smtp-Source: ABdhPJwF39VJUjteEaNSomtjgRS2NA4E8u+f699LKEL1nW4tuICTZMM2rpl0BX0JHb6OmDIb7bRmvw== X-Received: by 2002:a05:6a00:2396:b0:51b:de97:7efe with SMTP id f22-20020a056a00239600b0051bde977efemr4521830pfc.8.1654264976753; Fri, 03 Jun 2022 07:02:56 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id n36-20020a635924000000b003faebbb772esm5663265pgb.25.2022.06.03.07.02.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jun 2022 07:02:56 -0700 (PDT) From: Miaoqian Lin To: Felipe Balbi , Greg Kroah-Hartman , Vladimir Zapolskiy , Miaoqian Lin , Jakob Koschel , Arnd Bergmann , Roland Stigge , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: gadget: lpc32xx_udc: Fix refcount leak in lpc32xx_udc_probe Date: Fri, 3 Jun 2022 18:02:44 +0400 Message-Id: <20220603140246.64529-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220603_070258_806766_FB533E5E X-CRM114-Status: GOOD ( 12.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. of_node_put() will check NULL pointer. Fixes: 24a28e428351 ("USB: gadget driver for LPC32xx") Signed-off-by: Miaoqian Lin --- drivers/usb/gadget/udc/lpc32xx_udc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c index 6117ae8e7242..cea10cdb83ae 100644 --- a/drivers/usb/gadget/udc/lpc32xx_udc.c +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c @@ -3016,6 +3016,7 @@ static int lpc32xx_udc_probe(struct platform_device *pdev) } udc->isp1301_i2c_client = isp1301_get_client(isp1301_node); + of_node_put(isp1301_node); if (!udc->isp1301_i2c_client) { return -EPROBE_DEFER; }