From patchwork Sat Jun 4 04:28:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 12869558 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E43FCCCA484 for ; Sat, 4 Jun 2022 04:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=czOW8IJaehSo1EWfXr7QjgB0DGkt9KkTY8qpc+VU6NU=; b=0W54tx0F/ccj9W RShy2uD7UZO520Q6dDWINeC3avBxlkTJKfE5V5TxpVhgNVcG25i81XQkV0CoZK0oCtM7YriL9jC22 xHOn/67k5W+VF3Y+n5xwIoDixrT3MsFbxMSE9t9uwGAzpt774LYmgrKZnsRhOZhBJ2Hkte+0Rlgzm TanyRDwV0kUJqNvckSOa+GxaH4Rs3tD+q4bf189XXpbEAr1PSBqAwyRkrOBomzogwfrRR0gNu+1mP dnF/2rAv/1U6JOYbp2+5Tk15LUXzpffdp6h4dsSQgmppgmh5AGhJ8cI5IW6Ma29NLjcuFSqPldDSS DTEu+NfLlrqXf/NhHIlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxLPZ-00AE0O-Bm; Sat, 04 Jun 2022 04:29:17 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxLPJ-00ADvV-FJ for linux-arm-kernel@lists.infradead.org; Sat, 04 Jun 2022 04:29:02 +0000 Received: by mail-pf1-x42e.google.com with SMTP id e11so8558463pfj.5 for ; Fri, 03 Jun 2022 21:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Jgh8b65aqfDEBjEikwGcRqaRvkh9OcNpE8mI3ojB+kM=; b=eHTIYKX2niB3+hcP6wkl/Ab0BStnMoeg6znyPP0NaviP8TEk/n7XNEUbjNJHOoiV0n gJSIq3ZOnqSw54Nzk3eGDl9fjqiBsVuv+4wTU2DlZd3BrMMHTqzzlPldz5VKkmgHb+qr VEsXHpvbgSsRe+y+fQuiEPji+bh9d338QBs9CDUdFo7QI5wETtkfmjUUBV26AAceXmkt uazuORxQrtqXGo7ynlBx/2OC7eJX0vcjrQ61Z34G1PdzSuqGjf6CLdl7y+HwGhF/LMMa AQUrEADwLrrk3qDIBwGWyozxWRA8M+tCPmxMhOBea54xatxhUXFjlgSnlIPjQiCaQhn3 Rv9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Jgh8b65aqfDEBjEikwGcRqaRvkh9OcNpE8mI3ojB+kM=; b=Ng1BAOHwaCOJziEVgDWCLggjh4nvDJZ2NP6+iEmh6YmHXwWiOQPMQhzotnDwoBFnO7 0HkYB56VMMVg6tnlJvTt6slCbdOP6xXV8d7FCdOWxuBpfmzQKNBOXz/SpsO3r4GYG53w +kB7KG43W/e+qWEBHg4CZpDMsKx+OFWLNN7OHYftTqx8lXkSrPiMy5N3Wm7lMJE/WGVp z12o2sXy0Z1z2b+JMe8TosK7XCSLxCCMgv9si7lJtd5+MslK4YnU5KBjf1Kfqx4Tosmx rGVYHCrZ8RXJwxZa0zrLbuFdGtu7t+UXiX5usiA1vTeJlAqysHybQi42DLLVEyXPC/bw UmJA== X-Gm-Message-State: AOAM530Xss6DHoOnMs/vZQoP7n0/DBAnE27PbIsIsoAsyJuRqNRcfcUJ rjvznBlDy8cdXPVXMMbh7n6BqQ== X-Google-Smtp-Source: ABdhPJzAquLSZIkdXHtL/r22pGnyGKY54qLAVIemNxP5n+EXK/Qmnar4Uj4qudeFDUO32PighxLreA== X-Received: by 2002:a05:6a00:15cd:b0:51b:c838:127c with SMTP id o13-20020a056a0015cd00b0051bc838127cmr11301457pfu.30.1654316940169; Fri, 03 Jun 2022 21:29:00 -0700 (PDT) Received: from leo-build-box.lan (ec2-54-67-95-58.us-west-1.compute.amazonaws.com. [54.67.95.58]) by smtp.gmail.com with ESMTPSA id w24-20020a1709027b9800b00163d4c3ffabsm6152916pll.304.2022.06.03.21.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jun 2022 21:28:59 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Jiri Olsa , Namhyung Kim , Ian Rogers , John Garry , Will Deacon , James Clark , German Gomez , Ali Saidi , Joe Mario , Adam Li , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Leo Yan , Kajol Jain Subject: [PATCH v5 03/17] perf mem: Print snoop peer flag Date: Sat, 4 Jun 2022 12:28:06 +0800 Message-Id: <20220604042820.2270916-4-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220604042820.2270916-1-leo.yan@linaro.org> References: <20220604042820.2270916-1-leo.yan@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220603_212901_562943_99E2E97C X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since PERF_MEM_SNOOPX_PEER flag is a new snoop type, print this flag if it is set. Before: memstress 3603 [020] 122.463754: 1 l1d-miss: 8688000842 |OP LOAD|LVL L3 or L3 hit|SNP N/A|TLB Walker hit|LCK No|BLK N/A aaaac17c3e88 [unknown] (/home/ubuntu/memstress) memstress 3603 [020] 122.463754: 1 l1d-access: 8688000842 |OP LOAD|LVL L3 or L3 hit|SNP N/A|TLB Walker hit|LCK No|BLK N/A aaaac17c3e88 [unknown] (/home/ubuntu/memstress) memstress 3603 [020] 122.463754: 1 llc-miss: 8688000842 |OP LOAD|LVL L3 or L3 hit|SNP N/A|TLB Walker hit|LCK No|BLK N/A aaaac17c3e88 [unknown] (/home/ubuntu/memstress) memstress 3603 [020] 122.463754: 1 llc-access: 8688000842 |OP LOAD|LVL L3 or L3 hit|SNP N/A|TLB Walker hit|LCK No|BLK N/A aaaac17c3e88 [unknown] (/home/ubuntu/memstress) memstress 3603 [020] 122.463754: 1 tlb-access: 8688000842 |OP LOAD|LVL L3 or L3 hit|SNP N/A|TLB Walker hit|LCK No|BLK N/A aaaac17c3e88 [unknown] (/home/ubuntu/memstress) memstress 3603 [020] 122.463754: 1 memory: 8688000842 |OP LOAD|LVL L3 or L3 hit|SNP N/A|TLB Walker hit|LCK No|BLK N/A aaaac17c3e88 [unknown] (/home/ubuntu/memstress) After: memstress 3603 [020] 122.463754: 1 l1d-miss: 8688000842 |OP LOAD|LVL L3 or L3 hit|SNP Peer|TLB Walker hit|LCK No|BLK N/A aaaac17c3e88 [unknown] (/home/ubuntu/memstress) memstress 3603 [020] 122.463754: 1 l1d-access: 8688000842 |OP LOAD|LVL L3 or L3 hit|SNP Peer|TLB Walker hit|LCK No|BLK N/A aaaac17c3e88 [unknown] (/home/ubuntu/memstress) memstress 3603 [020] 122.463754: 1 llc-miss: 8688000842 |OP LOAD|LVL L3 or L3 hit|SNP Peer|TLB Walker hit|LCK No|BLK N/A aaaac17c3e88 [unknown] (/home/ubuntu/memstress) memstress 3603 [020] 122.463754: 1 llc-access: 8688000842 |OP LOAD|LVL L3 or L3 hit|SNP Peer|TLB Walker hit|LCK No|BLK N/A aaaac17c3e88 [unknown] (/home/ubuntu/memstress) memstress 3603 [020] 122.463754: 1 tlb-access: 8688000842 |OP LOAD|LVL L3 or L3 hit|SNP Peer|TLB Walker hit|LCK No|BLK N/A aaaac17c3e88 [unknown] (/home/ubuntu/memstress) memstress 3603 [020] 122.463754: 1 memory: 8688000842 |OP LOAD|LVL L3 or L3 hit|SNP Peer|TLB Walker hit|LCK No|BLK N/A aaaac17c3e88 [unknown] (/home/ubuntu/memstress) Signed-off-by: Leo Yan Reviewed-by: Ali Saidi Tested-by: Ali Saidi Reviewed-by: Kajol Jain --- tools/perf/util/mem-events.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c index c3c21a9c350b..5dca1882c284 100644 --- a/tools/perf/util/mem-events.c +++ b/tools/perf/util/mem-events.c @@ -410,6 +410,11 @@ static const char * const snoop_access[] = { "HitM", }; +static const char * const snoopx_access[] = { + "Fwd", + "Peer", +}; + int perf_mem__snp_scnprintf(char *out, size_t sz, struct mem_info *mem_info) { size_t i, l = 0; @@ -430,13 +435,20 @@ int perf_mem__snp_scnprintf(char *out, size_t sz, struct mem_info *mem_info) } l += scnprintf(out + l, sz - l, snoop_access[i]); } - if (mem_info && - (mem_info->data_src.mem_snoopx & PERF_MEM_SNOOPX_FWD)) { + + m = 0; + if (mem_info) + m = mem_info->data_src.mem_snoopx; + + for (i = 0; m && i < ARRAY_SIZE(snoopx_access); i++, m >>= 1) { + if (!(m & 0x1)) + continue; + if (l) { strcat(out, " or "); l += 4; } - l += scnprintf(out + l, sz - l, "Fwd"); + l += scnprintf(out + l, sz - l, snoopx_access[i]); } if (*out == '\0')