From patchwork Sun Jun 5 08:28:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12869731 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67B61C43334 for ; Sun, 5 Jun 2022 08:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=A/5Fdv1vVH67Q5h+qNGDtw18wgtG3zmeJsLr3iexMMk=; b=k7PQfvHI2T7siy upsX8u/F+F2yAqvaMJDAleL8wImLQZL1btIqajQlqBrylCPxtxsk5s9P3SgenC7v+vaDp4pcGJ0Bt myJp/FWBGJDisc7rzqhj3AwcQcmYE5oYA19+xb6/QE4FU5JONvr5FlCLM4EbknuVw6HQ6whoLiIdv F4IOgvpaZrY92Qjsbjy3T17662C4RFWFYSHTbuIrMhxZXucUFMF4o4qaLG4+nlV/1KNfA0VLkwAKg +MyIcV1R2tlAh/lJry8L8gm1tC4RZB5pjZG39/TWWs/R1VIO1uDldUxl/+ffHS471OZn6XVlubRm4 VlkZT7AJVCPONPvCWsrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxlcS-00DzRI-9I; Sun, 05 Jun 2022 08:28:20 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxlcP-00DzQZ-2Y for linux-arm-kernel@lists.infradead.org; Sun, 05 Jun 2022 08:28:18 +0000 Received: by mail-pl1-x629.google.com with SMTP id t2so9944679pld.4 for ; Sun, 05 Jun 2022 01:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5BhKZd1ZztUFuFtohu4ix955CtOvlBJ4OzYqsyB12K8=; b=doejqQpfz9ht/RQ+t1MfOyTZgVOi5NUVQwtmSNk3icJY41qCkgzM3wefT3Y0hwCIGs 6Go7a8QuyARo4srDXXsx824/KaEqFHz5CC2FQsOscnOpJZQ7LdwAVw9GYtldLunGpmQf nNP8EJkJUVNH5jhFO3GGZGkwVti36ZHnvmc1SYT4YOaF/QYAL+tL/5NYSc8qNrR44xZh KvU7474brhY19TEcrDdQ4SK04ewQ5SC7+SNtXm/TOh9qUlhXZz9FheHmuJb8+tB4m9/N HwGWG6f/aynWlwD5KdiF2pWS6AkaPtt4cxc0ME3KOTuzTtf+g0O9gN/3eSNaDWrwFz5k NDdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5BhKZd1ZztUFuFtohu4ix955CtOvlBJ4OzYqsyB12K8=; b=i1t/7tNBKT1GE5UvRRd5bFV7t9868HCO3SeIabFcF6TFQxLcl9XKspupnEthgI2TRu SgOHseyGfEsufvqtPza+byvjR0Lkvo7zJv8xYqiupQufRyQpilvTKUh1ZghJyq5eaHDO dlUKmHzfzzxp2U7PbR0WKFmvryuX3xNW7uehFKPquM+ZO/Bs+udBKg7ZS1NvNULe4M9S Cd7A67fXWjEApEPDU8Ha6b2wFefuA1vsW/833cNzMeBkdEO7gPwBSmT9wW4ww5EYKzAx IQQypNooJ0UC7JEoBZ5gI9DxZ4M3ScaGEOUiDPWD5z0TmwW6sRVnZiULQF49t46IAvs0 jRFA== X-Gm-Message-State: AOAM532fXFO0DjIzxtSgha99715kgArjnvtUyQlgL53W6Xjg2mhc6LsL /adQeTyXrJWaAS4EPhkFTU8= X-Google-Smtp-Source: ABdhPJz+77+w83gRA+JN7McpWBC+snx4VxJBfmCdhMazKDR29ry7zs/XkwDU9P9w8263YLVuHf7r+g== X-Received: by 2002:a17:902:e5ca:b0:164:1958:c84a with SMTP id u10-20020a170902e5ca00b001641958c84amr18409178plf.72.1654417696119; Sun, 05 Jun 2022 01:28:16 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id l24-20020a17090ac59800b001e25e3ba05csm12820399pjt.2.2022.06.05.01.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 01:28:15 -0700 (PDT) From: Miaoqian Lin To: Russell King , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] cpufreq: zynq: Fix refcount leak in zynq_get_revision Date: Sun, 5 Jun 2022 12:28:07 +0400 Message-Id: <20220605082807.21526-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220605_012817_174576_2A73E490 X-CRM114-Status: GOOD ( 11.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 00f7dc636366 ("ARM: zynq: Add support for SOC_BUS") Signed-off-by: Miaoqian Lin --- arch/arm/mach-zynq/common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c index e1ca6a5732d2..15e8a321a713 100644 --- a/arch/arm/mach-zynq/common.c +++ b/arch/arm/mach-zynq/common.c @@ -77,6 +77,7 @@ static int __init zynq_get_revision(void) } zynq_devcfg_base = of_iomap(np, 0); + of_node_put(np); if (!zynq_devcfg_base) { pr_err("%s: Unable to map I/O memory\n", __func__); return -1;