From patchwork Sun Jun 5 08:40:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12869734 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D66DC433EF for ; Sun, 5 Jun 2022 08:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=M/F8AWQGg6D9dhi95iZIAIsJnBts8dhY4INswht3Pyc=; b=zqw1xYs5XSgmi2 2BFjDF1azhlUeFAqFROfRpu+eBu/WdowrJXGssKqo6uW/Z3pUeJsj3H4Rfp8RTH1HfG+U5+P8xTDF 43t0uOKt1WBgK3QYsZ9Vyq1yVuJaSHXitMVmQZ/pXSdOI0d9zlIGzZm5AFMpZXtRwILnROc4QqfZA yXd5cr6IlfKs/vmcnBJlab98SnGhQqwQ5PGwGKwzeIPwIA3oXbjo7ir2HiQ44DkkGRDh3tsQi2neW ALpQvNitnValDxA2utxovrbUqkK7EcHVNaEeVygufeY5htEo3DpikzL1oJDs90QuTpQj7wcCJcQpV B1Hhq2z3nWbAEVS+Moig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxloZ-00E1DA-8e; Sun, 05 Jun 2022 08:40:51 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxloW-00E1Bw-BP for linux-arm-kernel@lists.infradead.org; Sun, 05 Jun 2022 08:40:49 +0000 Received: by mail-pg1-x531.google.com with SMTP id g186so1727373pgc.1 for ; Sun, 05 Jun 2022 01:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=aQpfNS+r3gvm5vQLoUP5fF1DHiiFVqBEBMp9DZpwHMg=; b=ByZRoM3j4iaoXqTKvHAn7fzsSjnQ8NhbYHK516s5FZMfOfWFv/TV0PfKtxGmIonTwB lTW2yqOaYYmzt0mgGeOiFrCczqJ7lPYyM4mQGCdE6r7bT0GjYrJiVDbOt4USH51kSu3Q shiGoqzAZ2wUOxdOSDY37JVQNRfrAkEQ0pkZO30C+4V9Kt4h4bJPDBAnvGXeCTTGeRYo q2qO5Ru+m4jav/aDxTUxiOXQg9eRGVcRuOw32UHyCOiKI/6eJQ0KkZJQlNmoxT6cQ92J 390OTsj2DFvHPznpgkBQk6b9FHUuCBr57ihuSojNrEXmFJGBJ+emd4eLLrfiQ/TFr62v z2Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=aQpfNS+r3gvm5vQLoUP5fF1DHiiFVqBEBMp9DZpwHMg=; b=fbyGP3ZzKX/6ie1JY+kHdPl6sTCBlHRommcdlYHgO0KINohyq2QxaKjnXyuwDGvnBc KJDowb3QBHs7T3Okl1mmRwXtiojRmhc/TKiIOpwzynoXV/0HyUzvK6pHx8ZkZ7eNWdk5 boa/Te1dnxKpv+ZBo3tWpisVnZNkNENk7AHYWr6o8TXsWrTTcG7+uYQbTUs2gIdKnvle lsildkkdJUKZVWq0Owh9dmbP8xQc5Pkpt5t0J91S11ioh2stI48ZyWg+b/Ipfs3a7NLX fKM7kEzW/QBMBl077d+RNDyLhsEkWAjBu1nyajRmcqu2gQl6zofuc881i+WvIYyBSv3s Tsvg== X-Gm-Message-State: AOAM531qsazdmZE34HTL8iLRUIZF2yAineKa15IfKXrv/z94F/1hy8ia GNMNkGUQBflqp08jmVqdnAw= X-Google-Smtp-Source: ABdhPJyblrAIpv56unO0ayEauib56A4SYuOB+hS7iEOJLLwveL/Fh3rQs1ouywo/o0gJirukRa6p+A== X-Received: by 2002:a62:de84:0:b0:51b:e34b:ed2e with SMTP id h126-20020a62de84000000b0051be34bed2emr10837648pfg.86.1654418446975; Sun, 05 Jun 2022 01:40:46 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id d15-20020aa797af000000b0051bbc198f3fsm7756810pfq.13.2022.06.05.01.40.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 01:40:46 -0700 (PDT) From: Miaoqian Lin To: Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Mihai Sain , Miaoqian Lin , Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] drivers: soc: atmel: Fix refcount leak in atmel_soc_device_init Date: Sun, 5 Jun 2022 12:40:32 +0400 Message-Id: <20220605084035.27127-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220605_014048_430327_E44C0EE0 X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_node_by_path() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 960ddf70cc11 ("drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs") Signed-off-by: Miaoqian Lin --- drivers/soc/atmel/soc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c index b2d365ae0282..46dfa24c52fb 100644 --- a/drivers/soc/atmel/soc.c +++ b/drivers/soc/atmel/soc.c @@ -369,10 +369,13 @@ static int __init atmel_soc_device_init(void) { struct device_node *np = of_find_node_by_path("/"); - if (!of_match_node(at91_soc_allowed_list, np)) + if (!of_match_node(at91_soc_allowed_list, np)) { + of_node_put(np); return 0; + } at91_soc_init(socs); + of_node_put(np); return 0; }