From patchwork Tue Jun 7 11:16:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12871756 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7198C43334 for ; Tue, 7 Jun 2022 11:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=yd54AmATb+Nmhzks/YJUZtvHofpJ3zVzyHHGJjp86/k=; b=GVUZ4Pis5nfgd3 vVbTGIY0b6OgsckzzQ2OKshSdwOkRRsXAPn8mXSS7V1JVzi8Om8fS1pvafmTrhb1WayL4v+ib4q+Z 0e6nC7tbCiTcZ9uz0ty+tefTg5+08nJ8oA4MFCWgJVWW7ICfrnL/fb89D9uqf2W2dbqTyUzVrdMqC VwCfK+7v78DYZwAXNz/NQZOt66m6a+VF6DbpLKBrKYMnSFdTrV0Y4ddl9YTGcrpdzCHGmT5uV+3gE V2srm2zJiIvHTuJs9P4u66NuE1KjDTCKDwJD4QkOXyvpwHQTLlbnOsBRwxdjGppXzM7jqGAw3/6Z3 KnshGVPF6PLs9gQ97zgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyXC3-006zRe-B3; Tue, 07 Jun 2022 11:16:15 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyXBz-006zQg-M7 for linux-arm-kernel@lists.infradead.org; Tue, 07 Jun 2022 11:16:12 +0000 Received: by mail-pj1-x1035.google.com with SMTP id k5-20020a17090a404500b001e8875e6242so4379752pjg.5 for ; Tue, 07 Jun 2022 04:16:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Eyn/86c6liF5nYWGh9VyLqwQursjArpq+vyMDFNlc6Q=; b=lJSgL87NXAVkX4HsOGSumdR1cCQzgHG+hwOLjOuEvSSOnDvzXbBcK1qSGnr85+iGiI sIemmp+Qo8//8HwMOpA8byQpBC8n0ahRFcl/w0Vd6zJLLg6ezB+SV0TqW42pCwF/+jxa cqVuV30rPHvPd0GRB/19ILrquvbkwVD71D0nNjPizXqG7OAN9u/+EAWtVXK21b6SOYT3 l+ID6KKwRS26/HRZWyAal5DWRW/PCPJQwrauv6xYY8AX1keacnmJL1BjkmNGaHpPfklu H6LX6NrnnDI+V9C5M1c/pSsbBIdsKTuXr4wi/yYGDbAGe/OgwEeAV9uQvqGxJiamR4fv +e6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Eyn/86c6liF5nYWGh9VyLqwQursjArpq+vyMDFNlc6Q=; b=jCjnxKG/SULMLGhNUdb30RJPutIfZx0tBxtdohGIIQTvxIlGyb/Jw8JqG1DlBIIxw+ 7jp3js8EH1C9ZiHtIvyAu8d/sEYxt4Ny+Oz+1AQb2T2J5pZjwOpEr0MZjckScVDWHTfX e9lbej6ufr7qA4fXWOxb3mKRFOcmNOB5hBhvVe587xZaROXuMUS7P7pa+UIqtcssjS/P 0reV2nAkvx5nMrjVPN7ZoY6+G6plfUzeZDKCmoT174SYuvoVLoAQWF6zKAuOK5qoYpHa KVM9APqgfGbw3tj8iJknSGLdW7h5cMduwmgkLucjtAeDC17l8zSZQmNPqufJsWmG3doQ 9kBg== X-Gm-Message-State: AOAM533YO1JIAdAjA1FIM7nZrudcmTkg3zuv47Gb/ZsWsvNWUQ9v3qS9 e+3tprgGar48zycnrkEqb6kpZ1XtPREXqzYD X-Google-Smtp-Source: ABdhPJwsbxOSKLJ4weNQQd1EOj/uVEtmK7CBrmp6IGxccZZprAYQAw0GhOvk6bxPGoX0hsxG+uJvqw== X-Received: by 2002:a17:902:f605:b0:14d:bd53:e2cd with SMTP id n5-20020a170902f60500b0014dbd53e2cdmr28383722plg.164.1654600570302; Tue, 07 Jun 2022 04:16:10 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id s23-20020a056a001c5700b0050dc762816fsm5213778pfw.73.2022.06.07.04.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 04:16:09 -0700 (PDT) From: Miaoqian Lin To: Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] pinctrl: nomadik: Fix refcount leak in nmk_pinctrl_dt_subnode_to_map Date: Tue, 7 Jun 2022 15:16:01 +0400 Message-Id: <20220607111602.57355-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220607_041611_762231_0CB58DCB X-CRM114-Status: GOOD ( 13.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak." Fixes: c2f6d059abfc ("pinctrl: nomadik: refactor DT parser to take two paths") Signed-off-by: Miaoqian Lin --- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c index 640e50d94f27..f5014d09d81a 100644 --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c @@ -1421,8 +1421,10 @@ static int nmk_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, has_config = nmk_pinctrl_dt_get_config(np, &configs); np_config = of_parse_phandle(np, "ste,config", 0); - if (np_config) + if (np_config) { has_config |= nmk_pinctrl_dt_get_config(np_config, &configs); + of_node_put(np_config); + } if (has_config) { const char *gpio_name; const char *pin;