diff mbox series

[v2,05/20] watchdog: npcm_wdt: Add NPCM845 watchdog support

Message ID 20220608095623.22327-6-tmaimon77@gmail.com (mailing list archive)
State New, archived
Headers show
Series Introduce Nuvoton Arbel NPCM8XX BMC SoC | expand

Commit Message

Tomer Maimon June 8, 2022, 9:56 a.m. UTC 
Add Nuvoton BMC NPCM845 watchdog support.
The NPCM845 uses the same watchdog as the NPCM750.

Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
 drivers/watchdog/npcm_wdt.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Arnd Bergmann June 8, 2022, 12:01 p.m. UTC | #1 
On Wed, Jun 8, 2022 at 11:56 AM Tomer Maimon <tmaimon77@gmail.com> wrote:
>
> Add Nuvoton BMC NPCM845 watchdog support.
> The NPCM845 uses the same watchdog as the NPCM750.
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>

This one should no longer be needed if the timers are compatible with the
old ones and correctly described in the DT.

      Arnd
Tomer Maimon June 16, 2022, 9:06 p.m. UTC | #2 
Hi Arnd,

On Wed, 8 Jun 2022 at 16:05, Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Wed, Jun 8, 2022 at 11:56 AM Tomer Maimon <tmaimon77@gmail.com> wrote:
> >
> > Add Nuvoton BMC NPCM845 watchdog support.
> > The NPCM845 uses the same watchdog as the NPCM750.
> >
> > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
>
> This one should no longer be needed if the timers are compatible with the
> old ones and correctly described in the DT.
by timers do you mean clocks?
>
>       Arnd

Best regards,

Tomer
Arnd Bergmann June 16, 2022, 9:11 p.m. UTC | #3 
On Thu, Jun 16, 2022 at 11:06 PM Tomer Maimon <tmaimon77@gmail.com> wrote:
> On Wed, 8 Jun 2022 at 16:05, Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > On Wed, Jun 8, 2022 at 11:56 AM Tomer Maimon <tmaimon77@gmail.com> wrote:
> > >
> > > Add Nuvoton BMC NPCM845 watchdog support.
> > > The NPCM845 uses the same watchdog as the NPCM750.
> > >
> > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> >
> > This one should no longer be needed if the timers are compatible with the
> > old ones and correctly described in the DT.
> by timers do you mean clocks?

Sorry, I mis-copied my comment. I meant the watchdog being compatible
with the old
version.

        Arnd
diff mbox series

Patch

diff --git a/drivers/watchdog/npcm_wdt.c b/drivers/watchdog/npcm_wdt.c
index 28a24caa2627..0b91a3fbec09 100644
--- a/drivers/watchdog/npcm_wdt.c
+++ b/drivers/watchdog/npcm_wdt.c
@@ -231,6 +231,7 @@  static int npcm_wdt_probe(struct platform_device *pdev)
 static const struct of_device_id npcm_wdt_match[] = {
 	{.compatible = "nuvoton,wpcm450-wdt"},
 	{.compatible = "nuvoton,npcm750-wdt"},
+	{.compatible = "nuvoton,npcm845-wdt"},
 	{},
 };
 MODULE_DEVICE_TABLE(of, npcm_wdt_match);