| Message ID | 20220615070813.7720-2-romain.perier@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add PWM for MStar SoCs | expand |
On 15/06/2022 08:08, Romain Perier wrote: > This adds the documentation for the devicetree bindings of the Mstar > MSC313e RTC driver, it includes MSC313e SoCs and SSD20xd. I figure the RTC is a copy paste error? > > Signed-off-by: Romain Perier <romain.perier@gmail.com> > --- > .../bindings/pwm/mstar,msc313e-pwm.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml b/Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml > new file mode 100644 > index 000000000000..82f2357db085 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/mstar,msc313e-pwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mstar MSC313e PWM controller > + > +allOf: > + - $ref: "pwm.yaml#" > + > +maintainers: > + - Daniel Palmer <daniel@0x0f.com> > + - Romain Perier <romain.perier@gmail.com> > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - mstar,msc313e-pwm > + - mstar,ssd20xd-pwm > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + "#pwm-cells": > + const: 2 > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + pwm: pwm@3400 { > + compatible = "mstar,msc313e-pwm"; > + reg = <0x3400 0x400>; > + #pwm-cells = <2>; > + clocks = <&xtal_div2>; > + };
On Wed, 15 Jun 2022 09:08:09 +0200, Romain Perier wrote: > This adds the documentation for the devicetree bindings of the Mstar > MSC313e RTC driver, it includes MSC313e SoCs and SSD20xd. > > Signed-off-by: Romain Perier <romain.perier@gmail.com> > --- > .../bindings/pwm/mstar,msc313e-pwm.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml:20:9: [warning] wrong indentation: expected 10 but found 8 (indentation) ./Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml:21:11: [warning] wrong indentation: expected 12 but found 10 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi, Le mer. 15 juin 2022 à 09:25, Conor Dooley <mail@conchuod.ie> a écrit : > > On 15/06/2022 08:08, Romain Perier wrote: > > This adds the documentation for the devicetree bindings of the Mstar > > MSC313e RTC driver, it includes MSC313e SoCs and SSD20xd. > > I figure the RTC is a copy paste error? Yes it is, whoops, I will fix it. Thanks, Romain
Hi, Le mer. 15 juin 2022 à 15:16, Rob Herring <robh@kernel.org> a écrit : > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > Mhhh, not sure to have yamllint, I will check it and fix it. Regards, Romain
On Wed, Jun 15, 2022 at 09:08:09AM +0200, Romain Perier wrote: > This adds the documentation for the devicetree bindings of the Mstar > MSC313e RTC driver, it includes MSC313e SoCs and SSD20xd. > > Signed-off-by: Romain Perier <romain.perier@gmail.com> > --- > .../bindings/pwm/mstar,msc313e-pwm.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml b/Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml > new file mode 100644 > index 000000000000..82f2357db085 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/mstar,msc313e-pwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mstar MSC313e PWM controller > + > +allOf: > + - $ref: "pwm.yaml#" > + > +maintainers: > + - Daniel Palmer <daniel@0x0f.com> > + - Romain Perier <romain.perier@gmail.com> > + > +properties: > + compatible: > + oneOf: Don't need oneOf with only 1 entry. > + - items: > + - enum: > + - mstar,msc313e-pwm > + - mstar,ssd20xd-pwm > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + "#pwm-cells": > + const: 2 > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + pwm: pwm@3400 { > + compatible = "mstar,msc313e-pwm"; > + reg = <0x3400 0x400>; > + #pwm-cells = <2>; > + clocks = <&xtal_div2>; > + }; > -- > 2.35.1 > >
diff --git a/Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml b/Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml new file mode 100644 index 000000000000..82f2357db085 --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/mstar,msc313e-pwm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mstar MSC313e PWM controller + +allOf: + - $ref: "pwm.yaml#" + +maintainers: + - Daniel Palmer <daniel@0x0f.com> + - Romain Perier <romain.perier@gmail.com> + +properties: + compatible: + oneOf: + - items: + - enum: + - mstar,msc313e-pwm + - mstar,ssd20xd-pwm + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + "#pwm-cells": + const: 2 + +required: + - compatible + - reg + - clocks + +additionalProperties: false + +examples: + - | + pwm: pwm@3400 { + compatible = "mstar,msc313e-pwm"; + reg = <0x3400 0x400>; + #pwm-cells = <2>; + clocks = <&xtal_div2>; + };
This adds the documentation for the devicetree bindings of the Mstar MSC313e RTC driver, it includes MSC313e SoCs and SSD20xd. Signed-off-by: Romain Perier <romain.perier@gmail.com> --- .../bindings/pwm/mstar,msc313e-pwm.yaml | 47 +++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml