From patchwork Tue Jun 21 09:18:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pin-yen Lin X-Patchwork-Id: 12888921 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF7E5C43334 for ; Tue, 21 Jun 2022 09:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=QLKuGbGDT7YKksdmytNyWSAKREEYqqGGT8r7yRxRd4I=; b=PIp1UkXfOGy+ls lcohk/a5J72yeDwZkxB7UC+Ig6qIsJbcH1uMwfGPDPLsUhBxAaH/UywBPKc47dNYXhRY/1YphLAB9 OFl1GtfegbDEpIQMZwcHvoZK2OYfdGK1sN8WcG8DXCiBLe/sZGukCDXKnLnOQhk9iOVldfyl3y1T6 4Jg0O7FrtI/VXvMZr6NFBMg7oGxYLwUkh+jw/bJA/8RNVBqtRcJvsCRf+8SobiHZt4jkk6MIEl84S /qKQD+nRH7bRW2l5BVDA6hPGstsBaoqzB3OcCBVv/hdcanyl8u4JB3ADXoZT3Xb13bNiw6eLzqGYd SR5oX6CfR02YLpwXTx0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3a2b-004aXU-6z; Tue, 21 Jun 2022 09:19:21 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3a2X-004aV4-DB for linux-arm-kernel@lists.infradead.org; Tue, 21 Jun 2022 09:19:18 +0000 Received: by mail-pj1-x1030.google.com with SMTP id k12-20020a17090a404c00b001eaabc1fe5dso13102266pjg.1 for ; Tue, 21 Jun 2022 02:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZvxtssIvtoFYupLWVv54BPyYcFNiA1KS9aQ8n/ctA2Q=; b=n3yhQ6//sI9yfp1kIIQmNjWtnyhxQuTa2xKTjM8m6xRI/oiBqkW31cHcqOC11Lhpqn ZR82ouc1zYSWgcx5ZRsGjxx4uU638SPXtbgBbBmzXY2S3rbqyJCOFiTQI7iNreAGmaCv jt/wSztc8LZ5TuZBgfzzKuxhRKWjgnJSLwoGs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZvxtssIvtoFYupLWVv54BPyYcFNiA1KS9aQ8n/ctA2Q=; b=fD1v9EayLekzn76sNhoa8yYjrP/4orn6xfCsC0lsxbau+hzvUrtdOdMpmlRS3RlXsm 9AJyzaSS7EdkbmcA4swZbq6FXmNRyw9tHKfjQ9bPvq7F1oc4swUG8lNXt3VkwQbNHUOb kLDgm4SoLjIDdZfwjejQX0Nhbqx7RDwGY6GD0VkXeNEAupBXaRykbmReAI86NCsb1e03 NSlM4AEtcSMYCuggiJZN4NXFA539RYzGcP5O5LbBNkKwhrFPgZfatwAMzTt1NazKCw/g OlECYW7c6OtCoZBNZQ6GfqcaQ+0kK8gwCnlRnsEPSs+IcJS3Mpjfo2XA+n481Vgr03zc fuNQ== X-Gm-Message-State: AJIora9R8YQajmT//juFLcwJsmc0YhhWCcZ8dpaVdV9tFMSjQYKbyCCi oy13DHCYNLUcos2nwbdz3XTfoA== X-Google-Smtp-Source: AGRyM1vipYtXDQ0CAyWWxu+6Zvss+Qgr3C2OF6dNknVLJ4sz55B3xVInH5siiLugsmdohehcRfEjfA== X-Received: by 2002:a17:903:22c2:b0:16a:3039:adb1 with SMTP id y2-20020a17090322c200b0016a3039adb1mr5619291plg.28.1655803145681; Tue, 21 Jun 2022 02:19:05 -0700 (PDT) Received: from treapking.tpe.corp.google.com ([2401:fa00:1:10:88f:3824:fbf6:53ef]) by smtp.gmail.com with ESMTPSA id v1-20020a62c301000000b00522c3f34362sm10609720pfg.215.2022.06.21.02.19.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 02:19:05 -0700 (PDT) From: Pin-Yen Lin To: Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: Hsin-Yi Wang , Eizan Miyamoto , Pin-Yen Lin , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH v3] arm64: dts: mt8173: Fix elm panel DT node Date: Tue, 21 Jun 2022 17:18:54 +0800 Message-Id: <20220621091854.1904372-1-treapking@chromium.org> X-Mailer: git-send-email 2.37.0.rc0.104.g0611611a94-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220621_021917_490726_81F45AC0 X-CRM114-Status: GOOD ( 15.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Move the panel DT node under `aux-bus` node, so it won't use the buggy `ps8640_bridge_get_edid` to get the display modes. Also, change the compatible string from "lg,lp120up1" to "edp-panel", so the panel-edp driver gets the displays modes from the EDID instead of using the predefined display mode (`lg_lp129qe_mode`) in the driver, which is actually not working. Signed-off-by: Pin-Yen Lin --- Changes in v3: - Include more details in the commit message. Changes in v2: - Remove the Fixes tag because this change is not compatible with the old kernel versions. arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 26 +++++++++++--------- 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi index 9c75fbb31f98..1e0802a6f6d2 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi @@ -90,18 +90,6 @@ volume_up { }; }; - panel: panel { - compatible = "lg,lp120up1"; - power-supply = <&panel_fixed_3v3>; - backlight = <&backlight>; - - port { - panel_in: endpoint { - remote-endpoint = <&ps8640_out>; - }; - }; - }; - panel_fixed_3v3: regulator1 { compatible = "regulator-fixed"; regulator-name = "PANEL_3V3"; @@ -282,6 +270,20 @@ ps8640_out: endpoint { }; }; }; + + aux-bus { + panel { + compatible = "edp-panel"; + power-supply = <&panel_fixed_3v3>; + backlight = <&backlight>; + + port { + panel_in: endpoint { + remote-endpoint = <&ps8640_out>; + }; + }; + }; + }; }; };