| Message ID | 20220624133700.15487-5-guodong.liu@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pinctrl: mediatek: add driver support driving and resistance property on mt8192 | expand |
Hi Guodong, On Fri, Jun 24, 2022 at 09:36:59PM +0800, Guodong Liu wrote: > Function bias_combo getter/setters already handle all cases advanced drive > configuration, include drive for I2C related pins. This commit message could be improved. I suggest using the following commit message: The bias_combo getter/setter is already able to handle advanced drive configuration, which is the reason commit 353d2ef77f2b ("dt-bindings: pinctrl: mt8192: Use generic bias instead of pull-*-adv") dropped the pull-up-adv and pull-down-adv properties from the binding. With those properties removed, there's no longer any use for the adv_pull callbacks, so drop them. > > Signed-off-by: Guodong Liu <guodong.liu@mediatek.com> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Thanks, Nícolas
-----Original Message----- From: Nícolas F. R. A. Prado <nfraprado@collabora.com> To: Guodong Liu <guodong.liu@mediatek.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Rob Herring < robh+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, Sean Wang <sean.wang@kernel.org>, Sean Wang <sean.wang@mediatek.com>, Zhiyong Tao <zhiyong.tao@mediatek.com>, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v2 4/5] pinctrl: mediatek: dropping original advanced drive configuration function Date: Fri, 24 Jun 2022 12:08:10 -0400 Hi Guodong, On Fri, Jun 24, 2022 at 09:36:59PM +0800, Guodong Liu wrote: > Function bias_combo getter/setters already handle all cases advanced > drive > configuration, include drive for I2C related pins. This commit message could be improved. I suggest using the following commit message: The bias_combo getter/setter is already able to handle advanced drive configuration, which is the reason commit 353d2ef77f2b ("dt-bindings: pinctrl: mt8192: Use generic bias instead of pull-*-adv") dropped the pull-up- adv and pull-down-adv properties from the binding. With those properties removed, there's no longer any use for the adv_pull callbacks, so drop them. When commit info include info "commit 353d2ef77f2b", local check pathch will report "WARNING:UNKNOWN_COMMIT_IO: Unknow commit id '353d2ef77f2b'", so isn't add those commit info here. thanks! > > Signed-off-by: Guodong Liu <guodong.liu@mediatek.com> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Thanks, Nícolas
diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8192.c b/drivers/pinctrl/mediatek/pinctrl-mt8192.c index ffb0b04f0e3c..2fe51fb6b266 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mt8192.c +++ b/drivers/pinctrl/mediatek/pinctrl-mt8192.c @@ -1466,8 +1466,6 @@ static const struct mtk_pin_soc mt8192_data = { .bias_get_combo = mtk_pinconf_bias_get_combo, .drive_set = mtk_pinconf_drive_set_rev1, .drive_get = mtk_pinconf_drive_get_rev1, - .adv_pull_get = mtk_pinconf_adv_pull_get, - .adv_pull_set = mtk_pinconf_adv_pull_set, .adv_drive_get = mtk_pinconf_adv_drive_get_raw, .adv_drive_set = mtk_pinconf_adv_drive_set_raw, };
Function bias_combo getter/setters already handle all cases advanced drive configuration, include drive for I2C related pins. Signed-off-by: Guodong Liu <guodong.liu@mediatek.com> --- drivers/pinctrl/mediatek/pinctrl-mt8192.c | 2 -- 1 file changed, 2 deletions(-)