From patchwork Fri Jun 24 15:23:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 12894766 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7C0DC43334 for ; Fri, 24 Jun 2022 15:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SveQDbL2KwLMWbR4zJ710zsAvd4pndxu0caKeLPW9aI=; b=oowY4Zuglf41ts 3Djla2W/ePR1EGWEO3iY3+oYJ40HF1MvRPIxa2tv6pcEmNWKNBIk1Jm6PBTGDayv4M0wJiv0oxg99 BixlAFfCW5lWoi/70au7/IIZEWopv9LWf4rViLrsTDYx86JD4GesCEWeK/afaQZGngX3s61rr88S0 ZnNHmYaBEfk7cUKLVDMTwXXT3sNbUtiI31KXQsctvS0L4gMBKVhqT+smFvDG3sDRARjnpxIGn1bL2 xUMwnTsd/kuOkVYMqmg9LBMmphOkbrxMgDzPTJbShBtYrDP8aEIbepvuEWCbJl4ZDUFAVbWAZFfBX N63sW8aiu3IJOCyBzHRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4lBM-002qUw-MY; Fri, 24 Jun 2022 15:25:17 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4l9z-002pza-L4 for linux-arm-kernel@lists.infradead.org; Fri, 24 Jun 2022 15:23:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F274E143D; Fri, 24 Jun 2022 08:23:45 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A00FC3F534; Fri, 24 Jun 2022 08:23:44 -0700 (PDT) From: Sudeep Holla To: linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org Cc: Sudeep Holla , Ard Biesheuvel , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Jose Marinho Subject: [PATCH 1/3] arm64: efi: Simplify arch_efi_call_virt macro by not using efi_##f##_t type Date: Fri, 24 Jun 2022 16:23:29 +0100 Message-Id: <20220624152331.4009502-2-sudeep.holla@arm.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220624152331.4009502-1-sudeep.holla@arm.com> References: <20220624152331.4009502-1-sudeep.holla@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220624_082351_821538_38E05643 X-CRM114-Status: GOOD ( 11.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently, the arch_efi_call_virt() assumes all users of it will have defined a type 'efi_##f##_t' to make use of it. It is unnecessarily forcing the users to create a new typedef when __efi_rt_asm_wrapper() actually expects void pointer. Simplify the arch_efi_call_virt() macro by typecasting p->f to (void *) as required by __efi_rt_asm_wrapper() and eliminate the explicit need for efi_##f##_t type for every user of this macro. This is needed now in preparation to enable PRMT support on ARM64. Signed-off-by: Sudeep Holla --- arch/arm64/include/asm/efi.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Hi Ard, I am not sure if you prefer to add type for each users of this or this is acceptable. I see only compile time advantage but I am not sure if it make sense to add typedefs in ACPI PRMT driver just for this reason. Let me know. Regards, Sudeep diff --git a/arch/arm64/include/asm/efi.h b/arch/arm64/include/asm/efi.h index ad55079abe47..263d7fd67207 100644 --- a/arch/arm64/include/asm/efi.h +++ b/arch/arm64/include/asm/efi.h @@ -29,9 +29,7 @@ int efi_set_mapping_permissions(struct mm_struct *mm, efi_memory_desc_t *md); #define arch_efi_call_virt(p, f, args...) \ ({ \ - efi_##f##_t *__f; \ - __f = p->f; \ - __efi_rt_asm_wrapper(__f, #f, args); \ + __efi_rt_asm_wrapper((void *)p->f, #f, args); \ }) #define arch_efi_call_virt_teardown() \