| Message ID | 20220708090853.717819-1-m.felsch@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Revert "soc: imx: imx8m-blk-ctrl: set power device name" | expand |
Hi, gentle ping. Regards, Marco On 22-07-08, Marco Felsch wrote: > This reverts commit 8239d67f59cf522dd4f7135392a2f9a3a25f9cff. > > This change confuses the sysfs cleanup path since the rename is done > after the device registration. > > Fixes: 8239d67f59cf ("soc: imx: imx8m-blk-ctrl: set power device name") > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > drivers/soc/imx/imx8m-blk-ctrl.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c > index 07b60d125698..409b9dfebb20 100644 > --- a/drivers/soc/imx/imx8m-blk-ctrl.c > +++ b/drivers/soc/imx/imx8m-blk-ctrl.c > @@ -271,7 +271,6 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev) > ret = PTR_ERR(domain->power_dev); > goto cleanup_pds; > } > - dev_set_name(domain->power_dev, "%s", data->name); > > domain->genpd.name = data->name; > domain->genpd.power_on = imx8m_blk_ctrl_power_on; > -- > 2.30.2 > > >
Am Freitag, dem 08.07.2022 um 11:08 +0200 schrieb Marco Felsch: > This reverts commit 8239d67f59cf522dd4f7135392a2f9a3a25f9cff. > > This change confuses the sysfs cleanup path since the rename is done > after the device registration. > > Fixes: 8239d67f59cf ("soc: imx: imx8m-blk-ctrl: set power device name") > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > --- > drivers/soc/imx/imx8m-blk-ctrl.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c > index 07b60d125698..409b9dfebb20 100644 > --- a/drivers/soc/imx/imx8m-blk-ctrl.c > +++ b/drivers/soc/imx/imx8m-blk-ctrl.c > @@ -271,7 +271,6 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev) > ret = PTR_ERR(domain->power_dev); > goto cleanup_pds; > } > - dev_set_name(domain->power_dev, "%s", data->name); > > domain->genpd.name = data->name; > domain->genpd.power_on = imx8m_blk_ctrl_power_on;
On Fri, Jul 08, 2022 at 11:08:53AM +0200, Marco Felsch wrote: > This reverts commit 8239d67f59cf522dd4f7135392a2f9a3a25f9cff. > > This change confuses the sysfs cleanup path since the rename is done > after the device registration. > > Fixes: 8239d67f59cf ("soc: imx: imx8m-blk-ctrl: set power device name") > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> Applied, thanks!
diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c index 07b60d125698..409b9dfebb20 100644 --- a/drivers/soc/imx/imx8m-blk-ctrl.c +++ b/drivers/soc/imx/imx8m-blk-ctrl.c @@ -271,7 +271,6 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev) ret = PTR_ERR(domain->power_dev); goto cleanup_pds; } - dev_set_name(domain->power_dev, "%s", data->name); domain->genpd.name = data->name; domain->genpd.power_on = imx8m_blk_ctrl_power_on;
This reverts commit 8239d67f59cf522dd4f7135392a2f9a3a25f9cff. This change confuses the sysfs cleanup path since the rename is done after the device registration. Fixes: 8239d67f59cf ("soc: imx: imx8m-blk-ctrl: set power device name") Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- drivers/soc/imx/imx8m-blk-ctrl.c | 1 - 1 file changed, 1 deletion(-)