From patchwork Tue Jul 12 12:18:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kepplinger X-Patchwork-Id: 12914877 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A779BC43334 for ; Tue, 12 Jul 2022 12:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=5N4f3qN/yrKGkapW4ZUPULy4oXUOOB5goAEmcL//Cek=; b=e6oU+h0c2b6Rio lZfn0wfrMfuLbOF34ojQAV39elDivgxjUFiQsYugnRhUQtkBvQWF4JRLgXD+rp7gnKdHlUTD34exk 3E3Gwl3Cd5WnZdhQVoXD5Z+dXwqa3HmpqSbUCgdFKtS2Ppz+VnO7wDv2pcSKvK9HyCkDiNhOKUIDr Egph1zuLeq/2DMJOL6tDQtcdoFGr9UpxYD6wVyF32huVQwbS4J0hCAjn8MlGl4qa8gPllKnkTGLRO LISJatxSOIxRB98KuA2bcxcx1MsSijhu5E5hdUGqNc1tCrqQx4Tmz9t6n0SVEmnJCrfNTLtGrKCyh qONCR7rWHWQTfzXjVcvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBErG-00AuPi-Bw; Tue, 12 Jul 2022 12:19:18 +0000 Received: from comms.puri.sm ([159.203.221.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBErC-00AuMe-P6 for linux-arm-kernel@lists.infradead.org; Tue, 12 Jul 2022 12:19:16 +0000 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 27930DFF4B; Tue, 12 Jul 2022 05:19:08 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id glJvJPJ7ZNPy; Tue, 12 Jul 2022 05:19:07 -0700 (PDT) From: Martin Kepplinger DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=puri.sm; s=comms; t=1657628347; bh=acox3CFtKaZJSGeRCEd240f4YrVQ/SjtXIZA6ATfx3M=; h=From:To:Cc:Subject:Date:From; b=Ws41I4BQ3pcDRYIvcUALYgsYe/hcXaliNlZcmu0vCfUT1LlNCGV73fHtci99eNBm9 yKRvdCGrNPRaGUm1ZK3daNPRJAY/puFTw0R2XZ7d1MJnq80pt5FCbIsBpqqVn8Hjii byHQortrliQlK6Q4tmYCnLWExQCJdFdJGUEp+tVsdFC8A80PVoVQu9cETCN7Ar0ZKO 3KANVVsQ3NZRYxNpEWztD22AXiBnnxlhdHAT6MtGAkCYdHEPJRDfnteTXLd4zxi8VS h4xYk6J4DcGzxkbW0s3lh74cQ1bsRtTpHzy5NnulqwMNeZ5wJiwcsKnJgrVPybopIg 7Q+BBaEc9LiFQ== To: rafael@kernel.org, khilman@kernel.org, ulf.hansson@linaro.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, pavel@ucw.cz Cc: kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org, l.stach@pengutronix.de, aford173@gmail.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Martin Kepplinger Subject: [PATCH v2] power: domain: handle power supplies that need interrupts Date: Tue, 12 Jul 2022 14:18:32 +0200 Message-Id: <20220712121832.3659769-1-martin.kepplinger@puri.sm> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220712_051914_840743_6FA79326 X-CRM114-Status: GOOD ( 12.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If the power-domains' power-supply node (regulator) needs interrupts to work, the current setup with noirq callbacks cannot work; for example a pmic regulator on i2c, when suspending, usually already times out during suspend_noirq: [ 41.024193] buck4: failed to disable: -ETIMEDOUT So fix system suspend and resume for these power-domains by using the "outer" suspend/resume callbacks instead. Tested on the imx8mq-librem5 board, but by looking at the dts, this will fix imx8mq-evk and possibly other boards too. Possibly one can find more changes than suspend/resume for this case. They can be added later when testing them. Initially system suspend problems had been discussed at https://lore.kernel.org/linux-arm-kernel/20211002005954.1367653-8-l.stach@pengutronix.de/ which led to discussing the pmic that contains the regulators which serve as power-domain power-supplies: https://lore.kernel.org/linux-pm/573166b75e524517782471c2b7f96e03fd93d175.camel@puri.sm/T/ Signed-off-by: Martin Kepplinger --- revision history ---------------- v2: (thank you Krzysztof) * rewrite: find possible regulators' interrupts property in parents instead of inventing a new property. v1: (initial idea) https://lore.kernel.org/linux-arm-kernel/20220711094549.3445566-1-martin.kepplinger@puri.sm/T/#t drivers/base/power/domain.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 3e86772d5fac..ca3e3500939d 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -2298,6 +2298,28 @@ static bool genpd_present(const struct generic_pm_domain *genpd) return ret; } +/** + * of_genpd_get_power_supply_irq() - Adjust if power-supply needs interrupts + * @genpd: Pointer to PM domain associated with the PM domain provider. + */ +static void of_genpd_get_power_supply_irq(struct generic_pm_domain *pd) +{ + struct device_node *dn; + + dn = of_parse_phandle(pd->dev.of_node, "power-supply", 0); + if (!dn) + return; + + while ((dn = of_get_next_parent(dn))) { + if (of_get_property(dn, "interrupts", NULL)) { + pd->domain.ops.suspend = genpd_suspend_noirq; + pd->domain.ops.resume = genpd_resume_noirq; + pd->domain.ops.suspend_noirq = NULL; + pd->domain.ops.resume_noirq = NULL; + } + } +} + /** * of_genpd_add_provider_simple() - Register a simple PM domain provider * @np: Device node pointer associated with the PM domain provider. @@ -2343,6 +2365,8 @@ int of_genpd_add_provider_simple(struct device_node *np, genpd->provider = &np->fwnode; genpd->has_provider = true; + of_genpd_get_power_supply_irq(genpd); + return 0; } EXPORT_SYMBOL_GPL(of_genpd_add_provider_simple); @@ -2394,6 +2418,8 @@ int of_genpd_add_provider_onecell(struct device_node *np, genpd->provider = &np->fwnode; genpd->has_provider = true; + + of_genpd_get_power_supply_irq(genpd); } ret = genpd_add_provider(np, data->xlate, data);