diff mbox series

dt-bindings: arm: Add Asus GT-AC6000 based on BCM4912

Message ID 20220713121234.32604-1-zajec5@gmail.com (mailing list archive)
State New, archived
Headers show
Series dt-bindings: arm: Add Asus GT-AC6000 based on BCM4912 | expand

Commit Message

Rafał Miłecki July 13, 2022, 12:12 p.m. UTC 
From: Rafał Miłecki <rafal@milecki.pl>

It's a home router, the first BCM4912 SoC based public device.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring (Arm) July 18, 2022, 2:25 p.m. UTC | #1 
On Wed, Jul 13, 2022 at 02:12:34PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> It's a home router, the first BCM4912 SoC based public device.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> index b817051c491d..40bb5223740b 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> @@ -31,6 +31,7 @@ properties:
>        - description: BCM4912 based boards
>          items:
>            - enum:
> +              - asus,gt-ax6000

The subject says it is gt-ac6000. Which is wrong?

>                - brcm,bcm94912
>            - const: brcm,bcm4912
>            - const: brcm,bcmbca
> -- 
> 2.34.1
> 
>
Rafał Miłecki July 18, 2022, 4:29 p.m. UTC | #2 
On 18.07.2022 16:25, Rob Herring wrote:
> On Wed, Jul 13, 2022 at 02:12:34PM +0200, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> It's a home router, the first BCM4912 SoC based public device.
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> ---
>>   Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
>> index b817051c491d..40bb5223740b 100644
>> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
>> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
>> @@ -31,6 +31,7 @@ properties:
>>         - description: BCM4912 based boards
>>           items:
>>             - enum:
>> +              - asus,gt-ax6000
> 
> The subject says it is gt-ac6000. Which is wrong?

The correct name is Asus GT-AX6000. I fixed that in following patch:
[PATCH 1/2] dt-bindings: arm: Add Asus GT-AX6000 based on BCM4912
which was accepted instead of this one.


>>                 - brcm,bcm94912
>>             - const: brcm,bcm4912
>>             - const: brcm,bcmbca
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
index b817051c491d..40bb5223740b 100644
--- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
+++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
@@ -31,6 +31,7 @@  properties:
       - description: BCM4912 based boards
         items:
           - enum:
+              - asus,gt-ax6000
               - brcm,bcm94912
           - const: brcm,bcm4912
           - const: brcm,bcmbca