From patchwork Wed Jul 13 15:49:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 12916937 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99CCBC43334 for ; Wed, 13 Jul 2022 15:51:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=llrL8/pYIxMTKW/VTLfSTStgjWCs6alUtEywHk4MARw=; b=l6vg+icNRXUKIj GcSXbtgh3xGCbwELCMC3Dp4/f4f8aJdpdy7gpHkZH8lKcaVssXsb0VwKYOHTehn40+i9Po4GHf3im dhO5g6pjGwpf68Q0W8a3hF4KIbbEw4prPTLa74kK2fchcbZLiqJnYR694sOHMWyzuyI+w2eCheKRS kh1w/NfrwI5aN3O0Rx5iSOGA7jPIWUF7HHOzoVKppCt16B8MP0FV5tcceL1KE4MqtwQWjTJPRs9RO 8LeeV4hXoDAD0BAEoedYskybOaezMyYskOkbBf0VOqAWT185CklPNeFj0H87dvp5qF82Ewlia+MP9 yZrj+orKfnuTGbdFzGMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBedR-005HZh-QD; Wed, 13 Jul 2022 15:50:45 +0000 Received: from mout.kundenserver.de ([212.227.126.134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBed8-005HIh-TA for linux-arm-kernel@lists.infradead.org; Wed, 13 Jul 2022 15:50:28 +0000 Received: from localhost.localdomain ([37.4.249.155]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mw99Y-1nJYVH2GyC-00s74U; Wed, 13 Jul 2022 17:50:15 +0200 From: Stefan Wahren To: Florian Fainelli , Michael Turquette , Stephen Boyd Cc: bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH 3/3] clk: bcm: rpi: Show clock id limit in error case Date: Wed, 13 Jul 2022 17:49:53 +0200 Message-Id: <20220713154953.3336-4-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220713154953.3336-1-stefan.wahren@i2se.com> References: <20220713154953.3336-1-stefan.wahren@i2se.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:8mnJLUyPm2j8Dg6SBPoCNRDkohg99QfXZh8VkkEFevhN5A6P6sP nBIu5b5oVOrVqz3RSRFIq/uvpy8hRPJ76z3/Gq8xekVgq9nMbwd+DKEpOsafopJTe3ZoNbG rg5Nf2ARTxJpVuqZ/sVPOG3PCFWDRbwpP96G9qAh7D6ZqiRcSYeg7WVA+H1/fmHiZucdO4v EoZpfSGSrYOSQd0Rzhbow== X-UI-Out-Filterresults: notjunk:1;V03:K0:Xh7qk7C8uOs=:qEDdAYmcQ/dTXZQ1jLyBfq zkdBlORYvpKG8v663Z5MWcbMXp/+tH3PPt/IuLuSRAo/l2mhH/pkwu5bkqXPxDB7X14qPGJxG GW8/PIKtVkXTnCH/uyTEGbptdwjzV6s8FIV3Y7oj8WUFX1ukITic9N0+BgjzpRnn+pK7MoI7T PqmR3ow9dHX6X/9nrjaCEmsEGpI+R2eMCW6tOv8kCoQXxM+Q5FgYM58wW72vbD/S9Xxv+NIsT 0pMEYL3EkHbfIqs9Dor2KA7NmJIzzDBvGoyUBRon1Bu00cAkcWZZ8rLkcz/W0aRTRgBpkWKVn HE9A9Zxri71tFjALCWelIGJJX9Pcm//cjuspEclemlYfLbIUacpEIRpigPnI4qR+KAFL83tCV XjcPrOzPXzY0pce1xjTcywqqU1quRtF/j+3SG87gsrQjOhlwBl5CfPXNIzAtF9pJ7SKQBZT6t borKQtg4eBXem6TBwqadm91XxwzY/bEfwKB6BYbzLLh7nUtd5KpQGzFLCLOxmPXN/ozrFBPzu cw4KZZZ1Bvtq8qFiNopEwXO0zg1FL1WPO8sNBHw0zcdr7xODpEGs3E1YdMsS8ZPk0QEHQQgXN Yf9/zYSZqItmIfGVIhqp+LPue1j+z1rK4CHzqgU4tXmFK4noCFz6BNT8zbHemLbk3BRpN5Kh8 P+xzDl9qszO4rH00teRQ76adlSrzG4zdCWypPaOIzCAWJwtz6DvHeGLd0LHCb8eUMUHRUIyXg K74mW/gBeft29x6gkJzdlykFaDmH0mwYaWczEcxVGvfUnw6eLsXhfySBfbU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220713_085027_264489_9ACFB65B X-CRM114-Status: GOOD ( 11.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The clock id limit will be extended in the future, so it would be helpful to see the actual clock id limit in case the firmware response has been rejected. Signed-off-by: Stefan Wahren Acked-by: Florian Fainelli --- drivers/clk/bcm/clk-raspberrypi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index b3b629516182..676e5379ebce 100644 --- a/drivers/clk/bcm/clk-raspberrypi.c +++ b/drivers/clk/bcm/clk-raspberrypi.c @@ -365,7 +365,8 @@ static int raspberrypi_discover_clocks(struct raspberrypi_clk *rpi, struct raspberrypi_clk_variant *variant; if (clks->id > RPI_FIRMWARE_NUM_CLK_ID) { - dev_err(rpi->dev, "Unknown clock id: %u\n", clks->id); + dev_err(rpi->dev, "Unknown clock id: %u (max: %u)\n", + clks->id, RPI_FIRMWARE_NUM_CLK_ID); return -EINVAL; }